Re: FixedInTrunk keyword?

2010-05-11 Thread Sander Temme
On May 10, 2010, at 11:36 AM, William A. Rowe Jr. wrote: > On 5/10/2010 1:28 PM, Daniel Ruggeri wrote: >> Hi, all. >> I found this document today stating the following: >>Each developer is responsible for notifying the mailing list and >> adding an action item to STATUS when they have an idea

Re: Reducing number of mod_lua hook directives

2010-05-11 Thread William A. Rowe Jr.
On 5/11/2010 9:47 AM, Dan Poirier wrote: >> >> LuaHook AccessChecker funcname /path/to/script.lua > > I just thought of a problem - right now, the funcname is optional > (defaults to "handle"). I hate having optional arguments that don't > come at the end. I'd just as soon make it a required arg

Re: Reducing number of mod_lua hook directives

2010-05-11 Thread Dan Poirier
On 2010-05-11 at 12:59, "Akins, Brian" wrote: > The hook runner itself should just be in lua. Instead of scripts, you write > lua modules. If a lua module has a function with the correct names (ie, > same as hooks) it uses that: > > Ie in my module foo > > function fixups( r ) > > > > W

Re: Reducing number of mod_lua hook directives

2010-05-11 Thread HyperHacker
On Tue, May 11, 2010 at 20:12, Dan Poirier wrote: > On 2010-05-11 at 12:55, HyperHacker wrote: >> On Tue, May 11, 2010 at 08:47, Dan Poirier wrote: >>> I just thought of a problem - right now, the funcname is optional >>> (defaults to "handle").  I hate having optional arguments that don't >>> c

Re: Reducing number of mod_lua hook directives

2010-05-11 Thread Dan Poirier
On 2010-05-11 at 12:55, HyperHacker wrote: > On Tue, May 11, 2010 at 08:47, Dan Poirier wrote: >> I just thought of a problem - right now, the funcname is optional >> (defaults to "handle").  I hate having optional arguments that don't >> come at the end.  I'd just as soon make it a required argu

Re: svn commit: r942899 - /httpd/httpd/branches/2.2.x/STATUS

2010-05-11 Thread Gregg L. Smith
Hi Stefan, WRT Windows, E:\build\httpd-2.2.x-dev\modules\filters\mod_reqtimeout.c(154) : error C2065: 'core_module' : undeclared identifier E:\build\httpd-2.2.x-dev\modules\filters\mod_reqtimeout.c(154) : error C2223: left of '->module_index' must point to struct/union Regards, Gregg s...

Re: Reducing number of mod_lua hook directives

2010-05-11 Thread Akins, Brian
The hook runner itself should just be in lua. Instead of scripts, you write lua modules. If a lua module has a function with the correct names (ie, same as hooks) it uses that: Ie in my module foo function fixups( r ) Would get called at fixups, etc. No need for a state per file, et

Re: Reducing number of mod_lua hook directives

2010-05-11 Thread HyperHacker
On Tue, May 11, 2010 at 08:47, Dan Poirier wrote: > On 2010-05-11 at 08:52, Dan Poirier wrote: > >> On 2010-05-10 at 16:03, "William A. Rowe Jr." wrote: >>> On 5/10/2010 2:25 PM, Brian McCallister wrote: > ... > > to > > LuaHook AccessChecker /path/to/script.lua  funcname >>>

Re: Reducing number of mod_lua hook directives

2010-05-11 Thread Dan Poirier
On 2010-05-11 at 08:52, Dan Poirier wrote: > On 2010-05-10 at 16:03, "William A. Rowe Jr." wrote: >> On 5/10/2010 2:25 PM, Brian McCallister wrote: ... to LuaHook AccessChecker /path/to/script.lua funcname LuaHook AuthChecker /path/to/script.lua funcname Lu

Re: Reducing number of mod_lua hook directives

2010-05-11 Thread HyperHacker
On Tue, May 11, 2010 at 06:52, Dan Poirier wrote: > On 2010-05-10 at 16:03, "William A. Rowe Jr." wrote: >> On 5/10/2010 2:25 PM, Brian McCallister wrote: ... to LuaHook AccessChecker /path/to/script.lua  funcname LuaHook AuthChecker   /path/to/script.lua  funcname >

Re: Reducing number of mod_lua hook directives

2010-05-11 Thread Dan Poirier
On 2010-05-10 at 16:03, "William A. Rowe Jr." wrote: > On 5/10/2010 2:25 PM, Brian McCallister wrote: >>> ... >>> >>> to >>> >>> LuaHook AccessChecker /path/to/script.lua funcname >>> LuaHook AuthChecker /path/to/script.lua funcname >>> LuaHook CheckUserID /path/to/script.lua funcname > > A