Re: memory leak in mod_slotmem_shm

2010-09-27 Thread Jim Jagielski
On Mon, Sep 27, 2010 at 08:03:51PM +0200, Rainer Jung wrote: > On 27.09.2010 19:19, Stefan Fritsch wrote: > >On Monday 27 September 2010, Jim Jagielski wrote: > >>>BTW, it is not that obvious that the shm is supposed to be > >>>cleaned up and re-created on graceful restarts. This should be > >>>do

Re: memory leak in mod_slotmem_shm

2010-09-27 Thread Rainer Jung
On 27.09.2010 19:19, Stefan Fritsch wrote: On Monday 27 September 2010, Jim Jagielski wrote: BTW, it is not that obvious that the shm is supposed to be cleaned up and re-created on graceful restarts. This should be documented in the code. That's an interesting point. I always assumed that i

Re: memory leak in mod_slotmem_shm

2010-09-27 Thread Jim Jagielski
On Sep 27, 2010, at 1:19 PM, Stefan Fritsch wrote: > On Monday 27 September 2010, Jim Jagielski wrote: >>> BTW, it is not that obvious that the shm is supposed to be >>> cleaned up and re-created on graceful restarts. This should be >>> documented in the code. >>> >>> >> >> That's an interest

Re: memory leak in mod_slotmem_shm

2010-09-27 Thread Stefan Fritsch
On Monday 27 September 2010, Jim Jagielski wrote: > > BTW, it is not that obvious that the shm is supposed to be > > cleaned up and re-created on graceful restarts. This should be > > documented in the code. > > > > > > That's an interesting point. I always assumed that it should be, > since one

Re: svn commit: r1001757 - /httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c

2010-09-27 Thread Stefan Fritsch
On Monday 27 September 2010, Jeff Trawick wrote: > On Mon, Sep 27, 2010 at 10:34 AM, wrote: > > Author: sf > > Date: Mon Sep 27 14:34:29 2010 > > New Revision: 1001757 > > > > URL: http://svn.apache.org/viewvc?rev=1001757&view=rev > > Log: > > fix another null pointer dereference found by clang >

Re: memory leak in mod_slotmem_shm

2010-09-27 Thread Jim Jagielski
On Sep 27, 2010, at 10:28 AM, Stefan Fritsch wrote: > On Monday 27 September 2010, Jim Jagielski wrote: >> On Sep 27, 2010, at 9:19 AM, Jim Jagielski wrote: >>> On Sep 27, 2010, at 8:17 AM, Jim Jagielski wrote: Let me look... On Sep 26, 2010, at 12:13 PM, Stefan Fritsch wrote: >>>

Re: htaccess support

2010-09-27 Thread Rich Bowen
On Sep 27, 2010, at 11:50 AM, Rich Bowen wrote: The testing I did was on a site with no .htaccess files. I did: AllowOverride All And, yes, I acknowledge that this is a stupid thing to do, and specifically discouraged in the documentation. It was to prove a point. :) -- Rich Bowen

Re: htaccess support

2010-09-27 Thread Rich Bowen
The testing I did was on a site with no .htaccess files. I did: AllowOverride All and that, all by itself (with no .htaccess files) dropped performance by about 25 - 50%, depending on how deep in the directory tree I went. I don't think I've ever done a 1.3/2.x comparison. On Sep 27, 2

Re: htaccess support

2010-09-27 Thread Graham Leggett
On 27 Sep 2010, at 4:02 PM, Igor Galić wrote: [snip] I am wondering however why there is a "use X instead of Y" meme floating around, instead of the far more practical "offer X in addition to Y". Let end users use X if they want to. X doesn't need to I guess through imprecise wording I jum

Re: htaccess support

2010-09-27 Thread Stefan Fritsch
On Monday 27 September 2010, Rich Bowen wrote: > As much as we dislike .htaccess files, they certainly seem to be > a necessary evil. You can disable them (although not at compile > time), but this is simply not an option for many folks. Educating > them when it's better to use the main config th

Re: svn commit: r1001757 - /httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c

2010-09-27 Thread Jeff Trawick
On Mon, Sep 27, 2010 at 10:34 AM, wrote: > Author: sf > Date: Mon Sep 27 14:34:29 2010 > New Revision: 1001757 > > URL: http://svn.apache.org/viewvc?rev=1001757&view=rev > Log: > fix another null pointer dereference found by clang > > Modified: >httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c

Re: htaccess support

2010-09-27 Thread Stefan Fritsch
On Monday 27 September 2010, Graham Leggett wrote: > .htaccess files are what they are, a way to configure the server > at request time. For obvious reasons, with a server where the > configuration is parsed on startup and then shared amongst all > children processes using copy-on-write, any atte

Re: memory leak in mod_slotmem_shm

2010-09-27 Thread Stefan Fritsch
On Monday 27 September 2010, Jim Jagielski wrote: > On Sep 27, 2010, at 9:19 AM, Jim Jagielski wrote: > > On Sep 27, 2010, at 8:17 AM, Jim Jagielski wrote: > >> Let me look... > >> > >> On Sep 26, 2010, at 12:13 PM, Stefan Fritsch wrote: > >>> Hi, > >>> > >>> mod_slotmem_shm creates a new global

Re: htaccess support

2010-09-27 Thread Igor Galić
- "Rich Bowen" wrote: > On Sep 27, 2010, at 7:44 AM, Igor Galić wrote: > > > > > Hi folks, > > I remotely remember that we briefly touched this topic on IRC, but I'd > really like to > bring this to the lists attention: > > .htaccess is one of the features that have guaranteed httpd's

Re: htaccess support

2010-09-27 Thread Igor Galić
[snip] > I am wondering however why there is a "use X instead of Y" meme > floating around, instead of the far more practical "offer X in > addition to Y". Let end users use X if they want to. X doesn't need to I guess through imprecise wording I jumped the wrong theme here. My intention was

Re: htaccess support

2010-09-27 Thread Rich Bowen
On Sep 27, 2010, at 7:44 AM, Igor Galić wrote: Hi folks, I remotely remember that we briefly touched this topic on IRC, but I'd really like to bring this to the lists attention: .htaccess is one of the features that have guaranteed httpd's success in the past, and at the same time it's

Re: htaccess support

2010-09-27 Thread Graham Leggett
On 27 Sep 2010, at 1:44 PM, Igor Galić wrote: I remotely remember that we briefly touched this topic on IRC, but I'd really like to bring this to the lists attention: .htaccess is one of the features that have guaranteed httpd's success in the past, and at the same time it's the single bigg

Re: memory leak in mod_slotmem_shm

2010-09-27 Thread Jim Jagielski
On Sep 27, 2010, at 9:19 AM, Jim Jagielski wrote: > > On Sep 27, 2010, at 8:17 AM, Jim Jagielski wrote: > >> Let me look... >> On Sep 26, 2010, at 12:13 PM, Stefan Fritsch wrote: >> >>> Hi, >>> >>> mod_slotmem_shm creates a new global pool on every graceful restart >>> but never destroys it.

Re: memory leak in mod_slotmem_shm

2010-09-27 Thread Jim Jagielski
On Sep 27, 2010, at 8:17 AM, Jim Jagielski wrote: > Let me look... > On Sep 26, 2010, at 12:13 PM, Stefan Fritsch wrote: > >> Hi, >> >> mod_slotmem_shm creates a new global pool on every graceful restart >> but never destroys it. >> >> From quickly looking at the code it is not clear to me wh

Re: memory leak in mod_slotmem_shm

2010-09-27 Thread Jim Jagielski
Let me look... On Sep 26, 2010, at 12:13 PM, Stefan Fritsch wrote: > Hi, > > mod_slotmem_shm creates a new global pool on every graceful restart > but never destroys it. > > From quickly looking at the code it is not clear to me what the > correct behaviour would be. Should the pool be created

htaccess support

2010-09-27 Thread Igor Galić
Hi folks, I remotely remember that we briefly touched this topic on IRC, but I'd really like to bring this to the lists attention: .htaccess is one of the features that have guaranteed httpd's success in the past, and at the same time it's the single biggest clutch imaginable. It's a support