Re: any reason for ssl_engine_kernel.c to use ap_log_error() when r and/or c are known?

2010-11-01 Thread Joe Orton
Generally no reason, no, there are lots of places in mod_ssl where _cerror should be used but the code predates the existence of _cerror; it's possible the SNI-related use of ap_log_error() in ssl_hook_ReadReq() is deliberate, however, I'm guessing. Regards, Joe

Re: any reason for ssl_engine_kernel.c to use ap_log_error() when r and/or c are known?

2010-11-01 Thread Peter Sylvester
On 11/01/2010 11:53 AM, Joe Orton wrote: Generally no reason, no, there are lots of places in mod_ssl where _cerror should be used but the code predates the existence of _cerror; it's possible the SNI-related use of ap_log_error() in ssl_hook_ReadReq() is deliberate, however, I'm guessing.

Questions before I add .n feature to rotatelogs

2010-11-01 Thread Dan Poirier
I'm working on a keep-N-files feature for rotatelogs (rename logfile to logfile.1, logfile.1 to logfile.2, etc up to N) but have a couple of concerns before I commit it. 1) Is it safe to rename an open file on all platforms? I know Unix is okay, and testing on Windows 2003 worked, but I'm not

mod_include: include virtual and error handling

2010-11-01 Thread Graham Leggett
Hi all, In mod_include, we currently only allow 200 OK responses to be included within the document. If any other code is returned, we replace the document body with a hard coded error string. This places a significant limitation on the usefulness of mod_include. Ideally, the included

Re: mod_authn_file + low ThreadStackSize = oops

2010-11-01 Thread Chris Darroch
Eric Covener wrote: I'd set my ThreadStackSize really low, to 64 KB, and while that usually lets you run without trouble I was just about to document that _lowering_ the stack size with ThreadStackSize is unreliable since the underlying call used only sets a _minimum_ stack size, not an

Why AllowEncodedSlashes config not merged?

2010-11-01 Thread Dan Poirier
Is there some subtle reason why config merging isn't implemented for AllowEncodedSlashes? Thanks, Dan

Re: Why AllowEncodedSlashes config not merged?

2010-11-01 Thread Jeff Trawick
On Mon, Nov 1, 2010 at 5:37 PM, Dan Poirier poir...@pobox.com wrote: Is there some subtle reason why config merging isn't implemented for AllowEncodedSlashes? http://svn.apache.org/viewvc?view=revisionrevision=98479 I guess oversight.

Re: svn commit: r1029814 - in /httpd/httpd/trunk/modules: cache/config.m4 core/config.m4 dav/fs/config6.m4 dav/lock/config6.m4 dav/main/config5.m4 debugging/config.m4 filters/config.m4 generators/conf

2010-11-01 Thread Jeff Trawick
On Mon, Nov 1, 2010 at 4:02 PM, poir...@apache.org wrote: Author: poirier Date: Mon Nov  1 20:02:51 2010 New Revision: 1029814 URL: http://svn.apache.org/viewvc?rev=1029814view=rev Log: Add to modules' help text (displayed by ./configure -h) more information that will be useful in

Re: svn commit: r1029814 - in /httpd/httpd/trunk/modules: cache/config.m4 core/config.m4 dav/fs/config6.m4 dav/lock/config6.m4 dav/main/config5.m4 debugging/config.m4 filters/config.m4 generators/conf

2010-11-01 Thread Dan Poirier
On Mon. 2010-11-01 at 06:51 PM EDT, Jeff Trawick traw...@gmail.com wrote: On Mon, Nov 1, 2010 at 4:02 PM, poir...@apache.org wrote: Author: poirier Date: Mon Nov  1 20:02:51 2010 New Revision: 1029814 URL: http://svn.apache.org/viewvc?rev=1029814view=rev Log: Add to modules' help text

Re: Why AllowEncodedSlashes config not merged?

2010-11-01 Thread Dan Poirier
On Mon. 2010-11-01 at 06:47 PM EDT, Jeff Trawick traw...@gmail.com wrote: On Mon, Nov 1, 2010 at 5:37 PM, Dan Poirier poir...@pobox.com wrote: Is there some subtle reason why config merging isn't implemented for AllowEncodedSlashes? http://svn.apache.org/viewvc?view=revisionrevision=98479