Re: trunk/2.4 core output filter is broken

2012-01-24 Thread Joe Orton
On Mon, Jan 23, 2012 at 09:39:38PM +0100, Stefan Fritsch wrote: This patch allows us to later add members to core_ctx_t without breaking binary compatibility to mod_ftp. Without such a patch, the size of core_ctx_t is part of the ABI, which is bad. Opinions? After thinking about it more:

Re: trunk/2.4 core output filter is broken

2012-01-24 Thread Stefan Fritsch
On Tue, 24 Jan 2012, Joe Orton wrote: On Mon, Jan 23, 2012 at 09:39:38PM +0100, Stefan Fritsch wrote: This patch allows us to later add members to core_ctx_t without breaking binary compatibility to mod_ftp. Without such a patch, the size of core_ctx_t is part of the ABI, which is bad.

Re: trunk/2.4 core output filter is broken

2012-01-24 Thread Jim Jagielski
Looking over the code, impl as a hook seems more isolated, rather than the current impl which is intrusive (which is part of what we're trying to avoid, aren't we?) On Jan 24, 2012, at 4:08 PM, Stefan Fritsch wrote: On Tue, 24 Jan 2012, Joe Orton wrote: On Mon, Jan 23, 2012 at 09:39:38PM