Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread Yann Ylavic
On Thu, Apr 14, 2016 at 10:58 PM, olli hauer wrote: > > OK, I've attached the output from a 2.4.18 scoreboard some sec. after > ab -k -n 10 -c 100 -f TLS1.2 $host/$url > > the 2.4.18 scoreboard looks similar to 2.4.20 with your patch Thank you very much olli.

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread olli hauer
On 2016-04-14 22:43, Yann Ylavic wrote: > On Thu, Apr 14, 2016 at 10:28 PM, olli hauer wrote: >> >> I've done some tests with 2.4.19 there is maybe an interesting detail. >> With 2.4.19 the last request is empty for an idle worker, with 2.4.20 not >> (shows the client, proto,

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread Yann Ylavic
On Thu, Apr 14, 2016 at 10:28 PM, olli hauer wrote: > > I've done some tests with 2.4.19 there is maybe an interesting detail. > With 2.4.19 the last request is empty for an idle worker, with 2.4.20 not > (shows the client, proto, Vhost and request) Sorry for the confusion,

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread olli hauer
On 2016-04-14 22:14, Yann Ylavic wrote: > On Thu, Apr 14, 2016 at 10:05 PM, olli hauer wrote: >> On 2016-04-14 21:48, Yann Ylavic wrote: >>> On Thu, Apr 14, 2016 at 9:40 PM, olli hauer wrote: I've done a quick test with $ ab -n 1 -c 100 $host/$url

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread olli hauer
On 2016-04-14 22:05, Rainer Jung wrote: > Am 14.04.2016 um 22:05 schrieb olli hauer: >> On 2016-04-14 21:48, Yann Ylavic wrote: >>> On Thu, Apr 14, 2016 at 9:40 PM, olli hauer wrote: I've done a quick test with $ ab -n 1 -c 100 $host/$url During the test

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread Yann Ylavic
On Thu, Apr 14, 2016 at 10:05 PM, olli hauer wrote: > On 2016-04-14 21:48, Yann Ylavic wrote: >> On Thu, Apr 14, 2016 at 9:40 PM, olli hauer wrote: >>> I've done a quick test with >>> $ ab -n 1 -c 100 $host/$url >>> >>> During the test the count of idle worker

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread Rainer Jung
Am 14.04.2016 um 22:05 schrieb olli hauer: On 2016-04-14 21:48, Yann Ylavic wrote: On Thu, Apr 14, 2016 at 9:40 PM, olli hauer wrote: I've done a quick test with $ ab -n 1 -c 100 $host/$url During the test the count of idle worker are incrementing and decrementing but

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread olli hauer
On 2016-04-14 21:48, Yann Ylavic wrote: > On Thu, Apr 14, 2016 at 9:40 PM, olli hauer wrote: >> I've done a quick test with >> $ ab -n 1 -c 100 $host/$url >> >> During the test the count of idle worker are incrementing and decrementing >> but it ab has finished the requests

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread olli hauer
On 2016-04-14 21:47, Eric Covener wrote: > On Thu, Apr 14, 2016 at 3:40 PM, olli hauer wrote: >> During the test the count of idle worker are incrementing and decrementing >> but it ab has finished the requests the count of idle workers stays on the >> last highest count ... > >

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread Yann Ylavic
On Thu, Apr 14, 2016 at 9:40 PM, olli hauer wrote: > I've done a quick test with > $ ab -n 1 -c 100 $host/$url > > During the test the count of idle worker are incrementing and decrementing > but it ab has finished the requests the count of idle workers stays on the > last

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread Eric Covener
On Thu, Apr 14, 2016 at 3:40 PM, olli hauer wrote: > During the test the count of idle worker are incrementing and decrementing > but it ab has finished the requests the count of idle workers stays on the > last highest count ... What was your MaxSpareThreads during the test?

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread olli hauer
On 2016-04-14 20:36, Yann Ylavic wrote: > On Thu, Apr 14, 2016 at 7:10 PM, olli hauer wrote: >> I got this morning a request from a FreeBSD user to back-port r1739008, and >> also already the feedback that scoreboard is usable again with the patch. >> >> Since I cannot find a

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread Yann Ylavic
On Thu, Apr 14, 2016 at 7:10 PM, olli hauer wrote: > I got this morning a request from a FreeBSD user to back-port r1739008, and > also already the feedback that scoreboard is usable again with the patch. > > Since I cannot find a reference in branches/2.4.x/STATUS for r1739008 I

Re: New segfault with 2.4.20 with mod_perl

2016-04-14 Thread William A Rowe Jr
The defect appears to be in t/protocol/TestProtocol/pseudo_http.pm... First, the handler is registered using PerlProcessConnectionHandler TestProtocol::pseudo_http so its activities are outside of the request handling phase. Note that this logic has been broken, for a long time;

Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/ssl_engine_kernel.c server/con

2016-04-14 Thread olli hauer
On 2016-04-13 22:04, Yann Ylavic wrote: > On Thu, Feb 25, 2016 at 11:27 AM, wrote: >> Author: icing >> Date: Thu Feb 25 10:27:27 2016 >> New Revision: 1732275 >> >> URL: http://svn.apache.org/viewvc?rev=1732275=rev >> Log: >> merging pre_close_connection hook,

Re: New segfault with 2.4.20 with mod_perl

2016-04-14 Thread William A Rowe Jr
We can be more vigilant about unexpectedly null values, however... how are you running request processing in the connection callback of mod_perl? That makes no sense, and probably signals a deeper logic error. The access checker is configured per-dir, so until the request rec is completely

Re: Unintended Side Effects (Was: Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/

2016-04-14 Thread Stefan Eissing
> Am 14.04.2016 um 15:09 schrieb Jim Jagielski : > > We should always ensure that when we fix something, or > when we add something, we don't change the current behavior > of httpd in an unintended way. This rev is a great example of > that. The clearing of those scoreboard

Unintended Side Effects (Was: Re: svn commit: r1732275 - in /httpd/httpd/branches/2.4.x: ./ include/ap_mmn.h include/http_connection.h include/scoreboard.h modules/generators/mod_status.c modules/ssl/

2016-04-14 Thread Jim Jagielski
We should always ensure that when we fix something, or when we add something, we don't change the current behavior of httpd in an unintended way. This rev is a great example of that. The clearing of those scoreboard slots is completely unrelated to the actual change itself. Of course, the "blame"

Re: Allow SSLProxy* config in context?

2016-04-14 Thread Rainer Jung
Am 14.04.2016 um 02:57 schrieb Daniel Ruggeri: On 4/13/2016 2:22 PM, Rainer Jung wrote: We could pass the worker name from mod_proxy to mod_ssl via a connection note, similar to currently already passing the SNI name via the connection note proxy-request-hostname. +1 on the connection note

Re: Allow SSLProxy* config in context?

2016-04-14 Thread Yann Ylavic
On Wed, Apr 13, 2016 at 7:49 PM, Rainer Jung wrote: > Am 13.04.2016 um 17:04 schrieb Graham Leggett: >> >> The catch is that mod_ssl forces us to declare SSL certs and keys server >> wide, not per directory, loaded and parsed at startup. We however want to >> specify

Re: New segfault with 2.4.20 with mod_perl

2016-04-14 Thread Takashi Sato
r->useragent_addr is assigned on ap_read_request (http_core.c), called from ap_process_http_(async_)connection called from process_connection hook (APR_HOOK_REALLY_LAST). The SEGV occured on process_connection hook, maybe before ap_process_http_(async_)connection, #11 0x7fd44f91fd4f in