Re: Detecting client aborts and stream resets

2016-05-03 Thread Michael Kaufmann
Zitat von William A Rowe Jr : On Tue, May 3, 2016 at 9:31 AM, Michael Kaufmann wrote: Hi all, a content generator module can detect client aborts and stream resets while it reads the request body. But how can it detect this afterwards, while

Re: Detecting client aborts and stream resets

2016-05-03 Thread Mike Rumph
Hello Michael. On 5/3/2016 7:31 AM, Michael Kaufmann wrote: Hi all, a content generator module can detect client aborts and stream resets while it reads the request body. But how can it detect this afterwards, while the response is being generated? This is important for HTTP/2, because the

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

2016-05-03 Thread Ruediger Pluem
On 05/03/2016 05:51 PM, William A Rowe Jr wrote: > On Mon, May 2, 2016 at 3:09 AM, Ruediger Pluem > wrote: > > > On 04/28/2016 10:19 AM, Ruediger Pluem wrote: > > > > On 04/27/2016 08:41 PM, wr...@apache.org

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

2016-05-03 Thread William A Rowe Jr
On Tue, May 3, 2016 at 10:51 AM, William A Rowe Jr wrote: > > If we want to be more robust, have a look at the current 2.4.x > implementation of ap_get_useragent_host() in core.c... > > if (r->useragent_addr == conn->client_addr) { > return

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

2016-05-03 Thread William A Rowe Jr
On Mon, May 2, 2016 at 3:09 AM, Ruediger Pluem wrote: > > On 04/28/2016 10:19 AM, Ruediger Pluem wrote: > > > > On 04/27/2016 08:41 PM, wr...@apache.org wrote: > >> Author: wrowe > >> Date: Wed Apr 27 18:41:49 2016 > >> New Revision: 1741310 > >> > >> URL:

Re: [PATCH 54255] mod_deflate adjusts the headers "too late"

2016-05-03 Thread William A Rowe Jr
Keep in mind that such changes alter the expected behavior that all of the third party module authors have worked around. This doesn't seem like a suitable change for 2.4.x maintenance branch but a good improvement for trunk, looking forwards. On Tue, May 3, 2016 at 9:42 AM, Michael Kaufmann

Re: Detecting client aborts and stream resets

2016-05-03 Thread William A Rowe Jr
On Tue, May 3, 2016 at 9:31 AM, Michael Kaufmann wrote: > Hi all, > > a content generator module can detect client aborts and stream resets > while it reads the request body. But how can it detect this afterwards, > while the response is being generated? > > This is

[PATCH 54255] mod_deflate adjusts the headers "too late"

2016-05-03 Thread Michael Kaufmann
Hi, It would be great if somebody could have a look at the proposed patch. The problem: Request headers are adjusted too late (in the input filter). Proposed solution: Adjust the request headers in the filter init function. https://bz.apache.org/bugzilla/show_bug.cgi?id=54255 Regards, Michael

Detecting client aborts and stream resets

2016-05-03 Thread Michael Kaufmann
Hi all, a content generator module can detect client aborts and stream resets while it reads the request body. But how can it detect this afterwards, while the response is being generated? This is important for HTTP/2, because the client may reset a stream, and mod_http2 needs to wait

Re: svn commit: r1734238 - in /httpd/httpd/trunk: docs/manual/mod/mod_proxy_http2.xml modules/http2/h2_proxy_session.c modules/http2/mod_proxy_http2.c

2016-05-03 Thread Stefan Eissing
Thanks, Eric. Fixed in r1742073. -Stefan > Am 02.05.2016 um 20:25 schrieb Eric Covener : > > On Wed, Mar 9, 2016 at 8:41 AM, wrote: >> +mod_proxy_http2 works with incoming requests >> +over HTTP/1.1 and HTTP/2 requests. If mod_proxy_http2 >> +