Re: Detecting client aborts and stream resets

2016-05-04 Thread William A Rowe Jr
On Wed, May 4, 2016 at 3:44 PM, Michael Kaufmann wrote: > William is right, this is not a good idea. The ->aborted flag should serve >> this purpose of telling anyone interested that this connection is not >> longer delivering. I will make a github release soon where

Re: Detecting client aborts and stream resets

2016-05-04 Thread Michael Kaufmann
William is right, this is not a good idea. The ->aborted flag should serve this purpose of telling anyone interested that this connection is not longer delivering. I will make a github release soon where that is working and you can test. Thank you Stefan! It is now working for stream

Re: Detecting client aborts and stream resets

2016-05-04 Thread William A Rowe Jr
On Tue, May 3, 2016 at 2:05 PM, Michael Kaufmann wrote: > Zitat von William A Rowe Jr : > >> >> Nope - an optional function in mod_http2 is too special case, generators >> must remain protocol (socket or other transport) agnostic. >> > > Sure,

OpenSSL Patch requires new treatment of dual certificate configurations with ServerInfoFile

2016-05-04 Thread Jason -
Hi to all. I would like to draw your attention to a new patch for OpenSSL which will ultimately mean that Apache needs to treat dual EC-RSA certificate configurations with server info (currently used only for TLS extension of certificate transparency) differently than until now. Specifically,

Re: core_output, files and setaside

2016-05-04 Thread Graham Leggett
On 04 May 2016, at 3:22 PM, Stefan Eissing wrote: > file_bucket_setaside() currently does not care about the refcount. setaside > affects *all* shared file buckets, wherever they currently reside. So it > moves the contained apr_file_t into the filter deferred

Re: core_output, files and setaside

2016-05-04 Thread Stefan Eissing
> Am 04.05.2016 um 13:49 schrieb Graham Leggett : > > On 04 May 2016, at 11:13 AM, Stefan Eissing > wrote: > >> The problem is not the apr_bucket_destroy(). The file bucket setaside, calls >> apr_file_setaside(), in core_output on a deferred

Re: core_output, files and setaside

2016-05-04 Thread Graham Leggett
On 04 May 2016, at 11:13 AM, Stefan Eissing wrote: > The problem is not the apr_bucket_destroy(). The file bucket setaside, calls > apr_file_setaside(), in core_output on a deferred pool, and then core_output > clears that pool. This invalidates all still

Re: core_output, files and setaside

2016-05-04 Thread Stefan Eissing
> Am 04.05.2016 um 11:09 schrieb Graham Leggett : > > On 04 May 2016, at 10:45 AM, Stefan Eissing > wrote: > >> I have been wrong before...but... >> >> mod_http2 needs to send out a file response: >> 1. it starts with the response body brigade:

Re: core_output, files and setaside

2016-05-04 Thread Graham Leggett
On 04 May 2016, at 10:45 AM, Stefan Eissing wrote: > I have been wrong before...but... > > mod_http2 needs to send out a file response: > 1. it starts with the response body brigade: [file:0-len][eos] > 2. it sends the first 16K frame by splitting the file bucket:

core_output, files and setaside

2016-05-04 Thread Stefan Eissing
I have been wrong before...but... mod_http2 needs to send out a file response: 1. it starts with the response body brigade: [file:0-len][eos] 2. it sends the first 16K frame by splitting the file bucket: -> passing to core output: [heap:frame header][file:0-16k] -> remaining body:

Re: Detecting client aborts and stream resets

2016-05-04 Thread Stefan Eissing
> Am 03.05.2016 um 17:35 schrieb William A Rowe Jr : > > On Tue, May 3, 2016 at 9:31 AM, Michael Kaufmann > wrote: > Hi all, > > a content generator module can detect client aborts and stream resets while > it reads the request body. But how can