Re: [VOTE] Release httpd-2.4.37

2018-10-23 Thread Ruediger Pluem
On 10/22/2018 04:08 PM, Daniel Ruggeri wrote: > On 2018-10-18 09:36, Daniel Ruggeri wrote: >> Hi, all; >>Please find below the proposed release tarball and signatures: >> https://dist.apache.org/repos/dist/dev/httpd/ >> >> I would like to call a VOTE over the next few days to release this

Re: ap_request_core_filter issues

2018-10-23 Thread Ruediger Pluem
On 10/23/2018 03:52 PM, Yann Ylavic wrote: > On Tue, Oct 23, 2018 at 3:18 PM Plüm, Rüdiger, Vodafone Group > wrote: >> >>> -Ursprüngliche Nachricht- >>> Von: Yann Ylavic >>> >>> I tried to implement that in the attached patch, WDYT? >> >> 1. Why removing the META_BUCKET check when

Re: ap_request_core_filter issues

2018-10-23 Thread Yann Ylavic
On Tue, Oct 23, 2018 at 3:52 PM Yann Ylavic wrote: > > Yeah, I have a version which checks only for > (APR_BUCKET_IS_FLUSH(bucket) || cumulative_tmp_bb_len >= > ap_get_core_module_config()->flush_max_threshold) See attached. Index: server/request.c

Re: ap_request_core_filter issues

2018-10-23 Thread Yann Ylavic
On Tue, Oct 23, 2018 at 3:18 PM Plüm, Rüdiger, Vodafone Group wrote: > > > -Ursprüngliche Nachricht- > > Von: Yann Ylavic > > > > I tried to implement that in the attached patch, WDYT? > > 1. Why removing the META_BUCKET check when reading buckets of length -1? I > don't see any sense

AW: ap_request_core_filter issues

2018-10-23 Thread Plüm , Rüdiger , Vodafone Group
> -Ursprüngliche Nachricht- > Von: Yann Ylavic > Gesendet: Dienstag, 23. Oktober 2018 13:09 > An: httpd-dev > Betreff: Re: ap_request_core_filter issues > > On Thu, Oct 18, 2018 at 1:52 PM Joe Orton wrote: > > > > On Thu, Oct 18, 2018 at 12:51:06PM +0200, Ruediger Pluem wrote: > > >

Re: SetHandler balancer-manager question.

2018-10-23 Thread Jim Jagielski
Yes, it is normal and expected behavior, but one can say that such behavior isn't "correct" or "should be changed", esp now that we can add members dynamically. So I would be +1 on changing the code to show all balancers, regardless of whether they have workers/members or not. > On Oct 23,

Re: ap_request_core_filter issues

2018-10-23 Thread Yann Ylavic
On Thu, Oct 18, 2018 at 1:52 PM Joe Orton wrote: > > On Thu, Oct 18, 2018 at 12:51:06PM +0200, Ruediger Pluem wrote: > > >>> > > >>> Curiously inefficient writev use when stracing the process, though, > > >>> dunno what's going on there (trunk/prefork): > > >>> > > >>> writev(46,

SetHandler balancer-manager question.

2018-10-23 Thread jean-frederic clere
Hi, I have started to look how to enhance mod_proxy_balancer to replace mod_cluster, the first question is it normal that a balancer without workers is NOT displayed by the handler? -- Cheers Jean-Frederic