Thx for both of you for the explanation.
Le 06/07/2020 à 11:56, Yann Ylavic a écrit :
[...]
Finally APR_BUCKET_IS_{EOS,}(e) on an EMPTY brigade is always false
with the current struct apr_bucket_brigade API.
That's also my understanding. That is what was puzzling me.
Just a bit fragile :)
Build Update for apache/httpd
-
Build: #963
Status: Passed
Duration: 14 mins and 56 secs
Commit: 023a72b (trunk)
Author: Graham Leggett
Message: Bump the logno.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1879548
Build Update for apache/httpd
-
Build: #962
Status: Canceled
Duration: 7 mins and 30 secs
Commit: 92470c0 (trunk)
Author: Ruediger Pluem
Message: * Update logno
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1879547
On 7/6/20 2:13 PM, rpl...@apache.org wrote:
> Author: rpluem
> Date: Mon Jul 6 12:13:33 2020
> New Revision: 1879546
>
> URL: http://svn.apache.org/viewvc?rev=1879546=rev
> Log:
> * Make get_line more robust in the case that it is called multiple times:
>
> - Safe the brigade between
Build Update for apache/httpd
-
Build: #960
Status: Still Failing
Duration: 11 mins and 42 secs
Commit: 7cb887b (trunk)
Author: Ruediger Pluem
Message: * Do not try to parse already aborted requests
Submitted by: icing
git-svn-id:
On Mon, Jul 6, 2020 at 12:37 PM Graham Leggett wrote:
>
> On 06 Jul 2020, at 09:28, Ruediger Pluem wrote:
>
> +apr_sha1_init();
> +nbytes = sizeof(buf);
> +while ((status = apr_file_read(fd, buf, )) == APR_SUCCESS) {
>
>
> Why do we still use apr_file_read in case we use MMAP? IMHO
Build Update for apache/httpd
-
Build: #958
Status: Broken
Duration: 9 mins and 21 secs
Commit: d047c6b (trunk)
Author: Graham Leggett
Message: Use a brigade instead of direct reads, allow APR to handle MMAP.
git-svn-id:
On 06 Jul 2020, at 09:28, Ruediger Pluem wrote:
>> +apr_sha1_init();
>> +nbytes = sizeof(buf);
>> +while ((status = apr_file_read(fd, buf, )) == APR_SUCCESS) {
>
> Why do we still use apr_file_read in case we use MMAP? IMHO we should use
> apr_mmap_offset.
> But we would need to
On Mon, Jul 6, 2020 at 11:56 AM Yann Ylavic wrote:
> >
> > In the previous code the first condition in the if was always true, and I
> > am not sure what happened with the second condition in
> > case e was the sentinel.
>
> AIUI, dereferencing the SENTINEL is not accessing unreserved/freed
>
On Mon, Jul 6, 2020 at 8:44 AM Ruediger Pluem wrote:
>
> On 7/5/20 9:29 AM, Christophe JAILLET wrote:
> >
> > Le 14/02/2017 à 17:43, yla...@apache.org a écrit :
> >> @@ -584,9 +584,9 @@ AP_DECLARE(apr_status_t) ap_pass_brigade
> >>apr_bucket_brigade
On 7/3/20 9:48 PM, minf...@apache.org wrote:
> Author: minfrin
> Date: Fri Jul 3 19:48:53 2020
> New Revision: 1879488
>
> URL: http://svn.apache.org/viewvc?rev=1879488=rev
> Log:
> Add MMAP support to ETag generation.
>
> Modified:
> httpd/httpd/trunk/server/util_etag.c
>
> Modified:
On 7/5/20 9:29 AM, Christophe JAILLET wrote:
> Le 14/02/2017 à 17:43, yla...@apache.org a écrit :
>> Author: ylavic
>> Date: Tue Feb 14 16:43:25 2017
>> New Revision: 1782986
>>
>> URL:http://svn.apache.org/viewvc?rev=1782986=rev
>> Log:
>> util_filter: better ap_pass_brigade() vs empty
12 matches
Mail list logo
