On Thu, 5 Nov 2020 at 16:39, Joe Orton <jor...@redhat.com> wrote: > > Hi, I've prepared a candidate release tarball for libapreq2 v2.15 here: > > https://dist.apache.org/repos/dist/dev/httpd/libapreq/ > > This release is mainly to address a security issue in libapreq2 which > has been outstanding for over a year, CVE-2019-12412. > > I would like to call a VOTE over the next few days to release this > candidate tarball as v2.15: > > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. >
+1 I think. At least it has the Win32 build fixes that have been unreleased for ages, so thanks for making this release. I am getting a test failure (Windows 10, VS2019 v16.7.3, httpd 2.4.41, perl 5.30.1), but this was happening with the unreleased "2.14" that I've been using recently anyway. Verbose output: D:\Dev\Temp\libapreq2-2.15\glue\perl>perl.exe -Iblib\arch -Iblib\lib t\TEST -verbose=1 t\apreq\cgi.t [...] t\apreq\cgi.t .. # writing file: D:\Dev\Temp\libapreq2-2.15\glue\perl\t\cgi-bin\test_cgi.pl 1..71 # Running under perl version 5.030001 for MSWin32 # Current time local: Fri Nov 6 17:19:49 2020 # Current time GMT: Fri Nov 6 17:19:49 2020 # Using Test.pm version 1.31 # Using Apache/Test.pm version 1.42 [...] ok 31 Odd number of elements in hash assignment at t\apreq\cgi.t line 197. # removing file: D:\Dev\Temp\libapreq2-2.15\glue\perl\t\cgi-bin\test_cgi.pl # removing dir tree: D:\Dev\Temp\libapreq2-2.15\glue\perl\t\cgi-bin Dubious, test returned 9 (wstat 2304, 0x900) Failed 40/71 subtests I get this in the error_log: [Fri Nov 06 17:19:56.558841 2020] [cgi:error] [pid 24136:tid 1104] [client 10.93.12.29:54076] End of script output before headers: test_cgi.pl [Fri Nov 06 17:19:56.558841 2020] [cgi:error] [pid 24136:tid 1104] [client 10.93.12.29:54076] AH01215: test_cgi.pl(20): Creating APR::Request::CGI object\r: D:/Dev/Temp/libapreq2-2.15/glue/perl/t/cgi-bin/test_cgi.pl [Fri Nov 06 17:19:56.558841 2020] [cgi:error] [pid 24136:tid 1104] [client 10.93.12.29:54076] AH01215: $param->upload_tempname($req): can't make spool bucket at D:\\Dev\\Temp\\libapreq2-2.15\\glue\\perl\\blib\\lib/APR/Request/Param.pm line 37.\r: D:/Dev/Temp/libapreq2-2.15/glue/perl/t/cgi-bin/test_cgi.pl [Fri Nov 06 17:19:56.559839 2020] [http:trace3] [pid 24136:tid 1104] http_filters.c(1125): [client 10.93.12.29:54076] Response sent with status 500, headers: Don't let this hold up the release since it isn't a new problem.
