Re: [PATCH] make test TEST_VERBOSE=1

2002-09-18 Thread Doug MacEachern
On Wed, 18 Sep 2002, Geoffrey Young wrote: I think the attached patch behaves as suggested. perfectly, thanks.

Re: [PATCH] make test TEST_VERBOSE=1

2002-09-18 Thread Doug MacEachern
On Wed, 18 Sep 2002, Doug MacEachern wrote: On Wed, 18 Sep 2002, Geoffrey Young wrote: I think the attached patch behaves as suggested. perfectly, thanks. with 5.8.0 that is. with 5.6.1, dies with: Error in option spec: verbose:1

Re: newbie question on perl-framework...

2002-09-18 Thread Doug MacEachern
On Tue, 17 Sep 2002, David Hill wrote: Tried that (twice) and it did not help. Thanks for the pointer to the config blocks, missed that in my RTFM-ing. If I hand hack a conf file based on your pointer, things run much better, but what a pain t/TEST -clean t/TEST -trace=debug will

Re: POST with no data

2002-09-17 Thread Doug MacEachern
i think lwp does the right thing, but TestRequest.pm does not. patch below should fix (untested). --- Apache-Test/lib/Apache/TestRequest.pm 4 Apr 2002 00:54:26 - 1.71 +++ Apache-Test/lib/Apache/TestRequest.pm 17 Sep 2002 20:22:38 - @@ -251,7 +251,7 @@

Re: minor change needed in mod_test_apr_uri.c

2002-09-17 Thread Doug MacEachern
On Mon, 16 Sep 2002, Dave Hill wrote: Hi, Just starting to use the test framework on Tru64. Bumped into a compiler issue... Our compiler does not like multiline implicite strings. You can do muliline strings, you just need to end them with '\n\'. Attached is a diff -c of my change. I

auth stuff still broken

2002-09-17 Thread Doug MacEachern
a fresh build/install of .42-dev: Cannot load /.../modules/mod_authn_file.so into server: /.../modules/mod_authn_file.so: undefined symbol: authn_register_provider stock httpd.conf is installed (by 'make install') with modules in this order: LoadModule authn_file_module

--with-mpm=worker on freebsd

2002-06-11 Thread Doug MacEachern
why is it on freebsd --with-mpm=worker actually compiles the prefork mpm? i just tried building on icarus with the 2.0.37 tarball, same thang with 2.0.36 % cat config.nice #! /bin/sh # # Created by configure CFLAGS=-g; export CFLAGS ./configure \ --prefix=/home/dougm/apache2-worker \

Re: --with-mpm=worker on freebsd

2002-06-11 Thread Doug MacEachern
On Tue, 11 Jun 2002, Cliff Woolley wrote: Because threads are forced to be disabled on FreeBSD. I believe there's a warning message about this in the ./configure output... you might just not have noticed it as it scrolled by. that's odd, why not just abort with a message sorry only prefork

Re: cvs commit: httpd-2.0 CHANGES

2002-06-10 Thread Doug MacEachern
to + the fix this situation would result in a FORBIDDEN response and + error message Cannot find peer certificate chain + [Doug MacEachern] + *) ap_finalize_sub_req_protocol() shouldn't send an EOS bucket if one was already sent. PR 9644 [Jeff Trawick]

Re: cvs commit: httpd-2.0 CHANGES

2002-06-10 Thread Doug MacEachern
On Mon, 10 Jun 2002, Doug MacEachern wrote: i'd be surprised if 'SSLOptions +OptRengotiate' actually ever worked for anybody before this change, including the 1.3 based modssl which still has this issue. i take that back a bit, i'd be surprised if it worked for anybody using netscape 4

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2002-06-03 Thread Doug MacEachern
this change is wrong. please revert and explain what you need so we can find the right solution. On 3 Jun 2002 [EMAIL PROTECTED] wrote: jerenkrantz2002/06/03 11:03:42 Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm Log: Only start one server instance until we

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2002-06-03 Thread Doug MacEachern
On Mon, 3 Jun 2002, Aaron Bannert wrote: Cliff is always mentioning something like t/TEST -d gdb or something like that. Won't that run in -X mode automatically? yes.

Re: cvs commit: httpd-test/perl-framework README

2002-06-03 Thread Doug MacEachern
On 3 Jun 2002 [EMAIL PROTECTED] wrote: aaron 2002/06/03 11:31:00 Modified:perl-framework README Log: Add a note about envoking gdb. note that this and heaps of other stuff is in httpd-test/perl-framework/Apache-Test/README which is where it belongs, since Apache-Test is

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2002-06-03 Thread Doug MacEachern
On Mon, 3 Jun 2002, Justin Erenkrantz wrote: The reason I don't like that is because if I need to restart the server I have to quit my gdb. I want my gdb to last longer than the process (so my breakpoints et al remain the same). you can use the -maxclients option or edit httpd.conf by hand

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2002-06-03 Thread Doug MacEachern
On Mon, 3 Jun 2002, Justin Erenkrantz wrote: Um, as I pointed out, none of the other MPMs are configured like this. Only prefork would start multiple servers. The others always run under a single process. -- justin yeah, cos threaded mpms can handle concurrent requests with one process,

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2002-06-03 Thread Doug MacEachern
On Mon, 3 Jun 2002, Doug MacEachern wrote: umm, not with MaxClients 1 it won't oh wait, you changed StartServers not MaxClients, maybe that isn't a problem.

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2002-06-03 Thread Doug MacEachern
On Mon, 3 Jun 2002, Justin Erenkrantz wrote: Um, I think you misread my commit. All I changed was StartServers. totally, i only read - @MaxClients@ + 1, never even saw StartServers. disregard my comments, they were meant for MaxClients, your change is fine with me.

rewritemap breakage

2002-05-31 Thread Doug MacEachern
seems that the test suite now requires httpd-2.0-cvs from HEAD? server does not start with 1.3.x or 2.0.36: Syntax error on line 139 of .../t/conf/extra.conf RewriteMap: map file or program not found:/.../t/htdocs/modules/rewrite/append.pl foo

Re: cvs commit: httpd-2.0/modules/http http_protocol.c

2002-05-31 Thread Doug MacEachern
On Fri, 31 May 2002, Justin Erenkrantz wrote: httpd-test has no tests for input filtering. mod_input_body_filter.c at least, no? the protocol/ tests also hit input filters. If I knew how to get perl to send bogus requests, I would. But, my perl-fu is severely lacking. -- justin see

Re: httpd-2.0 STATUS

2002-05-30 Thread Doug MacEachern
i see value the old modules/ssl/README. it has been very handy in the past, and i would expect it to be for anybody coming from mod_ssl 1.3 based sources to contribute to 2.0 or even just being brand new to the 2.0 source. now they have lost the source roadmap, summary of major changes,

Re: httpd-2.0 STATUS

2002-05-30 Thread Doug MacEachern
On Thu, 30 May 2002, William A. Rowe, Jr. wrote: Perhaps we could resurrect the porting history [although I believe it's horribly incomplete] as modules/ssl/HISTORY? OTOH, those parts that are correct aught to have been committed to CHANGES if they were not in the first place. they are in

Re: httpd-2.0 STATUS

2002-05-29 Thread Doug MacEachern
On Thu, 30 May 2002, William A. Rowe, Jr. wrote: is modules/ssl/README even valuable anymore? yes. fine to remove the stale stuff, but not the whole damn thing. there was a useful roadmap of the source in there and everything that was in the TODO section is still valid: o SSL

ap_os_escape_pathn ?

2002-05-24 Thread Doug MacEachern
ap_os_escape_path currently requires a pool argument to allocate the string and does a strlen on it. wondering if we could do something like the concept patch below, adding ap_os_escape_pathn which does not require a pool and the path arg would be assumed to be allocated to the correct size.

Re: libexpat

2002-05-22 Thread Doug MacEachern
On Wed, 22 May 2002, Greg Ames wrote: Which release of httpd? 1.3 has a Configure rule to turn off expat. right. i'm asking about 2.0 (my original message specified)

Re: libexpat

2002-05-21 Thread Doug MacEachern
On Tue, 21 May 2002, Greg Stein wrote: Euh... we switched over to a shared library to specifically fix this problem. Are you saying that that didn't work? I'm not buying it... :-) sooo, i guess the answer to my question on how to disable expat is you can't ? i haven't see the problem first

libexpat

2002-05-20 Thread Doug MacEachern
how does one disable linking httpd against libexpat in 2.0? and on win32? i thought the nightmare was over where the expat linked with httpd cause segfaults with perl expat extensions. looks like i was wrong.

Re: libexpat

2002-05-20 Thread Doug MacEachern
On Mon, 20 May 2002, William A. Rowe, Jr. wrote: Context? httpd links in expat, perl extension links against a different version of expat. both have the same symbol names, and they are not binary compatible. perl extension resolves symbols to the httpd version. kaboom. its been an

Re: cvs commit: httpd-test/perl-framework/Apache-Test README

2002-05-19 Thread Doug MacEachern
On 19 May 2002 [EMAIL PROTECTED] wrote: stas02/05/19 00:56:32 Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm perl-framework/Apache-Test README Log: make the APACHE_TEST_COLOR env setting work when running from script if running as batch,

Re: cvs commit: httpd-test/perl-framework/Apache-Test README

2002-05-19 Thread Doug MacEachern
On Mon, 20 May 2002, Stas Bekman wrote: Because the color setting doesn't have any effect if you build using the script. e.g. before my change this script won't work with colors: #!/bin/sh make clean APACHE_TEST_COLOR=1; export APACHE_TEST_COLOR /home/stas/perl/ithread/bin/perl

Re: inherit_documentroot breakage

2002-05-15 Thread Doug MacEachern
On Tue, 14 May 2002, Cliff Woolley wrote: Thanks. I had noticed that commit, but thought maybe there would be some way to fix it by just adjusting extra.conf.in rather than reverting. Oh well, whatever works. :) it broke other stuff too. i have the functionality i was after now with the

Re: inherit_documentroot breakage

2002-05-14 Thread Doug MacEachern
On Tue, 14 May 2002, Cliff Woolley wrote: Anybody know why this just started happening within the last few days? i just backed out the change from yesterday that caused it, should be ok now.

Re: Apache History Project - Call for comments

2002-05-14 Thread Doug MacEachern
On Wed, 15 May 2002, Thomas Eibner wrote: Full list of posters with more than 10 posts can be found at: http://stderr.net/history/topposters cool, now i am tied with ben hyde.

Re: Apache History Project - Call for comments

2002-05-14 Thread Doug MacEachern
On Tue, 14 May 2002, Doug MacEachern wrote: On Wed, 15 May 2002, Thomas Eibner wrote: Full list of posters with more than 10 posts can be found at: http://stderr.net/history/topposters cool, now i am tied with ben hyde. haha, now i am 1 ahead of ben hyde, i'm #32 woohoo!

Re: perl-framework: make test recompiles everything all the time

2002-04-16 Thread Doug MacEachern
On Tue, 16 Apr 2002, Stas Bekman wrote: one last question. Should the ssl certificates be recreated on t/TEST -clean (or 'make test')? yup. if you don't want them to be, there are several ways to keep t/conf/ssl/ca from being deleted/regenerated. careful though, since new ssl tests come

Re: perl-framework: make test recompiles everything all the time

2002-04-12 Thread Doug MacEachern
On Fri, 12 Apr 2002, Stas Bekman wrote: Any idea why 'make test' in perl-framework is recompiling everything on each invocation without sources getting changed? Including rebuilding ssl certs. because 'make test' always does a t/TEST -clean after itself.

Re: perl-framework: make test recompiles everything all the time

2002-04-12 Thread Doug MacEachern
On Sat, 13 Apr 2002, Stas Bekman wrote: but why 't/TEST -clean' removes the compiled modules? Shouldn't this be the job of 'make clean' and its variants? i don't really care. i never use 'make test' or even 'make' here. i have several checkouts of httpd-test/perl-framework that point to

Re: perl-framework: make test recompiles everything all the time

2002-04-12 Thread Doug MacEachern
yup, t/TEST -conf will 'make' the c-modules, you can also just do 'make cmodules' if you only want to compile the changed c-modules.

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestServer.pm

2002-04-07 Thread Doug MacEachern
it is a nice feature when it works, so i've re-enabled for linux only. for the other platforms in the current state, its better to wait 60 seconds if the server fails to start than to throw and error and die when it has successfully started.

Re: Bug report for Apache httpd-2.0 [2002/04/07]

2002-04-07 Thread Doug MacEachern
coupla dumb questions: - how do i get a login for the bugdb? - just fixed bug #7802, do i close it or mark as fixed and somebody else verifies and closes?

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2002-04-06 Thread Doug MacEachern
On Fri, 5 Apr 2002, Cliff Woolley wrote: Doug. DOOD. You're working too hard. GO PARTY! ;) well, i am drinking a beer at least. wasn't expecting this GA push today, so i'm scrambling to get a modperl release together. then i will party like never before!

RE: I WANT A GA release

2002-04-05 Thread Doug MacEachern
+1 on GA. 2 issues on HEAD i'd like to see resolved first: - proxy not sending content-length - httpd.conf not installed with vpath builds (issue does not exist with current .34 tag)

httpd.conf no longer installed

2002-04-04 Thread Doug MacEachern
with httpd-2.0-HEAD, installing into a directory where no conf/ already exists, no httpd.conf is installed, only: % ls -1 conf/ highperformance.conf highperformance-std.conf httpd.conf.in httpd-std.conf.in magic mime.types ssl.conf ssl-std.conf problem does not exist with the APACHE_2_0_34 tag.

Re: httpd.conf no longer installed

2002-04-04 Thread Doug MacEachern
On Thu, 4 Apr 2002, Pier Fumagalli wrote: Did you run ./buildconf? yup, always. i probably just need blow away my cvs tree and start from scratch. has cured similar trouble in the past. i'll report back if the problem is still there.

Re: httpd.conf no longer installed

2002-04-04 Thread Doug MacEachern
nope, still isn't there. % uname -a Linux mako.covalent.net 2.4.7-10 #1 Thu Sep 6 17:27:27 EDT 2001 i686 unknown % autoconf --version Autoconf version 2.13 % cat config.nice #! /bin/sh # # Created by configure CFLAGS=-Wall -g; export CFLAGS /home/dougm/apache/farm/src/httpd-2.0-cvs/configure

Re: httpd.conf no longer installed

2002-04-04 Thread Doug MacEachern
On Thu, 4 Apr 2002, Pier Fumagalli wrote: What do your last lines of configure.in look like? And when you run ./configure. what's the output of the last (let's say) 50 lines? mkdir: cannot create directory `docs/conf': No such file or directory creating docs/conf/httpd-std.conf

cvs commit: httpd-2.0/modules/ssl ssl_engine_kernel.c (fwd)

2002-04-04 Thread Doug MacEachern
dear RM, please consider bumping for .34, else users with the typical ssl proxy config: SSLProxyEngine On ProxyPass/ https://foo/ ProxyPassReverse / https://foo/ will get this ugly error message on every request: [error] mod_ssl: Certificate Verification: Error ... even

proxy not sending Content-Length

2002-04-04 Thread Doug MacEachern
mod_proxy does not send a Content-Length header, seems because of the flush bucket inserted by ap_proxy_http_process_response() if i break in ap_content_length_filter, when a request is handled by default_handler, brigade looks like so: (gdb) dump_brigade b dump of brigade 0x8235318 0:

RE: proxy not sending Content-Length

2002-04-04 Thread Doug MacEachern
On Thu, 4 Apr 2002, Ryan Bloom wrote: The proxy should flush, because otherwise the data won't stream to the client. doesn't the core flush once it has max-something bytes or eos? The problem that I see, is that the proxy shouldn't be removing the C-L from the response that the origin

Re: fix t/ssl/http.t

2002-04-03 Thread Doug MacEachern
On Wed, 3 Apr 2002, Cliff Woolley wrote: On Tue, 2 Apr 2002, Doug MacEachern wrote: apr_bucket_immortal_create(HTTP_ON_HTTPS_PORT, \ - sizeof(HTTP_ON_HTTPS_PORT) - 1, \ + sizeof(HTTP_ON_HTTPS_PORT), \ Mmmm... no. I

Re: fix t/ssl/http.t

2002-04-03 Thread Doug MacEachern
On Wed, 3 Apr 2002, Cliff Woolley wrote: Only one other thing I'm concerned about with it: It's only correct if we're in AP_MODE_GETLINE at the time of the error. Which we are in this case, but will it always be that way? i think so, assuming AP_MODE_GETLINE always happens first. on the

Re: cvs commit: httpd-test/perl-framework/t/ssl http.t

2002-04-02 Thread Doug MacEachern
On Tue, 2 Apr 2002, Cliff Woolley wrote: The old version for me was giving a res-code of 200, not 500, because it was sending the http request to port 8529, not 8530. Maybe it's related to the version of LWP I'm using? strange. i don't think it is lwp related. probably not worth spending

Re: cvs commit: httpd-test/perl-framework/t/ssl http.t

2002-04-02 Thread Doug MacEachern
On 2 Apr 2002 [EMAIL PROTECTED] wrote: jwoolley02/04/01 23:20:34 Modified:perl-framework/t/ssl http.t Log: Okay, well the test works now, but it still fails at the moment because mod_ssl really is broken. :) this patch does not change anything that i can see, both the old

fix t/ssl/http.t

2002-04-02 Thread Doug MacEachern
the test started failing at some point due to filter changes. i think i heard it is not longer possible for a filter to remove itself? in any case, mod_ssl already checks in the output filter already passes if its ssl pointer is NULL (normally due to error). the input filter should

RE: fix t/ssl/http.t

2002-04-02 Thread Doug MacEachern
On Tue, 2 Apr 2002, Ryan Bloom wrote: It is perfectly possible for a filter to remove itself. In fact, the byterange filter relies on that ability to work correctly. While I would be interested to know what happened to make that case fail, if the patch below works, then +1. i was thinking

RE: fix t/ssl/http.t

2002-04-02 Thread Doug MacEachern
On Tue, 2 Apr 2002, Ryan Bloom wrote: Nope, I fixed this. The problem was that we couldn't remove the first filter in any of the three lists, because the previous filter structure wouldn't be updated. The solution was to walk the filter list each time we tried to remove a filter. This

ssl proxy fixes for .34

2002-04-02 Thread Doug MacEachern
if the following tags in modules/ssl could be pushed: /ssl_engine_config.c/1.66/Tue Apr 2 21:49:09 2002// /ssl_engine_init.c/1.94/Tue Apr 2 21:46:22 2002// /ssl_util_ssl.c/1.20/Tue Apr 2 22:04:16 2002// minor fixes to get SSLProxyMachineCertificatePath working.

Re: fix t/ssl/http.t

2002-04-02 Thread Doug MacEachern
this is not quite fixed. currently does return 400 Bad Request, but reports: Your browser sent a request that this server could not understand. Request header field is missing colon separator. with the patch below it properly reports: Your browser sent a request that this server could not

cvs commit: httpd-2.0/modules/proxy mod_proxy.h proxy_http.cproxy_util.c (fwd)

2002-04-01 Thread Doug MacEachern
RM can you bump the .34 tag on these files? thanks. -- Forwarded message -- Date: 2 Apr 2002 04:30:49 - From: [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: cvs commit: httpd-2.0/modules/proxy mod_proxy.h proxy_http.c proxy_util.c dougm

Re: bio_bucket_in_read bug [was Re: Bump a few more tags. :-)]

2002-04-01 Thread Doug MacEachern
your grep pattern missed this one: ctx-inbio.block = block;

Re: Bump a few more tags. :-)

2002-04-01 Thread Doug MacEachern
On Mon, 1 Apr 2002, William A. Rowe, Jr. wrote: Sounds like that could be Doug's latest changes he asked to incorporate. Doug, was there an additional file to bump, beyond the three you cited? nope. sounds specific to perchild, cliff does the proxy test pass for you with prefork and/or

Re: cvs commit: httpd-2.0 CHANGES

2002-03-31 Thread Doug MacEachern
On Sun, 31 Mar 2002, Brian Pane wrote: Should that be in the 2.0.34 section, or the 2.0.35 one? wrowe has moved HEAD to the 2.0.34 tag, which includes the ssl proxy changes.

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-29 Thread Doug MacEachern
not sure if this is related to the bucket list change or mod_includes changes or what, but i just checked in a test adapted from modperl that dumps core. stacktrace below from t/TEST t/modules/include2.t #0 0x0815a897 in ?? () at eval.c:41 41 eval.c: No such file or directory.

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-29 Thread Doug MacEachern
another problem after fixing the httpd-test c-modules to compile: t/apache/passbrigade eats all cpu. have not looked into it.

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-29 Thread Doug MacEachern
On Fri, 29 Mar 2002, Doug MacEachern wrote: another problem after fixing the httpd-test c-modules to compile: t/apache/passbrigade eats all cpu. have not looked into it. nevermind. i didn't notice the modules had been updated and my cvs commit up-to-date check failed. this test is working

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-29 Thread Doug MacEachern
On Fri, 29 Mar 2002, Doug MacEachern wrote: not sure if this is related to the bucket list change or mod_includes changes or what, but i just checked in a test adapted from modperl that dumps core. stacktrace below from t/TEST t/modules/include2.t fyi: t/php/virtual produces the same

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-29 Thread Doug MacEachern
On Fri, 29 Mar 2002, Cliff Woolley wrote: On Fri, 29 Mar 2002, Doug MacEachern wrote: fyi: t/php/virtual produces the same stacktrace I'll look into this this afternoon. great. probably easier to work with t/modules/include2.t, stacktrace looks like they suffer the same problem

bucket free list breakage (was Re: cvs commit: httpd-2.0/server/mpm/workerworker.c)

2002-03-29 Thread Doug MacEachern
just looked a bit more, the problem is related to heap buckets and the free functions. something is broken for sure. i could probably bandaid, but cliff if you take a look, i'm assuming the right fix would be obvious to you. #1 0x4001cf76 in heap_destroy (data=0x824f758) at

Re: bucket free list breakage (was Re: cvs commit: httpd-2.0/server/mpm/workerworker.c)

2002-03-29 Thread Doug MacEachern
On Fri, 29 Mar 2002, Brian Pane wrote: Does the rest of *h look valid? (That could help us differentiate memory corruption from some code path that just forgot to set h-free_func.) (gdb) p *h $1 = {refcount = {refcount = 0}, base = 0x824f568 mod_include test(\026/\021, alloc_len = 16,

Re: bucket free list breakage (was Re: cvs commit:httpd-2.0/server/mpm/workerworker.c)

2002-03-29 Thread Doug MacEachern
On Fri, 29 Mar 2002, Cliff Woolley wrote: Okay, fixed. excellent, thanks. PS: I now pass all httpd-test tests except these: http.t fails for me too, has for a while. proxy.t passes for me, but this is new stuff. anything interesting in the error_log?

Re: bucket free list breakage (was Re: cvs commit:httpd-2.0/server/mpm/workerworker.c)

2002-03-29 Thread Doug MacEachern
On Fri, 29 Mar 2002, Cliff Woolley wrote: Yes. The SSLProxyEngine on directive is missing from the config file. I added it manually and it works. I expect something like this would do the trick: oh duh, i had made the change but didn't commit. glad to hear it works.

Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_init.c

2002-03-27 Thread Doug MacEachern
On Wed, 27 Mar 2002, Greg Stein wrote: Maybe this could return a status, rather than just calling ssl_die()? (and have the caller do the die...) Personally, I'd rather see an eventual case where you bubble up the death, and let Apache core do the exiting, rather than having the module

Re: [PATCH] SSL Session Caching stuff

2002-03-14 Thread Doug MacEachern
looks good to me madhu. haven't tested, but it compiles, so i've committed the patch and remaining issues can be worked out later. only have one question at the moment, what is this for? +void *data; +const char *userdata_key = ssl_scache_init; + +

RE: [PATCH] SSL Session Caching stuff

2002-03-14 Thread Doug MacEachern
On Thu, 14 Mar 2002, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: if (Pass-1) { ... } else if (Pass-2) { i don't know how to fix it, but we should't assume anything based pass-1, pass-2, etc. otherwise it isn't possible to add mod_ssl to a server that was started without it, consider:

Re: [PATCH] ssl_engine_vars.c

2002-03-13 Thread Doug MacEachern
On Wed, 13 Mar 2002, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: 'just did a cvs update and found that SSL_SESSION_id2sz in ssl_engine_vars.c has fewer parameters than required. whoops, my bad. thanks, applied.

Re: putting mod_scoreboard_send in core?

2002-03-13 Thread Doug MacEachern
a few notes on this.. the purpose of mod_scoreboard_send was to download the scoreboard image on a remote machine. the scoreboard image was then used on the client machine to generate fancy graphical images to make our boss feel like he knew what was going on. sorta like a graphical

Re: [BUG] Limit test 10 is failing

2002-03-12 Thread Doug MacEachern
On Tue, 12 Mar 2002, Sander Striker wrote: #User-Agent: libwww-perl/5.53 could be a bug in the client. try 5.64 you can also grab: http://httpd.apache.org/~dougm/httpd-test-bundle-0.02.tar.gz unpack and run: % echo | perl Makefile.PL make install (the 'echo |' trick makes all prompts use

[patch] better mod_ssl restart handling

2002-02-21 Thread Doug MacEachern
mod_ssl is hardwired only to initialize certain things on the first module init during startup. the only reason i can see is because the builtin SSLPassPhraseDialog can only read the passphrase from the tty before detach. but if SSLPassPhraseDialog is exec: or the server key is not

Re: APR_BRIGADE_NORMALIZE

2002-01-22 Thread Doug MacEachern
i thought it was added as a workaround during one of the mod_ssl filter rewrites. during the last one i tried removing APR_BRIGADE_NORMALIZE from core.c and all tests in httpd-test passed except for protocol/echo and protocol/nntp_like (which are the same code in the place where the problem

Re: perl-framework: Lower-grade ciphers and mod_ssl port broken

2002-01-20 Thread Doug MacEachern
On Fri, 18 Jan 2002, Justin Erenkrantz wrote: Failed Test Status Wstat Total Fail Failed List of Failed ssl/varlookup.t 723 4.17% 34, 36-37 34, 36, and 37 are related to the ciphers in use. It

Re: [PATCH] Re: PHP Apache2Filter

2002-01-20 Thread Doug MacEachern
On Sun, 20 Jan 2002, Justin Erenkrantz wrote: Also, be aware that the *readbytes may change to readbytes. I don't know who has commit access to PHP, but it'd be nice if someone over there applied the following for now. =) -- justin i've adjusted modperl and php (with the same fix as your

Re: What makes the server die with 255?

2002-01-17 Thread Doug MacEachern
On Wed, 16 Jan 2002, Sander Temme wrote: Hi all, Built and ran HEAD on Darwin 5.2, and ran the httpd-test perl-framework. This dies with the following protest: server has died with status 255 (please examine t/logs/error_log) Terminated The log says: [batmobile:perl-framework]

Re: [patch] new mod_ssl input filter

2002-01-16 Thread Doug MacEachern
On Wed, 16 Jan 2002, Justin Erenkrantz wrote: Perhaps you *could* read all of the brigade in the getline case in bio_bucket_io_read, but that's not a sticking point (as I see your point - ap_getline *should* be able to pick up on an incomplete line). i was just trying to avoid blocking

Re: cvs commit: httpd-test/perl-framework/t/apache etags.t

2002-01-10 Thread Doug MacEachern
On Thu, 10 Jan 2002, Rodent of Unusual Size wrote: Um, but it's going to work with 2.0. Please revert your patch because it's broken. The test for a 500 return allows the test to skip on versions of Apache that don't have the directive (like 1.3.22). Your change will cause the skip to be a

detach note?

2002-01-10 Thread Doug MacEachern
wondering if we could have a mechanism where MPMs set some sort of note after calling apr_proc_detach()? reason is, mod_ssl is hardwired only to initialize certain things on the first module init during startup. but the only reason i can see is because the builtin SSLPassPhraseDialog can only

RE: cvs commit: httpd-2.0/modules/ssl mod_ssl.h ssl_engine_pphrase.c ssl_util.c

2002-01-09 Thread Doug MacEachern
On Wed, 9 Jan 2002, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: mod_ssl build is broken because of the new argument introduced in ssl_util_ppopen().. [build breaks for ssl_engine_rand.c] compiles again and works now too.

Re: [PATCH - 2] cleaning up mod_ssl

2002-01-09 Thread Doug MacEachern
On Wed, 9 Jan 2002, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: Hi, Here comes a more complete patch..Any suggestions, comments are appreciated. looks great to me, applied to cvs. might be worth submitting those macros back to OpenSSL and put #ifndefs or similar around the current

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestServer.pm

2002-01-06 Thread Doug MacEachern
On Sun, 6 Jan 2002, Stas Bekman wrote: I've done with this: -eval 'END { +eval 'my $parent_pid = $$; + END { + return unless $$ == $parent_pid; # because of fork ok. i thought is_parent() could be useful elsewhere, but i guess we could worry about that

Digest::MD5 in TestSmoke?

2002-01-06 Thread Doug MacEachern
perl-framework does not work with 5.6.1 due to Digest::MD5 requirement. i don't see any reason why this: my $digest = Digest::MD5::md5_hex(join '', @$ra_tests); cannot just be this: my $digest = join '', @$ra_tests; ??

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestServer.pm

2002-01-06 Thread Doug MacEachern
On Mon, 7 Jan 2002, Stas Bekman wrote: I needed it TestRun, whereas the fork was happening in TestServer. So it was definitely easier to do it locally. are you saying the following patch would not work? Index: Apache-Test/lib/Apache/TestRun.pm

Re: Digest::MD5 in TestSmoke?

2002-01-06 Thread Doug MacEachern
On Mon, 7 Jan 2002, Stas Bekman wrote: Sorry, can we put it into the Bundle? that's fine, but we cannot 'use Digest::MD5' the way it was before. else 'perl Makefile.PL' doesn't work without it. Because there can be hundreds of tests in @$ra_tests; Remember that the first run by default

trouble with httpd-2.0 HEAD

2002-01-05 Thread Doug MacEachern
updating for the first time in 2 weeks, blowing up here: /bin/sh /usr/local/apache/build/prefork-debug-shared-all-exp/srclib/apr/libtool --silent --mode=compile gcc -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -Wall -g -DHAVE_CONFIG_H -DLINUX=2 -D_REENTRANT

Re: trouble with httpd-2.0 HEAD

2002-01-05 Thread Doug MacEachern
On Sat, 5 Jan 2002, Justin Erenkrantz wrote: @APR_INCLUDES@ is not being substituted properly. You reran buildconf and configure? yeah, the script i use always blows away the old build tree and re-runs buildconf and configure.

Re: trouble with httpd-2.0 HEAD

2002-01-05 Thread Doug MacEachern
On Sat, 5 Jan 2002, Justin Erenkrantz wrote: How is APR-util's configure script getting the --with-apr option (see config.nice)? -- justin % cat srclib/apr-util/config.nice #! /bin/sh # # Created by configure CFLAGS=-Wall -g; export CFLAGS

Re: trouble with httpd-2.0 HEAD

2002-01-05 Thread Doug MacEachern
On Sat, 5 Jan 2002, Justin Erenkrantz wrote: Huh. That's what I have and it works. What does config.status say for APR_INCLUDES: nada. there's no reference to APR_INCLUDES in there at all. are you using a --srcdir? that's my main suspect, though i haven't tried without it yet. It

Re: trouble with httpd-2.0 HEAD

2002-01-05 Thread Doug MacEachern
everything is ok now after blowing away the cvs tree and checking out from scratch. either something stale in the cvs tree, or a bug in my build script. sorry for the hassle.

Re: More basics on the perl-framework stuff..

2001-12-29 Thread Doug MacEachern
On Sun, 23 Dec 2001, Stas Bekman wrote: That means two different ways to add configuration. yup. because we're doing different things. and for the record: there are already more than 2 ways to add configuration. tho only one to run the CONFIGURE routine. Why cannot we make the .pm scanner

Re: [patch] don't complain about old core files

2001-12-29 Thread Doug MacEachern
On Mon, 24 Dec 2001, Stas Bekman wrote: this patch: - s/scan/scan_core/ for consistency with warn_core - don't complain aload when an old core from some old run is found (i'm tired of remembering to remove old core files) nice, +1

Re: cvs commit: httpd-test/perl-framework/t/apache getfile.t

2001-12-21 Thread Doug MacEachern
On Fri, 21 Dec 2001, Stas Bekman wrote: OK, here it is: I've finally called it skip_all() as it's a standalone function now. cool, +1. but would rather it still be called skip_unless()

Re: [patch] autogeneration of TEST/SMOKE/REPORT

2001-12-21 Thread Doug MacEachern
On Fri, 21 Dec 2001, Stas Bekman wrote: This patch removes the need for t/TEST.PL, t/SMOKE.PL, build/bugreport.pl and implements in each set of the classes used by these scripts a generate_script() method, which generates these scripts. nice. Issues: - should it generate t/REPORT or just

Re: More basics on the perl-framework stuff..

2001-12-21 Thread Doug MacEachern
On Fri, 21 Dec 2001, Stas Bekman wrote: I was thinking some more about this issue and came to a conclusion that there is nothing we should add, since we have already a working solution: close, but the current .pm scanner a bit too specific to mod_perl in terms of location (where the .pm's

  1   2   >