Re: mod_mbox spinning processes on ajax

2005-10-20 Thread Justin Erenkrantz
--On October 21, 2005 1:09:28 AM +0200 Maxime Petazzoni [EMAIL PROTECTED] wrote: I've just commited a small changeset in order to compute the string length only once in the function. But yes, we could rely on the computed length earlier in the body processing. I wonder if fixing the loop

Re: svn commit: r321449 - in /httpd/mod_mbox/trunk/module-2.0: mod_mbox_file.c mod_mbox_index.c

2005-10-15 Thread Justin Erenkrantz
On Sat, Oct 15, 2005 at 12:08:15PM -0700, Paul Querna wrote: Except when we get a HEAD request, r-path_info is filled with bogus data, which causes mod_mbox to crash way deep inside itself. Why isn't r-path_info filled out correctly? If the request's path_info itself is bogus, that should be

Re: Core dump on ajax: crash in mod_mbox

2005-10-12 Thread Justin Erenkrantz
On Wed, Oct 12, 2005 at 08:20:40AM -0700, Sander Temme wrote: The httpd-2.0.55 RC currently running on ajax had a segfault about an hour ago, here's the backtrace. Looks like a crash in mod_mobx, so I don't think it affects the httpd release. Paul, Sam, and I analyzed the cores and

Re: Core dump on ajax: crash in mod_mbox

2005-10-12 Thread Justin Erenkrantz
On Wed, Oct 12, 2005 at 01:31:42PM -0700, Sander Temme wrote: There is now: [Wed Oct 12 22:04:43 2005] [notice] child pid 5885 exit signal =20 Segmentation fault (11), possible coredump in /raid1/httpd-cores Backtrace: ... Note, this was /raid1/httpd-cores/core.5885 . (gdb) print

Re: mod_mbox

2005-10-11 Thread Justin Erenkrantz
--On October 11, 2005 1:24:22 PM -0400 Joshua Slive [EMAIL PROTECTED] wrote: As has been pointed out, this is a trade off. You can get real protection at the cost of losing the ability to find real email addresses. Or you can get protection that will work against 95% or more of current

Re: mod_mbox

2005-10-10 Thread Justin Erenkrantz
On Mon, Oct 10, 2005 at 06:46:57PM -0400, Joshua Slive wrote: 1. Do we really want people subscribing to mailing lists using atom over http? This would consume way more resources than a standard mailing list subscription (due to the polling nature of atom). I don't have any evidence, but

Re: apache/sitemaps?

2005-10-06 Thread Justin Erenkrantz
On Mon, Oct 03, 2005 at 10:21:13PM -0700, Paul Querna wrote: Write the code. Send Patches. Then we have something to work with. If mod_sitemap turns into anything, it might be possible to find it a place inside the ASF. Agreed. If and when a C module is written and submitted for discussion,

Re: 3700 core files for mod_mbox

2005-10-06 Thread Justin Erenkrantz
On Wed, Oct 05, 2005 at 03:47:51PM -0400, Joshua Slive wrote: This is my period reminder email that mod_mbox is regularly crashing on ajax. Nothing more to add from my previous notes. I no longer have the time to look into this. Sorry. I tried to follow up with this before; but the crashes

Re: 3700 core files for mod_mbox

2005-10-06 Thread Justin Erenkrantz
On Thu, Oct 06, 2005 at 03:11:01PM +0200, Maxime Petazzoni wrote: /me raises his hand. I still need to get in touch with the administration scripts used for m-a.a.org, but I'm willing to help the infra team, and my SoC gave me enough mod_mbox knowledge to handle it. The scripts are what's in

Re: 3700 core files for mod_mbox

2005-10-06 Thread Justin Erenkrantz
--On October 6, 2005 12:23:22 PM -0700 Roy T. Fielding [EMAIL PROTECTED] wrote: What errors? Do you mean 404s on httpd (what I would expect) or script errors on mbox processing (what I wouldn't expect unless the mod_mbox scripts are horribly lame). It's telling me that the list archives no

Re: [PATCH] Use rsync to install manual

2005-09-30 Thread Justin Erenkrantz
On Fri, Sep 30, 2005 at 10:04:12AM +0100, Colm MacCarthaigh wrote: Please don't use the -a option for rsync. use -rlptDv instead; we shouldn't be trouncing the ownership of the destination files, cp doesn't. I'd also add the --numeric-ids option, which will also prevent rsync from doing the

Re: Distributing httpd-2.2, redux

2005-09-30 Thread Justin Erenkrantz
--On September 30, 2005 1:43:50 PM -0500 William A. Rowe, Jr. [EMAIL PROTECTED] wrote: * Ship httpd-2.2.x.tar.gz (solo), and httpd-2.2.x-bundle.tar.gz which includes all the sub-packages the user should likely need (including pcre/apr/-util/expat/-iconv/)? Perhaps even

[PATCH] Fix c2x/ap_escape_logitem ugliness

2005-09-27 Thread Justin Erenkrantz
[ moving this from [EMAIL PROTECTED] to [EMAIL PROTECTED] For those not on the Subversion lists, Subversion has an issue with escaping the contents of the httpd log. ] --On September 27, 2005 7:17:59 PM +0200 André Malo [EMAIL PROTECTED] wrote: Only \xx is used. Well, c2x is utilized, but

Re: 2.1.8-beta available for Testing and Voting

2005-09-26 Thread Justin Erenkrantz
--On September 25, 2005 5:15:43 PM -0700 Paul Querna [EMAIL PROTECTED] wrote: Please report on testing experiences and (if applicable) vote on releasing httpd 2.1.8-BETA. We really want both positive and all negative experiences with this release. The more bugs we find now, the better the

Re: which apr(-util) versions for 2.2.x?

2005-09-26 Thread Justin Erenkrantz
--On September 24, 2005 9:58:26 AM -0700 Paul Querna [EMAIL PROTECTED] wrote: Actually, we are getting to the point were I would rather just have a hard depends on APR = 1.2.0 How about emitting a warning at configure-time if less than our latest recommended version (say 1.2.0)? I would

Re: provider enhancement

2005-09-07 Thread Justin Erenkrantz
--On September 7, 2005 10:01:19 AM -0400 Jim Jagielski [EMAIL PROTECTED] wrote: While looking over implementing the lbmethod via the provider, one deficiency hit me: there no way to get a list of registered providers. I'm thinking about adding a ap_list_providers() which would return a table

Re: svn commit: r264866 - in /httpd/httpd/trunk: CHANGES modules/generators/config5.m4

2005-08-30 Thread Justin Erenkrantz
--On August 30, 2005 11:33:39 PM +0200 [EMAIL PROTECTED] wrote: Just curious. What about running the worker MPM with mod_cgi on Solaris 10? See also the discussion on Re: svn commit: r264737 - /httpd/httpd/trunk/docs/manual/stopping.xml between Colm and Joe. Saw it; but I don't have time to

Re: Status of 2.1.7

2005-08-30 Thread Justin Erenkrantz
--On August 29, 2005 9:58:12 PM -0700 Paul Querna [EMAIL PROTECTED] wrote: I counted two votes about 2.1.7-beta: +1: Brad, Joe Passes httpd-test on Mac OS X 10.4.2. +1 for beta. -- justin

Re: Status of 2.1.7g

2005-08-30 Thread Justin Erenkrantz
--On August 30, 2005 8:54:57 AM -0400 Jeff Trawick [EMAIL PROTECTED] wrote: http://people.apache.org/~colm/2.1.7-non-showstoppers.patch +1 on all that for the 2.2.x branch in any case. +1 here as well +1 too on that set of changes. I think we hit RTC once the branch opens towards GA -

Re: Status of 2.1.7

2005-08-30 Thread Justin Erenkrantz
--On August 30, 2005 10:46:01 PM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: Since Apachecon EU, it's also been running the worker MPM (on IA64). and performance is up by around 9% in our benchmarks. In trunk's STATUS there's a vote which seems have long since passed (positively) to make

Re: Status of 2.1.7

2005-08-30 Thread Justin Erenkrantz
On Tue, Aug 30, 2005 at 09:10:25PM -0500, William A. Rowe, Jr. wrote: If folks aren't voting, will they be supporting the problem reports that come in? I count the following for 2.1.7 beta (Paul missed a bunch of votes): +1: Joe, Brad, Jeff, Jim, Justin. -1: OtherBill ('no one voted') How

Re: [PATCH] mod_mbox module documentation

2005-08-30 Thread Justin Erenkrantz
On Wed, Aug 31, 2005 at 04:36:59AM +0200, Maxime Petazzoni wrote: Ok, let's start again. mod_mbox is not in the HTTPd core, so its documentation does not belong to the httpd/httpd/docs/ part of the repository. Attached, a small patch adding a stub website for mod_mbox to the httpd/site/

Re: mod_log_config: log thread id in hex

2005-08-30 Thread Justin Erenkrantz
On Tue, Aug 30, 2005 at 11:28:37AM +0100, Joe Orton wrote: On Sat, Aug 27, 2005 at 11:12:24AM -0400, Jeff Trawick wrote: %{tid}P gets you thread id in decimal now. %{hextid}P would show it in hex using relatively new apr_sprintf() format, added in 1.2.0. Seems fine except that it

Re: mod_mbox bug squashing

2005-08-29 Thread Justin Erenkrantz
--On August 29, 2005 11:52:18 AM +0200 Maxime Petazzoni [EMAIL PROTECTED] wrote: First of all, thanks for your reply, I was looking forward to having mod_mbox's original author comments ! Ha! =) Ok, if it crashes it means we won't have any debugging information. If you have a couple of

Re: mod_mbox bug squashing

2005-08-28 Thread Justin Erenkrantz
--On August 28, 2005 7:26:16 PM +0200 Maxime Petazzoni [EMAIL PROTECTED] wrote: - mod_mbox offers an AJAX browser (YY.mbox/browser) for dynamic archive browsing to Javascript capable browsers. Still, the AJAX browser is known to be working only in Gecko-based browser for the moment.

Status of PR 29528? (Memory leaks in mod_cgid)

2005-08-26 Thread Justin Erenkrantz
I just had to upgrade my personal server to Solaris 10. With 2.0.54, I'm now getting the mod_cgid process (Worker MPM) taking up GBs of memory. Eek. The closest PR I can find is 29528. http://issues.apache.org/bugzilla/show_bug.cgi?id=29528#c10 In it, Joe said he had some patches to fix

Re: Status of PR 29528? (Memory leaks in mod_cgid)

2005-08-26 Thread Justin Erenkrantz
--On August 26, 2005 1:49:01 PM -0400 Jeff Trawick [EMAIL PROTECTED] wrote: Right. If you must use mod_cgid on Solaris 10, go back to the next to last Solaris Express driver prior to GA ;) Recently I applied the latest Solaris 10 updates and retested, without success. Yup, my box has all

Re: Status of PR 29528? (Memory leaks in mod_cgid)

2005-08-26 Thread Justin Erenkrantz
--On August 26, 2005 1:58:05 PM -0400 Jeff Trawick [EMAIL PROTECTED] wrote: I may use this as an excuse to play with dtrace some as well. That's what I thought ;) The problem I found is that observing more than one side of the socket makes it work. But good luck to you!!! Works for me. I

Re: Status of PR 29528? (Memory leaks in mod_cgid)

2005-08-26 Thread Justin Erenkrantz
--On August 26, 2005 3:00:13 PM -0700 Justin Erenkrantz [EMAIL PROTECTED] wrote: I'm going to write this up and throw it at some of the OpenSolaris devs and see if they have any ideas. -- justin Score one for the Solaris folks being around at 4pm on a Friday. I've summarized

Re: svn commit: r239711 - /httpd/httpd/trunk/server/mpm/prefork/prefork.c

2005-08-24 Thread Justin Erenkrantz
--On August 24, 2005 4:58:14 PM + [EMAIL PROTECTED] wrote: Author: colm Date: Wed Aug 24 09:58:11 2005 New Revision: 239711 URL: http://svn.apache.org/viewcvs?rev=239711view=rev Log: Implement de-listening for graceful restarts with the prefork MPM. With this change; 1.) httpd -k

serf was Re: mod_cache wishlist

2005-08-24 Thread Justin Erenkrantz
--On August 24, 2005 4:21:38 PM +0100 Nick Kew [EMAIL PROTECTED] wrote: So, is it time we introduced a general-purpose apr_http_client? I'd be prepared to offer my code as a startingpoint, but I'd rather not take the driving seat for further development and documentation. We already went down

Re: mod_mbox seg faulting on ajax

2005-08-23 Thread Justin Erenkrantz
--On August 17, 2005 12:09:39 PM -0700 Justin Erenkrantz [EMAIL PROTECTED] wrote: Sure. I'll hopefully get around to this in the next day or so. -- justin I've now updated ajax to trunk. -- justin

Re: mod_mbox cores

2005-08-23 Thread Justin Erenkrantz
--On August 23, 2005 10:50:45 AM -0400 Joshua Slive [EMAIL PROTECTED] wrote: I've had to turn off core dumps from httpd on ajax, because they were quickly filling up our /tmp directory. Below is another backtrace that appears a little different from the first. (I don't believe the module on

Re: svn commit: r239436 - /httpd/httpd/trunk/support/htcacheclean.c

2005-08-23 Thread Justin Erenkrantz
--On August 23, 2005 5:03:03 PM + [EMAIL PROTECTED] wrote: Add APR_FOPEN_BINARY to the options passed to apr for opening the cache header files. Why? -- justin

Re: svn commit: r239436 - /httpd/httpd/trunk/support/htcacheclean.c

2005-08-23 Thread Justin Erenkrantz
--On August 23, 2005 8:18:44 PM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: Because mod_disk_cache uses; APR_CREATE | APR_WRITE | APR_BINARY | APR_EXCL when creating them, see inside store_headers at mod_disk_cache.c:892 It would have been helpful if you had noted that in the

Re: extra characters in between response headers and response body of apache 1.3 but not in apache2.0

2005-08-22 Thread Justin Erenkrantz
On Sun, Aug 21, 2005 at 01:54:01PM -0500, William A. Rowe, Jr. wrote: At 09:30 AM 8/19/2005, Jeff Trawick wrote: On 8/19/05, Kaushal Jha - ZEDO [EMAIL PROTECTED] wrote: hey guys, I observed that only apache 1.3 (1.3.33) sends out the extra characters as shown below

Re: [PATCH] mod_disk_cache: speed up read_table

2005-08-18 Thread Justin Erenkrantz
--On August 18, 2005 3:59:05 PM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: Thinking about it, everything is going into memory anyway, so why not just stat() the file and read it all in in one go? We know it's never going to be that big anyway. This completely minimises the number of

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-18 Thread Justin Erenkrantz
--On August 18, 2005 9:24:57 AM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: On Wed, Aug 17, 2005 at 03:17:41PM -0700, Justin Erenkrantz wrote: Content definitely should not be served from the cache after it has expired imo. However I think an approach like; if((now + interval

Re: mod_cache recall_body

2005-08-18 Thread Justin Erenkrantz
--On August 18, 2005 9:55:57 AM -0400 Brian Akins [EMAIL PROTECTED] wrote: Why do we pass request_rec to recall_headers, but not to recall_body. We also always pass r-pool. How horrible would it be if the prototype was changed to: apr_status_t (*recall_body) (cache_handle_t *h, request_rec

Re: [PATCH] mod_disk_cache: speed up read_table

2005-08-18 Thread Justin Erenkrantz
--On August 18, 2005 1:34:56 PM -0400 Brian Akins [EMAIL PROTECTED] wrote: The optimizations that Colm is talking about should be helpful everywhere. Also, that's why we test to make sure it does kill us. Also, I don't think we know it will kill us. None of the code in mod_disk_cache used

Re: mod_mbox seg faulting on ajax

2005-08-17 Thread Justin Erenkrantz
--On August 17, 2005 1:10:22 PM -0400 Joshua Slive [EMAIL PROTECTED] wrote: Justin... Would it be possible for you to try this out on ajax. I could try to do it myself, but I would need to replicate your setup. I don't think the core dumps are creating any real problem, but I hate to see them

Re: [PATCH] mod_cache. Allow override of some vary headers

2005-08-17 Thread Justin Erenkrantz
--On August 17, 2005 3:01:03 PM -0400 Akins, Brian [EMAIL PROTECTED] wrote: This patch allows one to override the values of some headers so that they vary to the same value. Config Example: # all lines that have gzip set one variable SetEnvIf Accept-Encoding gzip gzip=1 # browsers that have

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-17 Thread Justin Erenkrantz
--On August 17, 2005 9:52:32 PM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: Content definitely should not be served from the cache after it has expired imo. However I think an approach like; if((now + interval) expired) { if(!stat(tmpfile)) {

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-17 Thread Justin Erenkrantz
--On August 17, 2005 9:29:05 PM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: Why bother renaming the file for such an implementation? If a half-cached file can be served from, and this handled properly, the rename would no longer make any sense :) For a disk cache it would be tricky to

Re: RFC: can I make mod_cache per-dir?

2005-08-16 Thread Justin Erenkrantz
On Mon, Aug 15, 2005 at 01:29:13PM +0100, Colm MacCarthaigh wrote: My main reason is that I can't enable or disable caching on a per-directory or per-file basis. The quick handler runs well before any knowledge is available about the backend (dir/file). The only thing you know is the URI

Re: RFC: can I make mod_cache per-dir?

2005-08-16 Thread Justin Erenkrantz
On Mon, Aug 15, 2005 at 09:55:34AM +0100, Colm MacCarthaigh wrote: mod_cache configurability sucks big-time. CacheEnable adds yet another location mapping scheme for administrators to deal with, but this scheme lacks basic flexibility; It can't reliably disable caching for a directory.

Re: [PATCH] Make CacheEnable useful for forward proxies

2005-08-16 Thread Justin Erenkrantz
On Tue, Aug 16, 2005 at 01:32:03PM +0100, Colm MacCarthaigh wrote: More mod_cache fix-ups; CacheEnable / isn't very useful for forward proxy servers. This patch makes; CacheEnable / CacheEnable ftp:// CacheEnable http://somesite/

Re: RFC: can I make mod_cache per-dir?

2005-08-16 Thread Justin Erenkrantz
On Wed, Aug 17, 2005 at 02:20:59AM +0100, Colm MacCarthaigh wrote: On Tue, Aug 16, 2005 at 06:02:04PM -0700, Justin Erenkrantz wrote: The quick handler runs well before any knowledge is available about the backend (dir/file). The only thing you know is the URI path: unsurprisingly

Re: Apache code-style vim tips

2005-08-16 Thread Justin Erenkrantz
On Wed, Aug 17, 2005 at 05:06:08AM +0100, Colm MacCarthaigh wrote: Just wondering what vim-users here may be using for help with coding in the Apache style. Currently I have; set tabstop=4 set shiftwidth=4 set expandtab Which are all reasonably obvious, but thought

Re: mod_dnsbl_lookup 0.90

2005-08-14 Thread Justin Erenkrantz
On Fri, Jul 29, 2005 at 10:11:46PM +0100, Colm MacCarthaigh wrote: Cool. I'd split dnsbl_zones into ipv4_dnsbl_zones and ipv6_dnsbl_zones and have the DnsblZones directive work like; DnsblIPv4Zones DnsblIPv6Zones FWIW, I think it'd be fine to have DnsblZones implicitly be

Re: svn commit: r232218 - /httpd/httpd/trunk/support/htcacheclean.c

2005-08-12 Thread Justin Erenkrantz
On Fri, Aug 12, 2005 at 06:38:04AM -, [EMAIL PROTECTED] wrote: Author: jorton Date: Thu Aug 11 23:38:01 2005 New Revision: 232218 URL: http://svn.apache.org/viewcvs?rev=232218view=rev Log: * support/htcacheclean.c (directory_empty): Remove unused function. *smacks head* Thanks! I

Re: [PATCH] fix incorrect 304's responses when cache is unwritable

2005-08-12 Thread Justin Erenkrantz
On Fri, Aug 12, 2005 at 05:38:40AM +0200, Plm, Rdiger, VIS wrote: In the case that you are caching a response from a backend app server or a cgi script I can imagine situations where one variant is 404 and another one is not. Dw also pointed that out. From my personal point of view we should

Re: [PATCH] fix incorrect 304's responses when cache is unwritable

2005-08-12 Thread Justin Erenkrantz
--On August 8, 2005 9:46:52 PM +0200 [EMAIL PROTECTED] wrote: log_correction.diff: ... dir_removal_patch.diff: Committed in r232335 and r232334, respectively. Thanks! -- justin

Re: svn commit: r231355 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h mod_proxy_http.c

2005-08-11 Thread Justin Erenkrantz
--On August 10, 2005 11:36:43 PM + [EMAIL PROTECTED] wrote: Author: niq Date: Wed Aug 10 16:36:39 2005 New Revision: 231355 URL: http://svn.apache.org/viewcvs?rev=231355view=rev Log: Fix ProxyPassReverse family to work correctly in Location This commit broke the build.

Re: [PATCH] fix incorrect 304's responses when cache is unwritable

2005-08-11 Thread Justin Erenkrantz
--On August 11, 2005 10:21:37 AM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: On Wed, Aug 10, 2005 at 03:38:17PM -0700, Justin Erenkrantz wrote: --On August 8, 2005 1:25:46 PM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: O.k., I've merged our two patches, but I've changed a few

Re: svn commit: r231181 - in /httpd/mod_mbox/trunk/scripts: catchup-archive create-index create-site-index update-index

2005-08-10 Thread Justin Erenkrantz
--On August 10, 2005 7:26:44 AM -0700 Paul Querna [EMAIL PROTECTED] wrote: Since most of these scripts (create-site-index in particular) are dedicated to mail-archives.a.org, I don't believe they belong to the mod_mbox repository (more in something like the infra repos for example).

Re: [PATCH] fix incorrect 304's responses when cache is unwritable

2005-08-10 Thread Justin Erenkrantz
--On August 8, 2005 1:25:46 PM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: O.k., I've merged our two patches, but I've changed a few things, tell me if there's anothing you think is wrong; Would you mind writing up a log message for this patch? I've lost track of what it's supposed to

Re: [PATCH] add remove empty directories option to htcacheclean

2005-08-10 Thread Justin Erenkrantz
--On August 8, 2005 1:58:53 AM +0100 Colm MacCarthaigh [EMAIL PROTECTED] wrote: And since nothing says it like code, here's a patch to htcacheclean which adds a -t option to clean out empty directories. Thanks! Committed a variant in r231351. FWIW, I agree with Andreas and Rüdiger. =) --

Re: CTR policy for experimental modules in A2.0?

2005-08-08 Thread Justin Erenkrantz
--On August 8, 2005 1:46:30 PM -0700 Paul Querna [EMAIL PROTECTED] wrote: -1 (vote, not veto). -1 as well. It should be reviewed, regardless of being on applicable to 2.0. Put it in the status file, just like everything else. I feel that being in 'experimental' is not a good excuse for

Re: svn commit: r219940 - in /httpd/httpd/trunk: docs/manual/mod/mod_ssl.xml modules/ssl/ssl_expr.h modules/ssl/ssl_expr_eval.c modules/ssl/ssl_expr_parse.y modules/ssl/ssl_expr_scan.l

2005-07-22 Thread Justin Erenkrantz
On Fri, Jul 22, 2005 at 12:02:29PM +0100, Joe Orton wrote: and since I can't update to fix (2) myself, here's another... Try again. All should be operational again. -- justin

Re: svn commit: r219936 - in /httpd/httpd/trunk/modules/aaa: mod_authz_dbm.c mod_authz_groupfile.c mod_authz_user.c

2005-07-22 Thread Justin Erenkrantz
--On July 21, 2005 6:30:36 PM +0200 Rich Bowen [EMAIL PROTECTED] wrote: Sorry. This is actually my very first code patch in all the years I've been working with Apache. Picking a nit. Will fix. No worries - by all means, feel free to commit! Just expect that we'll treat your commits with

Re: svn commit: r219936 - in /httpd/httpd/trunk/modules/aaa: mod_authz_dbm.c mod_authz_groupfile.c mod_authz_user.c

2005-07-21 Thread Justin Erenkrantz
On Wed, Jul 20, 2005 at 04:23:38PM -, [EMAIL PROTECTED] wrote: -if (!strcmp(w, file-group)) { +if (!cmpstri(w, file-group)) { Um, what's this? Shouldn't that be strcasecmp? -- justin

Re: [vote] Revoke R-T-C [was: svn commit: r219520]

2005-07-19 Thread Justin Erenkrantz
--On July 18, 2005 1:19:54 PM -0500 William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Some of us, trawick, orton and myself come to mind, are still up for supporting our current users. As it is, backports aren't reviewed, or committed once they are (I even split STATUS just to call out

Re: [vote] MODULE_MAGIC_COOKIE

2005-07-08 Thread Justin Erenkrantz
On Thu, Jul 07, 2005 at 10:51:09PM -0500, William A. Rowe, Jr. wrote: [ ] Revert the cookie to AP20 for httpd-2.1 and httpd-2.2 [ ] Leave the cookie at AP21 and bump again to AP22 w/httpd-2.2 [X] Get it over with already and bump now to AP22 for httpd-2.1

Re: [VOTE] mod_ftp for HTTP Server Project

2005-07-08 Thread Justin Erenkrantz
On Thu, Jul 07, 2005 at 02:26:13PM -0400, Jim Jagielski wrote: I therefore Call A Vote on whether we should support mod_ftp for inclusion into the Incubator and if we should accept mod_ftp upon graduation from the Incubator. +1. -- justin

Re: svn commit: r208787 - in /httpd/httpd/trunk/modules: http/http_filters.c http/http_protocol.c proxy/mod_proxy.c

2005-07-07 Thread Justin Erenkrantz
--On July 6, 2005 4:30:49 PM -0700 Paul Querna [EMAIL PROTECTED] wrote: Then we should remove them from trunk today. Why leave a 'flat-out wrong' API available? If no one has removed them from trunk by the hackathon next weekend, I will remove them then. -- justin

Re: svn commit: r208787 - in /httpd/httpd/trunk/modules: http/http_filters.c http/http_protocol.c proxy/mod_proxy.c

2005-07-06 Thread Justin Erenkrantz
--On July 4, 2005 11:08:18 PM -0500 William A. Rowe, Jr. [EMAIL PROTECTED] wrote: It still is not 'correct' until REQUEST_CHUNKED_PASS is reimplemented and passes some chunk headers, since we aren't echoing the entire request. But it gets me further on testing 1.3 - 2.0 - 2.1 - 2.0 - 1.3

Re: mod_smtpd project planning

2005-06-30 Thread Justin Erenkrantz
--On June 30, 2005 12:33:24 AM -0500 Jem Berkes [EMAIL PROTECTED] wrote: Hi all, I'm another student working on mod_smtpd If they haven't already, your mentors should be getting in touch with you soon. (It's their responsibility to inform you of the details.) In short, you need to fill

Re: mod_smtpd project planning

2005-06-29 Thread Justin Erenkrantz
On Wed, Jun 29, 2005 at 02:39:43PM -0700, Roy Fielding wrote: The dev list needs some new blood (and new ideas) and these folks aren't going to learn anything about real Apache development if they are stuck out in the suburbs. ++1. -- justin

Re: REQUEST_CHUNKED_PASS Q for 2.x TraceEnable [on|off|extended]

2005-06-24 Thread Justin Erenkrantz
On Thu, Jun 23, 2005 at 08:59:12AM -0500, William A. Rowe, Jr. wrote: Does anyone see a reason not to resurrect REQUEST_CHUNKED_PASS? I have no idea what you are talking about (your email is vague on context); but we should certainly not reintroduce the kludges associated with

Re: Proposal: Drop .Z dist file for 2.1/2.2

2005-06-24 Thread Justin Erenkrantz
--On Friday, June 24, 2005 11:09 AM -0700 Paul Querna [EMAIL PROTECTED] wrote: So, .Z is more than twice as big as bz2. I don't see any reason to keep including it, since every modern system has gzip, or can get it. +1. -- justin

Re: Removing AddOutputFilterByType

2005-06-19 Thread Justin Erenkrantz
--On June 19, 2005 5:33:14 PM +0100 Nick Kew [EMAIL PROTECTED] wrote: AddOutputFilterByType has always been problematic. I see there's another bug report this month arising from it: http://issues.apache.org/bugzilla/show_bug.cgi?id=33499 Since the purpose of this directive is now available

Re: [PATCH] mod_disk_cache: Handling of Varied Content

2005-06-12 Thread Justin Erenkrantz
On Sun, Jun 12, 2005 at 10:06:30AM -0700, Paul Querna wrote: I believe so. Yes, it clutters the code, but my objective is to have a switch where I can easily add logging to the common case code, and leave it in there, instead of deleting it before I commit. I think in the long run, we

Re: svn commit: r180333 - /httpd/httpd/branches/ssl-fips-dev

2005-06-07 Thread Justin Erenkrantz
--On Monday, June 6, 2005 8:24 PM +0200 Sander Striker [EMAIL PROTECTED] wrote: Personally I prefer entire tree branches. Agreed. This setup is going to make it difficult to test. -- justin

Re: svn commit: r188837 - /httpd/httpd/branches/fips-dev/srclib/apr

2005-06-07 Thread Justin Erenkrantz
--On Tuesday, June 7, 2005 6:16 PM + [EMAIL PROTECTED] wrote: Author: wrowe Date: Tue Jun 7 11:16:12 2005 New Revision: 188837 URL: http://svn.apache.org/viewcvs?rev=188837view=rev Log: Sandbox of apr/trunk/ for fips integration. Here may lurk fips issues (MD5 etc) Added:

Re: problems w/ geronimo wiki (cache???)

2005-06-07 Thread Justin Erenkrantz
--On Monday, June 6, 2005 4:01 PM +0200 Sander Striker [EMAIL PROTECTED] wrote: So this is the same problem reported here: http://mail-archives.apache.org/mod_mbox/httpd-dev/200505.mbox/%3c428F94 [EMAIL PROTECTED] which Sander said he was working on. Any progress? The cache is kind of

Re: problems w/ geronimo wiki (cache???)

2005-06-07 Thread Justin Erenkrantz
--On Tuesday, June 7, 2005 1:50 PM -0700 Justin Erenkrantz [EMAIL PROTECTED] wrote: to be a better way. For now, I'll commit a fix that matches what we did with mod_proxy; but this pattern keeps emerging. -- justin I'm not going to commit it yet. However, I'm building a new httpd on ajax

Re: svn commit: r188846 - in /httpd/httpd/trunk: include/mpm_common.h server/mpm_common.c

2005-06-07 Thread Justin Erenkrantz
--On Tuesday, June 7, 2005 7:13 PM + [EMAIL PROTECTED] wrote: +APR_HOOK_STRUCT( +#if AP_ENABLE_EXCEPTION_HOOK +APR_HOOK_LINK(fatal_exception) +#endif +APR_HOOK_LINK(monitor) +) + gcc (at least the one on RHEL3) forbids the use of preprocessor conditionals inside of a macro. So,

Re: problems w/ geronimo wiki (cache???)

2005-06-07 Thread Justin Erenkrantz
--On Wednesday, June 8, 2005 12:09 AM +0200 Sander Striker [EMAIL PROTECTED] wrote: Yes you are right I forgot this. So I think this would be better: FWIW, I *think* the patch should return result rather than the value of ap_pass_brigade. (Although I have a feeling that might not be

Re: problems w/ geronimo wiki (cache???)

2005-06-07 Thread Justin Erenkrantz
--On Tuesday, June 7, 2005 7:14 PM -0400 Joshua Slive [EMAIL PROTECTED] wrote: Go for it. What are our production servers for if not testing httpd patches ;-) As a data point (and one I think you alluded to earlier), the LA on the box was about 30 before I turned on the cache. It's now

Re: svn commit: r188846 - in /httpd/httpd/trunk: include/mpm_common.h server/mpm_common.c

2005-06-07 Thread Justin Erenkrantz
--On Wednesday, June 8, 2005 12:49 AM +0100 Nick Kew [EMAIL PROTECTED] wrote: OK, I've updated it thusly. But what version of gcc is that? I'm using gcc 3.3.4, and that was happy with it. % gcc -v Reading specs from /usr/lib/gcc-lib/ia64-redhat-linux/3.2.3/specs Configured with:

Re: problems w/ geronimo wiki (cache???)

2005-06-06 Thread Justin Erenkrantz
On Mon, Jun 06, 2005 at 03:40:41PM +0200, Sander Striker wrote: Justin, how's your stack of round tuits? Not plentiful at the moment. =( Can we keep the caching running on port 81 on ajax? That'll make it easier to debug if I do get some time. We'd really need to see what the

Re: [VOTE] 2.2.0 Alpha on Friday

2005-05-14 Thread Justin Erenkrantz
--On Friday, May 13, 2005 9:07 PM +0200 André Malo [EMAIL PROTECTED] wrote: Instead of calling it branches/2.1.x, on IRC wrowe suggested going straight to branches/2.2.x, and on further thought I agree. I don't agree. Votes on going straight to 2.2.0-alpha? -0.5 on calling it 2.2.x. I'm seeing it

Re: [VOTE] Commit Policy on 2.2.x

2005-05-14 Thread Justin Erenkrantz
--On Wednesday, May 11, 2005 6:49 PM -0700 Paul Querna [EMAIL PROTECTED] wrote: I propose the following policy apply to the 2.2.x branch, once (and if) it is created: Before GA: A 'soft' CTR. Any small bug fixes can be directly committed. Any API changes must be reviewed by the list. (lazy

Re: [PATCH] mod_cache, don't always run as a quick handler.

2005-05-14 Thread Justin Erenkrantz
On Thu, May 12, 2005 at 11:34:38AM -0500, William A. Rowe, Jr. wrote: Let me suggest, instead, that every proxy between here and Timbuktu suffers the same problem from your example. Better, methinks, is for mod_rewrite to toggle Vary: for the envvar that triggered its rewrite. This is

Re: [PROPOSAL] Branch 2.1.x on May 13

2005-05-02 Thread Justin Erenkrantz
--On Friday, April 29, 2005 3:45 PM -0700 Paul Querna [EMAIL PROTECTED] wrote: I am proposing the branch date be May 13, 2005. ++1. -- justin

Re: [PROPOSAL] Branch 2.1.x on May 13

2005-05-02 Thread Justin Erenkrantz
--On Monday, May 2, 2005 3:33 PM -0400 Jim Jagielski [EMAIL PROTECTED] wrote: I thought the whole idea about having a 2.1 dev version was to avoid monkeying around with the API and the problems when we were doing 1.3 and 2.0. Once we branch, it is possible that we'll run into issues that may

Re: Proposed patch: always cleanup brigades in ap_pass_brigade

2005-04-25 Thread Justin Erenkrantz
--On Monday, April 25, 2005 12:47 PM -0500 Rici Lake [EMAIL PROTECTED] wrote: Regardless of any other changes to the brigade API, this seems to me to be a good idea: Index: util_filter.c === --- util_filter.c (revision 158730)

Re: Proposed patch: always cleanup brigades in ap_pass_brigade

2005-04-25 Thread Justin Erenkrantz
--On Monday, April 25, 2005 3:06 PM -0500 Rici Lake [EMAIL PROTECTED] wrote: Can you quantify that large overhead? In the case of a 'compliant' filter, it consists of: With Joe's suggestion for 'creator must destroy', this step is wholly unnecessary and only overcomplicates things. -- justin

Re: For review: teach mod_include.c to recycle brigades

2005-04-25 Thread Justin Erenkrantz
--On Monday, April 25, 2005 4:47 PM -0500 Rici Lake [EMAIL PROTECTED] wrote: explicit cleanup, while we continue thrashing out that issue. (nd -- do you have a test suite, by any chance?) httpd-test's has a bunch of tests for mod_include. -- justin

Re: Proposed patch: always cleanup brigades in ap_pass_brigade

2005-04-25 Thread Justin Erenkrantz
--On Monday, April 25, 2005 9:34 PM -0700 Paul Querna [EMAIL PROTECTED] wrote: Plus, I hear those new dual core opterons are really nice. I would rather have a better and cleaner API, than save a few CPU cycles here. The posted patch does nothing to make the brigades or filter a cleaner API.

Re: mod_cache caching the 301 Moved Permanently

2005-04-21 Thread Justin Erenkrantz
On Thu, Apr 21, 2005 at 10:04:54AM +0530, Devendra Singh wrote: Hi, I am writing to the Developer List because I did not get any response on the Users List and thought that the topic might be relevant to the dev list. If a request comes for a directory w/o trailing slash, it gets cached

Re: AP_MODE_EATCRLF considered indigestible

2005-04-15 Thread Justin Erenkrantz
On Fri, Apr 15, 2005 at 10:16:29AM -0500, Rici Lake wrote: Perhaps I wasn't being clear. AP_MODE_EATCRLF is not a renaming of AP_MODE_GETLINE; it is a renaming of AP_MODE_PEEK. (The renaming happened some three years ago in revision 92928, obviously I'm not al tanto.) To be more precise, it's

Re: AP_MODE_EATCRLF considered indigestible

2005-04-15 Thread Justin Erenkrantz
On Fri, Apr 15, 2005 at 11:36:07AM -0500, Rici Lake wrote: Are there browsers which send more than four extraneous CRLF's but still support keepalive? If this code reads four CRLF's without finding any data, it will assume that there is no immediate incoming request, and send a flush down

Re: AP_MODE_EATCRLF considered indigestible

2005-04-15 Thread Justin Erenkrantz
On Fri, Apr 15, 2005 at 11:56:38AM -0400, Greg Ames wrote: Rici Lake wrote: I was taking a look at the implementation of the renamed (but still misleading) AP_MODE_EATCRLF, AP_MODE_PEEK was more accurate, but whatever... No, it certainly wasn't, but let's not re-open old wounds. ;-)

Re: AP_MODE_EATCRLF considered indigestible

2005-04-15 Thread Justin Erenkrantz
On Fri, Apr 15, 2005 at 10:09:39AM -0700, Justin Erenkrantz wrote: This would save us from the extra round trip. I'm not sure where else we could even place such a check besides ap_pass_brigade. -- justin Thinking about this a little bit more: There's no reason we couldn't do the following

Re: 2.0.54 release candidate tarball available for testing

2005-04-13 Thread Justin Erenkrantz
--On Tuesday, April 12, 2005 9:25 AM +0200 Sander Striker [EMAIL PROTECTED] wrote: Hi, As usual the tarballs are at: http://httpd.apache.org/dev/dist/ Please give 2.0.54 a whirl and report any problems (or successes) ;) +1. Passes httpd-test on Darwin with the unexpected success on include

Re: simple-conf ready for merge

2005-04-06 Thread Justin Erenkrantz
--On Wednesday, April 6, 2005 10:42 AM -0400 Joshua Slive [EMAIL PROTECTED] wrote: I'm pretty-much done shredding the default config and I will give a couple days for review before I merge it. Feel free to correct any problems you see. +1 to merge back to trunk. (14k vs. 38k. Yay!) One last

Re: Default Modules

2005-04-06 Thread Justin Erenkrantz
--On Wednesday, April 6, 2005 12:29 PM -0400 Rich Bowen [EMAIL PROTECTED] wrote: How about mod_ssl being on in most? In the past, we've said that SSL must be explicit because of the crypto legal restrictions. -- justin

Re: Default Modules

2005-04-06 Thread Justin Erenkrantz
--On Wednesday, April 6, 2005 9:15 AM -0700 Paul Querna [EMAIL PROTECTED] wrote: I changed mod_imap this morning from 'yes' to 'most', because I was tired of disabling it every time I do a new install. I think we should reconsider what modules are enabled by default. Here is my list of

<    1   2   3   4   5   6   7   8   9   10   >