[PATCH] Re: mod_authz_core:check_provider_list bug?

2006-03-09 Thread Max Bowsher
Joe Orton wrote: Found by the Coverity report, this one looks like a real bug: check_provider_list has a if() branch to handle the passed-in current_provider being NULL, but never sets it to anything else; current_provider is later dereferenced unconditionally. It looks like the

[PATCH] Re: mod_authz_core:check_provider_list bug?

2006-03-09 Thread Brad Nicholes
On 3/9/2006 at 4:49:24 am, in message [EMAIL PROTECTED], Max Bowsher [EMAIL PROTECTED] wrote: Joe Orton wrote: Found by the Coverity report, this one looks like a real bug: check_provider_list has a if() branch to handle the passed-in current_provider being NULL, but never sets it to

Re: [PATCH] Re: mod_authz_core:check_provider_list bug?

2006-03-09 Thread Max Bowsher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Joe Orton wrote: Found by the Coverity report, this one looks like a real bug: check_provider_list has a if() branch to handle the passed-in current_provider being NULL, but never sets it to anything else; current_provider is later

Re: [PATCH] Re: mod_authz_core:check_provider_list bug?

2006-03-09 Thread Brad Nicholes
{ On 3/9/2006 at 10:15:33 am, in message [EMAIL PROTECTED], Max Bowsher [EMAIL PROTECTED] wrote: ((( since the access control directives 'Allow/Deny' have been folded in as providers. ))) ^^^ This bit isn't true. What do you mean? The actual directives are only supported in trunk through

Re: [PATCH] Re: mod_authz_core:check_provider_list bug?

2006-03-09 Thread Justin Erenkrantz
On 3/9/06, Brad Nicholes [EMAIL PROTECTED] wrote: What do you mean? The actual directives are only supported in trunk through the compatibility module mod_access_compat. This module as well BTW, can we consider dropping the warning about the deprecated authz directives in mod_access_compat to

Re: [PATCH] Re: mod_authz_core:check_provider_list bug?

2006-03-09 Thread Brad Nicholes
On 3/9/2006 at 10:37:53 am, in message [EMAIL PROTECTED], [EMAIL PROTECTED] wrote: On 3/9/06, Brad Nicholes [EMAIL PROTECTED] wrote: What do you mean? The actual directives are only supported in trunk through the compatibility module mod_access_compat. This module as well BTW, can we

Re: [PATCH] Re: mod_authz_core:check_provider_list bug?

2006-03-09 Thread Max Bowsher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brad Nicholes wrote: { On 3/9/2006 at 10:15:33 am, in message [EMAIL PROTECTED], Max Bowsher [EMAIL PROTECTED] wrote: ((( since the access control directives 'Allow/Deny' have been folded in as providers. ))) ^^^ This bit isn't true.