Re: [PATCH] mod_disk cached fixed

Brian Akins wrote... [EMAIL PROTECTED] wrote... Brian Akins wrote... Serving cached content: - lookup uri in cache (via md5?). - check varies - a list of headers to vary on - caculate new key (md5) based on uri and clients value of these headers - lookup new uri in

Re: [PATCH] mod_disk cached fixed

[EMAIL PROTECTED] wrote: I thought you were referring to the scheme you proposed in an earlier email where you WERE planning on doing just that... Once again, I probably was just uncelar or, frankly, said what I didn't mean :) Take your logic just a tiny step farther. I you know EVERYTHING about

[PATCH] mod_disk cached fixed

Sorry about this, but the last patch had a mistake in the writev -- Brian Akins Senior Systems Engineer CNN Internet Technologies --- httpd-2.0.50.old/modules/experimental/mod_disk_cache.c 2004-02-09 15:53:16.0 -0500 +++ httpd-2.0.50/modules/experimental/mod_disk_cache.c 2004-08-04

Re: [PATCH] mod_disk cached fixed

Brian Akins wrote: Sorry about this, but the last patch had a mistake in the writev How resilient is this to garbage data on the disk? A risk exists of somebody getting write access to the headers cache file, and then crafting a cache headers file which when read causes a takeover of the

Re: [PATCH] mod_disk cached fixed

Graham Leggett wrote: How resilient is this to garbage data on the disk? A risk exists of somebody getting write access to the headers cache file, and then crafting a cache headers file which when read causes a takeover of the webserver. Just want to check that it's covered. That exists for

Re: [PATCH] mod_disk cached fixed

--On Wednesday, August 4, 2004 5:26 PM +0200 Graham Leggett [EMAIL PROTECTED] wrote: How resilient is this to garbage data on the disk? A risk exists of somebody getting write access to the headers cache file, and then crafting a cache headers file which when read causes a takeover of the

Re: [PATCH] mod_disk cached fixed

--On Wednesday, August 4, 2004 8:56 AM -0400 Brian Akins [EMAIL PROTECTED] wrote: Sorry about this, but the last patch had a mistake in the writev Looks okay - I'll take a look at incorporating it to my local changes and see how it helps. The one thing I'd change is the sizeof(char) to

Re: [PATCH] mod_disk cached fixed

Should this: cache_in_filter_handle = ap_register_output_filter(CACHE_IN, cache_in_filter, NULL, AP_FTYPE_CONTENT_SET-1); Actually be this: cache_in_filter_handle =

Re: [PATCH] mod_disk cached fixed

Brian Akins wrote: Should this: cache_in_filter_handle = ap_register_output_filter(CACHE_IN, cache_in_filter, NULL, AP_FTYPE_CONTENT_SET-1); Actually be this: cache_in_filter_handle =

mod_cache filter priorities was Re: [PATCH] mod_disk cached fixed

--On Wednesday, August 4, 2004 4:26 PM -0400 Brian Akins [EMAIL PROTECTED] wrote: Notice the plus in the second. I thought about that, too. If you place it with the +1, then you'd be after mod_deflate. I'm not yet fully sure what the implication of that would be. Moving the filters around

Re: [PATCH] mod_disk cached fixed

Bill Stoddard wrote: This is the area in which mod_cache is most broken. It does not handle vary at all, thus the content needs to be stored before it is touched by any filters. But that doesn't work either because some filters will not properly run when serving content out of a quick_handler

Re: [PATCH] mod_disk cached fixed

--On Wednesday, August 4, 2004 4:52 PM -0400 Brian Akins [EMAIL PROTECTED] wrote: Possible scenerio: Serving cached content: - lookup uri in cache (via md5?). - check varies - a list of headers to vary on - caculate new key (md5) based on uri and clients value of these headers - lookup new uri

Re: [PATCH] mod_disk cached fixed

On Wed, 4 Aug 2004, Justin Erenkrantz wrote: --On Wednesday, August 4, 2004 4:52 PM -0400 Brian Akins [EMAIL PROTECTED] wrote: The thing that sucks is if you vary on User-Agent. You wind up with a ton of entries per uri. I cheated in another modules by varying on an environmental variable.

Re: [PATCH] mod_disk cached fixed

Brian Akins wrote... Serving cached content: - lookup uri in cache (via md5?). - check varies - a list of headers to vary on - caculate new key (md5) based on uri and clients value of these headers - lookup new uri in cache - continue as normal Don't forget that you can't just 'MD5' a

Re: [PATCH] mod_disk cached fixed

--On Wednesday, August 4, 2004 5:18 PM -0400 Joshua Slive [EMAIL PROTECTED] wrote: But it couldn't be as expensive as caching a variant for every User-Agent that accesses your site. What is probably needed is CacheVaryOn env-variable which would override the vary-matching decision to vary only