Can we get a vote on this? Jim gave it +1. So do I. I would like this
to be in a beta release. This fix is important to our environment.
[EMAIL PROTECTED] wrote:
Jim Jagielski wrote:
Sorry :)
Thanks. So I guess this should be fine:
Index: mod_proxy.c
Brian Akins wrote:
Can we get a vote on this? Jim gave it +1. So do I. I would like this
to be in a beta release. This fix is important to our environment.
Never mind. See this in trunk...
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies
On 10/28/2005 03:46 PM, Brian Akins wrote:
Brian Akins wrote:
Can we get a vote on this? Jim gave it +1. So do I. I would like
this to be in a beta release. This fix is important to our
environment.
Never mind. See this in trunk...
It is also backported to 2.2.x. So it will be
On Sep 28, 2005, at 5:09 PM, [EMAIL PROTECTED] wrote:
Brian Akins wrote:
Here is a trivial patch that will allow proxy_handler to run the
request_status hook if pre_request fails. This is necessary if all
balncer members are in an error state, so that other modules get a
If all workers
Jim Jagielski wrote:
On Sep 28, 2005, at 5:09 PM, [EMAIL PROTECTED] wrote:
Brian Akins wrote:
[..cut..]
Hmmm... It might be best to, in ap_proxy_pre_request() set
*balancer to NULL if the result from proxy_run_pre_request()
isn't OK. Then we can call jump to cleanup.
Yes, this
Mladen Turk wrote:
if (access_status != OK) {
if (access_status != HTTP_SERVICE_UNAVAILABLE)
return access_status;
else
goto cleanup;
}
I guess that makes sense. I just want to chatch the following cases:
No available workers - all in error or busy
worker failed - ie
On Sep 29, 2005, at 9:40 AM, Brian Akins wrote:
Mladen Turk wrote:
if (access_status != OK) {
if (access_status != HTTP_SERVICE_UNAVAILABLE)
return access_status;
else
goto cleanup;
}
I guess that makes sense. I just want to chatch the following cases:
No available
Jim Jagielski wrote:
On Sep 29, 2005, at 9:40 AM, Brian Akins wrote:
Mladen Turk wrote:
if (access_status != OK) {
if (access_status != HTTP_SERVICE_UNAVAILABLE)
return access_status;
else
goto cleanup;
}
I guess that makes sense. I just want to chatch the
Jim Jagielski wrote:
This means if access_status is DECLINED, we would return. Would
that work for you??
Yes. Just need to run request_status in case of error.
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies
Except for the formatting +1 :)
On Sep 29, 2005, at 12:01 PM, [EMAIL PROTECTED] wrote:
What about the following patch? I think it should address all the
things
discussed.
Regards
Rüdiger
Index: mod_proxy.c
===
---
As I try to improve my Apache code style awareness. What is wrong with the
formatting?
Regards
Rüdiger
Jim Jagielski wrote:
Except for the formatting +1 :)
On Sep 29, 2005, at 12:01 PM, [EMAIL PROTECTED] wrote:
What about the following patch? I think it should address all the things
Sorry :)
The single line if statements. The pref is
if (foo)
banana();
rather than
if (foo) banana();
On Sep 29, 2005, at 2:32 PM, [EMAIL PROTECTED] wrote:
As I try to improve my Apache code style awareness. What is wrong
with the
formatting?
Regards
Rüdiger
Jim
[EMAIL PROTECTED] wrote:
As I try to improve my Apache code style awareness. What is wrong with the
formatting?
http://httpd.apache.org/dev/styleguide.html
The basic objection to your patch would be that statements after
your if's; put them on the next line.
HTH,
Sander
Regards
Jim Jagielski wrote:
Sorry :)
Thanks. So I guess this should be fine:
Index: mod_proxy.c
===
--- mod_proxy.c (Revision 280422)
+++ mod_proxy.c (Arbeitskopie)
@@ -679,8 +679,22 @@
char *url = uri;
/* Try to
Here is a trivial patch that will allow proxy_handler to run the
request_status hook if pre_request fails. This is necessary if all
balncer members are in an error state, so that other modules get a
chance to recover from the error. In my case, I force the cache to
serve old data.
---
Brian Akins wrote:
Here is a trivial patch that will allow proxy_handler to run the
request_status hook if pre_request fails. This is necessary if all
balncer members are in an error state, so that other modules get a
If all workers are in error state, worker will be NULL. Are you sure that
16 matches
Mail list logo
