-------- Original Message --------
Subject: svn commit: r1386726 - in /httpd/httpd/trunk:
docs/log-message-tags/next-number modules/slotmem/mod_slotmem_shm.c
Date: Mon, 17 Sep 2012 17:19:45 GMT
From: j...@apache.org
Author: jim
Date: Mon Sep 17 17:19:44 2012
New Revision: 1386726
URL: http://svn.apache.org/viewvc?rev=1386726&view=rev
Log:
Add debug output when slotmem is persisting shm
Modified:
httpd/httpd/trunk/docs/log-message-tags/next-number
httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c
Modified: httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c?rev=1386726&r1=1386725&r2=1386726&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c (original)
+++ httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c Mon Sep 17 17:19:44 2012
@@ -144,6 +144,11 @@ static const char *slotmem_filename(apr_
return fname;
}
+static const char *storemem_filename(apr_pool_t *pool, const char *name)
+{
+ return apr_pstrcat(pool, name, ".persist", NULL);
+}
+
static void store_slotmem(ap_slotmem_instance_t *slotmem)
{
apr_file_t *fp;
@@ -151,7 +156,10 @@ static void store_slotmem(ap_slotmem_ins
apr_size_t nbytes;
const char *storename;
- storename = slotmem_filename(slotmem->gpool, slotmem->name);
+ storename = storemem_filename(slotmem->gpool, slotmem->name);
Is it really a good idea to replace all the additional stuff slotmem_filename
does
like taking care of relative filenames or the special handling of "none" with
just
a plain apr_pstrcat?
And how is this change related to the comment in the commit log? It seems quite
more then just doing debug output.
Regards
Rüdiger
