Re: ProxyErrorOverride inside location

2009-02-05 Thread Nick Gearls
It seems there is a little problem in my code. When defining ProxyErrorOverride On at the vhost level, then ProxyErrorOverride Off at a directory level, the directive does not seem to work at the directory level. The merge works correctly, I traced it, and error_override is set to 1 at

Re: ProxyErrorOverride inside location

2009-02-03 Thread Nick Gearls
The development was actually done in 2.2. I do not see any difference between 2.2 2.3 regarding this. Eric Covener wrote: On Tue, Feb 3, 2009 at 5:39 AM, Nick Gearls nickgea...@gmail.com wrote: A patch is submitted: https://issues.apache.org/bugzilla/show_bug.cgi?id=46656 Here are the

Re: ProxyErrorOverride inside location

2009-02-03 Thread Eric Covener
On Tue, Feb 3, 2009 at 5:39 AM, Nick Gearls nickgea...@gmail.com wrote: A patch is submitted: https://issues.apache.org/bugzilla/show_bug.cgi?id=46656 Here are the modifs: - added |ACCESS_CONF to AP_INIT_FLAG - error_override error_override_set are moved to proxy_dir_conf -

Re: ProxyErrorOverride inside location

2009-02-03 Thread Eric Covener
On Tue, Feb 3, 2009 at 9:33 AM, Nick Gearls nickgea...@gmail.com wrote: The development was actually done in 2.2. I do not see any difference between 2.2 2.3 regarding this. Since the per-server config appears in a public header, it's fair game that other modules have a reference to it. They

Re: ProxyErrorOverride inside location

2009-02-03 Thread Nick Gearls
I understand now. What about 2.3 ? To be honest, I really cannot imagine another module using that value, even in 2.2. But we have to be strict, I agree. Does the code satisfies everybody, or should I rework it in any way ? Eric Covener wrote: On Tue, Feb 3, 2009 at 9:33 AM, Nick Gearls

Re: ProxyErrorOverride inside location

2009-02-03 Thread Plüm, Rüdiger, VF-Group
-Ursprüngliche Nachricht- Von: Eric Covener Gesendet: Dienstag, 3. Februar 2009 16:11 An: dev@httpd.apache.org Betreff: Re: ProxyErrorOverride inside location On Tue, Feb 3, 2009 at 9:33 AM, Nick Gearls nickgea...@gmail.com wrote: The development was actually done in 2.2

ProxyErrorOverride inside location

2009-02-03 Thread Nick Gearls
A patch is submitted: https://issues.apache.org/bugzilla/show_bug.cgi?id=46656 Here are the modifs: - added |ACCESS_CONF to AP_INIT_FLAG - error_override error_override_set are moved to proxy_dir_conf - set_proxy_error_override() is modified to use provided dconf* As I explained, this is very