Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Jeffrey E Burgoyne
Against 2.2.14 source, in short, add an array of URL's for which the preserveproxyhost is required, bit of code for the config parameter, and a small change to check if the URL matches one of the list. ht01b07:~/apacheConfig/tarball/httpd-2.2.14/modules/proxy # diff mod_proxy.h

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Jim Jagielski
Jeffrey, Sorry to be a pain but can it be in diff -u or svn diff format please? http://httpd.apache.org/dev/patches.html thx! On Feb 24, 2011, at 7:55 AM, Jeffrey E Burgoyne wrote: Against 2.2.14 source, in short, add an array of URL's for which the preserveproxyhost is required,

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Jeffrey E Burgoyne
No pain, I wanted something simple so people can decide if the concept is worth having. I figured that if I require it, eventually some else eventually will as well : ht01b07:~/apacheConfig/tarball/httpd-2.2.14/modules/proxy # diff -u mod_proxy.h mod_proxy.h.real --- mod_proxy.h 2011-02-24

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Tom Evans
On Wed, Feb 23, 2011 at 7:12 PM, Jeffrey E Burgoyne burgo...@keenuh.com wrote: I am doing some work with a large organization that has recently acquired two products that work properly through a reverse proxy system only when ProxyPreserveHost is set to on. The organization had issue as they

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Jeffrey E Burgoyne
In a location context (do not believe I can use a directory as it is being proxied), I thought about that. I felt it was better to mirror the current ProxyPass configuration item for consistencies sake. For example : ProxyPass /cgi-bin http://otherserver.com/cgi-bin is the current standard as

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Jeffrey E Burgoyne
Sorry, should have read it closer, change my example to : Location /cgi-bin ProxyPass http://otherserver.com/cgi-bin /Location So I just went with that style. On Wed, Feb 23, 2011 at 7:12 PM, Jeffrey E Burgoyne burgo...@keenuh.com wrote: I am doing some work with a large

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Eric Covener
On Thu, Feb 24, 2011 at 9:44 AM, Jeffrey E Burgoyne burgo...@keenuh.com wrote: Sorry, should have read it closer, change my example to : Location /cgi-bin    ProxyPass http://otherserver.com/cgi-bin /Location I don't think that syntax is much less standard than the 2 argument version. Is

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Tom Evans
On Thu, Feb 24, 2011 at 2:40 PM, Jeffrey E Burgoyne burgo...@keenuh.com wrote: In a location context (do not believe I can use a directory as it is being proxied), I thought about that. I felt it was better to mirror the current ProxyPass configuration item for consistencies sake. There isn't

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Jeffrey E Burgoyne
I agree I like that better. Implementation looks more in-depth than the work I've done before, I'll have a look at it sometime if no one else wishes to take it up. Well, that style would be to have an option to ProxyPass that flips the worker's preserve host attribute, eg: ProxyPass

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Nick Kew
On Thu, 24 Feb 2011 09:47:07 -0500 Eric Covener cove...@gmail.com wrote: On Thu, Feb 24, 2011 at 9:44 AM, Jeffrey E Burgoyne burgo...@keenuh.com wrote: Sorry, should have read it closer, change my example to : Location /cgi-bin    ProxyPass http://otherserver.com/cgi-bin /Location

Fwd: ProxyPreserveHost - added functionality

2011-02-24 Thread Nick Gearls
ProxyPass /cgi-bin/ http://otherserver.com/cgi-bin/ preservehost=On keepalive=Off This is more akin to how other worker properties are set. What when we use RewriteRule[P] to proxy instead of ProxyPass? For those who wonder why some may want to use RewriteRule, instead of ProxyPass: it is

RE: ProxyPreserveHost - added functionality

2011-02-24 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Nick Gearls [mailto:nickgea...@gmail.com] Sent: Donnerstag, 24. Februar 2011 16:13 To: Development Apache Subject: Fwd: ProxyPreserveHost - added functionality ProxyPass /cgi-bin/ http://otherserver.com/cgi-bin/ preservehost=On keepalive=Off

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Igor Gali?
- Jeffrey E Burgoyne burgo...@keenuh.com wrote: I am doing some work with a large organization that has recently acquired two products that work properly through a reverse proxy system only when ProxyPreserveHost is set to on. The organization had issue as they are mandated to have only

Re: ProxyPreserveHost - added functionality

2011-02-24 Thread Jim Jagielski
On Feb 24, 2011, at 10:27 AM, Plüm, Rüdiger, VF-Group wrote: -Original Message- From: Nick Gearls [mailto:nickgea...@gmail.com] Sent: Donnerstag, 24. Februar 2011 16:13 To: Development Apache Subject: Fwd: ProxyPreserveHost - added functionality ProxyPass /cgi-bin/ http

ProxyPreserveHost - added functionality

2011-02-23 Thread Jeffrey E Burgoyne
I am doing some work with a large organization that has recently acquired two products that work properly through a reverse proxy system only when ProxyPreserveHost is set to on. The organization had issue as they are mandated to have only a single hostname as a point of entry for their web

Re: ProxyPreserveHost - added functionality

2011-02-23 Thread Nick Kew
On Wed, 23 Feb 2011 14:12:44 -0500 Jeffrey E Burgoyne burgo...@keenuh.com wrote: If people feel this is a worthwhile addition to the main code base, please let me know and I'll pass it back. Not sure I follow exactly what you've added. How big a patch is your change? If it's not too big to

Re: ProxyPreserveHost - added functionality

2011-02-23 Thread Jeffrey E Burgoyne
Quite small, only took a few hours to do. I'll post it tomorrow. Basically it does the same as PreserveProxyHost except it works on a URL basis, not on a per virtual host basis. On Wed, 23 Feb 2011 14:12:44 -0500 Jeffrey E Burgoyne burgo...@keenuh.com wrote: If people feel this is a