On Fri, Sep 27, 2024 at 2:48 PM Eric Covener wrote:
> > Feel free to ask if you want to clarify some bits in FPM or its tests. I
> will also try to find some time to test this patch (most likely next week)
> and later I plan to do some integration tests which could potentially run
> daily against
> Feel free to ask if you want to clarify some bits in FPM or its tests. I will
> also try to find some time to test this patch (most likely next week) and
> later I plan to do some integration tests which could potentially run daily
> against trunk (it's a bit longer term plan though).
Hi Jaku
Hello,
I'm PHP-FPM maintainer. We got actually report about this as well so just
went through this.
On Sat, Aug 3, 2024 at 7:35 PM Eric Covener wrote:
> On Fri, Aug 2, 2024 at 12:19 PM Yann Ylavic wrote:
> >
> > On Fri, Aug 2, 2024 at 3:26 PM Eric Covener wrote:
> > >
> > > On Fri, Aug 2, 202
On Fri, Aug 2, 2024 at 12:19 PM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 3:26 PM Eric Covener wrote:
> >
> > On Fri, Aug 2, 2024 at 9:10 AM Yann Ylavic wrote:
> > >
> > > On Fri, Aug 2, 2024 at 1:06 PM Eric Covener wrote:
> > > >
> > > > > Yeah, if not under DocumentRoot I don't see how Pr
On Fri, Aug 2, 2024 at 3:26 PM Eric Covener wrote:
>
> On Fri, Aug 2, 2024 at 9:10 AM Yann Ylavic wrote:
> >
> > On Fri, Aug 2, 2024 at 1:06 PM Eric Covener wrote:
> > >
> > > > Yeah, if not under DocumentRoot I don't see how ProxyPass could work,
> > > > but SetHandler should since it's followi
On Fri, Aug 2, 2024 at 9:10 AM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 1:06 PM Eric Covener wrote:
> >
> > > Yeah, if not under DocumentRoot I don't see how ProxyPass could work,
> > > but SetHandler should since it's following the whole request
> > > processing to resolve the filesystem r-
On Fri, Aug 2, 2024 at 3:10 PM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 1:06 PM Eric Covener wrote:
> >
> > > Yeah, if not under DocumentRoot I don't see how ProxyPass could work,
> > > but SetHandler should since it's following the whole request
> > > processing to resolve the filesystem r-
On Fri, Aug 2, 2024 at 1:06 PM Eric Covener wrote:
>
> > Yeah, if not under DocumentRoot I don't see how ProxyPass could work,
> > but SetHandler should since it's following the whole request
> > processing to resolve the filesystem r->filename?
>
> In the examples I am seeing spot-checking google
> Yeah, if not under DocumentRoot I don't see how ProxyPass could work,
> but SetHandler should since it's following the whole request
> processing to resolve the filesystem r->filename?
In the examples I am seeing spot-checking google results, people who
use ProxyPass + FPM hard-code the document
On Fri, Aug 2, 2024 at 11:33 AM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 6:02 AM Eric Covener wrote:
> >
> > On Thu, Aug 1, 2024 at 9:22 PM Yann Ylavic wrote:
> > > >
> > > > For this how about this attached patch?
> > > > With it I can get the correct env vars (I think), and since we'd not
On Fri, Aug 2, 2024 at 6:02 AM Eric Covener wrote:
>
> On Thu, Aug 1, 2024 at 9:22 PM Yann Ylavic wrote:
> > >
> > > For this how about this attached patch?
> > > With it I can get the correct env vars (I think), and since we'd not
> > > send a "proxy:" SCRIPT_FILENAME anymore, php-fpm would not
On Fri, Aug 2, 2024 at 5:22 AM Eric Covener wrote:
>
> On Thu, Aug 1, 2024 at 9:12 PM Yann Ylavic wrote:
> >
> > On Fri, Aug 2, 2024 at 12:18 AM Yann Ylavic wrote:
> > >
> > > So we probably should keep encoding r->filename with ProxyPass, and
> > > come back to my previous patch which skipped i
On Thu, Aug 1, 2024 at 9:22 PM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 3:12 AM Yann Ylavic wrote:
> >
> > On Fri, Aug 2, 2024 at 12:18 AM Yann Ylavic wrote:
> > >
> > > So we probably should keep encoding r->filename with ProxyPass, and
> > > come back to my previous patch which skipped it
On Thu, Aug 1, 2024 at 9:12 PM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 12:18 AM Yann Ylavic wrote:
> >
> > So we probably should keep encoding r->filename with ProxyPass, and
> > come back to my previous patch which skipped it only for SetHandler?
> > Possibly FCGI_MAY_BE_FPM() only too bec
On Fri, Aug 2, 2024 at 3:12 AM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 12:18 AM Yann Ylavic wrote:
> >
> > So we probably should keep encoding r->filename with ProxyPass, and
> > come back to my previous patch which skipped it only for SetHandler?
> > Possibly FCGI_MAY_BE_FPM() only too bec
On Fri, Aug 2, 2024 at 12:18 AM Yann Ylavic wrote:
>
> So we probably should keep encoding r->filename with ProxyPass, and
> come back to my previous patch which skipped it only for SetHandler?
> Possibly FCGI_MAY_BE_FPM() only too because for "ProxyFCGIBackendType
> GENERIC" we don't send the "pr
On Thu, Aug 1, 2024 at 9:53 PM Eric Covener wrote:
>
> On Thu, Aug 1, 2024 at 2:47 PM Yann Ylavic wrote:
> >
> > On Thu, Aug 1, 2024 at 7:57 PM Eric Covener wrote:
> > >
> > > On Thu, Aug 1, 2024 at 1:37 PM Yann Ylavic wrote:
> > > >
> > > > On Thu, Aug 1, 2024 at 5:51 PM Eric Covener wrote:
>
On Thu, Aug 1, 2024 at 2:47 PM Yann Ylavic wrote:
>
> On Thu, Aug 1, 2024 at 7:57 PM Eric Covener wrote:
> >
> > On Thu, Aug 1, 2024 at 1:37 PM Yann Ylavic wrote:
> > >
> > > On Thu, Aug 1, 2024 at 5:51 PM Eric Covener wrote:
> > > >
> > > > But does it leave the splitting problem with decoded
On Thu, Aug 1, 2024 at 7:57 PM Eric Covener wrote:
>
> On Thu, Aug 1, 2024 at 1:37 PM Yann Ylavic wrote:
> >
> > On Thu, Aug 1, 2024 at 5:51 PM Eric Covener wrote:
> > >
> > > But does it leave the splitting problem with decoded %3F?
> >
> > Yeah but I'm not sure that it's _our_ problem, a "prox
On Thu, Aug 1, 2024 at 1:37 PM Yann Ylavic wrote:
>
> On Thu, Aug 1, 2024 at 5:51 PM Eric Covener wrote:
> >
> > But does it leave the splitting problem with decoded %3F?
>
> Yeah but I'm not sure that it's _our_ problem, a "proxy:" r->filename
> does never contain the query-string in the first p
On Thu, Aug 1, 2024 at 5:51 PM Eric Covener wrote:
>
> But does it leave the splitting problem with decoded %3F?
Yeah but I'm not sure that it's _our_ problem, a "proxy:" r->filename
does never contain the query-string in the first place, so any '?' in
there (hence in SCRIPT_FILENAME) is part of
On Thu, Aug 1, 2024 at 10:58 AM Yann Ylavic wrote:
>
> On Wed, Jul 31, 2024 at 7:34 PM Eric Covener wrote:
> >
> > On Tue, Jul 23, 2024 at 5:35 AM Yann Ylavic wrote:
> > >
> > > On Wed, Jul 17, 2024 at 6:22 PM wrote:
> > > >
> > > > https://bz.apache.org/bugzilla/show_bug.cgi?id=69203
> > > >
>
On Wed, Jul 31, 2024 at 7:34 PM Eric Covener wrote:
>
> On Tue, Jul 23, 2024 at 5:35 AM Yann Ylavic wrote:
> >
> > On Wed, Jul 17, 2024 at 6:22 PM wrote:
> > >
> > > https://bz.apache.org/bugzilla/show_bug.cgi?id=69203
> > >
> > > --- Comment #6 from Yann Ylavic ---
> > > Created attachment 398
On Tue, Jul 23, 2024 at 5:35 AM Yann Ylavic wrote:
>
> On Wed, Jul 17, 2024 at 6:22 PM wrote:
> >
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=69203
> >
> > --- Comment #6 from Yann Ylavic ---
> > Created attachment 39817
> > --> https://bz.apache.org/bugzilla/attachment.cgi?id=39817&act
On Wed, Jul 17, 2024 at 6:22 PM wrote:
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=69203
>
> --- Comment #6 from Yann Ylavic ---
> Created attachment 39817
> --> https://bz.apache.org/bugzilla/attachment.cgi?id=39817&action=edit
> Proxy FCGI nocanon from SetHandler
I'm not sure how we s
25 matches
Mail list logo
