Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-09-17 Thread Micha Lenk
Hi Rüdiger, Am 09.09.2011 11:45, schrieb Plüm, Rüdiger, VF-Group: Please update the bug report: 1. Declare the unneeded patch obsolete. 2. Update the needed patch to be against trunk. Done. See https://issues.apache.org/bugzilla/show_bug.cgi?id=51709 What else is needed to get it applied to

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-09-09 Thread Micha Lenk
Hi Rüdiger, On 08/23/2011 12:25 PM CEST +02:00, Plüm, Rüdiger, VF-Group wrote: IMHO the patch does not solve the issue mentioned in the comment and is not needed. Keep in mind the difference between ap_matches_request_vhost and check_host_alias: ap_matches_request_vhost checks only the

RE: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-09-09 Thread Plüm, Rüdiger, VF-Group
Please update the bug report: 1. Declare the unneeded patch obsolete. 2. Update the needed patch to be against trunk. Regards Rüdiger -Original Message- From: Micha Lenk Sent: Freitag, 9. September 2011 11:30 To: dev@httpd.apache.org Subject: Re: With IP address in Host: header

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-23 Thread Micha Lenk
Hi, On 08/22/2011 07:05 PM CEST +02:00, Eric Covener wrote: Do you agree that this is something that needs to be fixed? If yes I could start to work on a patch... I was skeptical but it certainly looks busted for non-wildcard NVH'es (that can match the strcmp with the VH addr) like you've

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-23 Thread Micha Lenk
Hi, On 08/23/2011 10:42 AM CEST +02:00, Micha Lenk wrote: However, I believe the fix is yet incomplete. The function ap_matches_request_vhost() used by modules like mod_proxy seems to implement the virtual host check also in the wrong order. [...] I'll follow up with a patch for this

RE: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-23 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Micha Lenk [mailto:mi...@lenk.info] Sent: Dienstag, 23. August 2011 12:08 To: dev@httpd.apache.org Subject: Re: With IP address in Host: header ServerName/ServerAlias doesn't work Hi, On 08/23/2011 10:42 AM CEST +02:00, Micha Lenk wrote: However

RE: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Micha Lenk Sent: Montag, 22. August 2011 18:10 To: dev@httpd.apache.org Subject: With IP address in Host: header ServerName/ServerAlias doesn't work Do you agree that this is something that needs to be fixed? If yes I could start to work on a

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Micha Lenk
Hi Ruediger, On 08/22/2011 06:16 PM CEST +02:00, Plüm, Rüdiger, VF-Group wrote: No, this works as designed and documented for ages. I guess your question is better suited for the us...@httpd.apache.org list. Sorry, I disagree. The documentation reads: Now when a request arrives, the

RE: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Micha Lenk [mailto:mi...@lenk.info] Sent: Montag, 22. August 2011 18:27 To: dev@httpd.apache.org Subject: Re: With IP address in Host: header ServerName/ServerAlias doesn't work Hi Ruediger, On 08/22/2011 06:16 PM CEST +02:00, Plüm, Rüdiger, VF

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Nick Kew
On Mon, 22 Aug 2011 18:27:10 +0200 Micha Lenk mi...@lenk.info wrote: In the case I described earlier, *only* the virtual server v2 has a ServerName that matches the requested hostname. No it doesn't. ServerName or ServerAlias arguments are just strings, so the :80 makes it a non-match. --

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Micha Lenk
Hi Rüdiger, On 08/22/2011 06:39 PM CEST +02:00, Plüm, Rüdiger, VF-Group wrote: Sorry, I missed the ServerAlias for the IP in the second virtual host. So, yes in general the second virtual host should be hit. But using IP addresses as Serveralias is quite unusual and in this case the solution

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Reindl Harald
Am 22.08.2011 18:54, schrieb Micha Lenk: Hi Rüdiger, On 08/22/2011 06:39 PM CEST +02:00, Plüm, Rüdiger, VF-Group wrote: Sorry, I missed the ServerAlias for the IP in the second virtual host. So, yes in general the second virtual host should be hit. But using IP addresses as Serveralias is

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Micha Lenk
Hi Nick, On 08/22/2011 06:45 PM CEST +02:00, Nick Kew wrote: On Mon, 22 Aug 2011 18:27:10 +0200 Micha Lenk mi...@lenk.info wrote: In the case I described earlier, *only* the virtual server v2 has a ServerName that matches the requested hostname. No it doesn't. ServerName or ServerAlias

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Micha Lenk
On 08/22/2011 06:57 PM CEST +02:00, Reindl Harald wrote: but why the fuck are you using hostnames there especially for Listen? I don't. This was just an example to show that the problem doesn't depend on the usage of IP addresses. Wheter I use a hostname or an IP address for 'Listen' is

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Eric Covener
Do you agree that this is something that needs to be fixed? If yes I could start to work on a patch... I was skeptical but it certainly looks busted for non-wildcard NVH'es (that can match the strcmp with the VH addr) like you've explained. I suggest opening a bugzilla ticket to track. --