On Thu, 23 Oct 2003, [ISO-8859-15] André Malo wrote:
* [EMAIL PROTECTED] wrote:
Log:
fix segfault which occured if the filename was not
set, for example, when processing some error conditions.
-if ((t = strrchr(r-filename, '/'))) {
+if (r-filename (t =
* [EMAIL PROTECTED] wrote:
Log:
fix segfault which occured if the filename was not
set, for example, when processing some error conditions.
-if ((t = strrchr(r-filename, '/'))) {
+if (r-filename (t = strrchr(r-filename, '/'))) {
apr_table_setn(e,
* [EMAIL PROTECTED] wrote:
Modified:modules/filters mod_include.c
Log:
void * can't be used as a function pointer without casting
doh, really? Good to know ;-)
Thanks, nd
André Malo wrote:
* [EMAIL PROTECTED] wrote:
Modified:modules/filters mod_include.c
Log:
void * can't be used as a function pointer without casting
doh, really? Good to know ;-)
unfortunately this is one of a few common issues we hit from time to
time that gcc doesn't catch, at least
Sorry for the lack of timeliness on responding to this. Our mailserver has been
about to be back up any minute now for a couple of days.
The test case that I ran was even more brutal than what your test module does.
Basically I have a small piece of code that puts each byte in its own bucket and
Paul Reder wrote:
Sorry for the lack of timeliness on responding to this. Our mailserver
has been
about to be back up any minute now for a couple of days.
The test case that I ran was even more brutal than what your test
module does.
Basically I have a small piece of code that puts
William A. Rowe, Jr. wrote:
At 03:19 PM 4/4/2002, you wrote:
rederpj 02/04/04 13:19:32
Modified:modules/filters mod_include.c
Log:
This patch fixes a core dump that occurs in mod_include during tag
parsing
if the starting sequence (!--#) finishes at the end of a bucket
At 03:19 PM 4/4/2002, you wrote:
rederpj 02/04/04 13:19:32
Modified:modules/filters mod_include.c
Log:
This patch fixes a core dump that occurs in mod_include during tag parsing
if the starting sequence (!--#) finishes at the end of a bucket and the
directive starts at the
On Thu, 4 Apr 2002, William A. Rowe, Jr. wrote:
This patch fixes a core dump that occurs in mod_include during tag parsing
if the starting sequence (!--#) finishes at the end of a bucket and the
directive starts at the beginning of the next bucket.
Revision ChangesPath
On 5 Apr 2002 [EMAIL PROTECTED] wrote:
brianp 02/04/04 23:44:15
Modified:modules/filters mod_include.c
Log:
Fix for the boundary case in which each character of an SSI directive
is in a separate bucket...the code in send_parsed_content() doesn't
Holy crap, that was fast!
This is *not* equivalent code. In the deleted line the increment happens
*after* the check. In the replacement line of code the increment happens
during the check. This patch is wrong and should be backed out.
Paul J. Reder
[EMAIL PROTECTED] wrote:
bnicholes02/03/28 16:39:56
Nevermind. Should have read the rest of my mail before commenting. I see
that it has already been fixed. Sorry for the noise.
Paul J. Reder wrote:
This is *not* equivalent code. In the deleted line the increment happens
*after* the check. In the replacement line of code the increment happens
[EMAIL PROTECTED] wrote:
bnicholes02/03/28 16:39:56
Modified:modules/filters mod_include.c
Log:
Stop the while loop from incrementing twice per iteration before checking for
the NULL terminator. This was causing the while loop to walk off the end of any
string with an odd
On 29 Mar 2002 [EMAIL PROTECTED] wrote:
-while (*path *(path+1) != '/')
+while (*path (*path != '/')) {
+++path;
+}
+if (*path == '/') {
++path;
+}
Alternatively:
while (*path *(path++) != '/')
On Wed, 27 Feb 2002, Brian Pane wrote:
+if (!APR_BRIGADE_EMPTY(ctx-ssi_tag_brigade)) {
+for (;;) {
+apr_bucket *e = APR_BRIGADE_LAST(ctx-ssi_tag_brigade);
+if (e == APR_BRIGADE_SENTINEL(ctx-ssi_tag_brigade)) {
+
Cliff Woolley wrote:
On Wed, 27 Feb 2002, Brian Pane wrote:
+if (!APR_BRIGADE_EMPTY(ctx-ssi_tag_brigade)) {
+for (;;) {
+apr_bucket *e = APR_BRIGADE_LAST(ctx-ssi_tag_brigade);
+if (e ==
On Thu, Feb 28, 2002 at 12:57:50PM -0500, Cliff Woolley wrote:
The following is equivalent to the above (except it runs in constant
time):
/* prepend ctx-ssi_tag_brigade onto bb */
APR_BRIGADE_CONCAT(ctx-ssi_tag_brigade, bb);
APR_BRIGADE_CONCAT(bb, ctx-ssi_tag_brigade);
But I'd be fine
On Thu, 28 Feb 2002, Cliff Woolley wrote:
On Thu, 28 Feb 2002, Greg Stein wrote:
/* prepend ctx-ssi_tag_brigade onto bb */
APR_BRIGADE_CONCAT(ctx-ssi_tag_brigade, bb);
APR_BRIGADE_CONCAT(bb, ctx-ssi_tag_brigade);
That is *very* obtuse. I can't imagine anybody figuring out that
Cliff Woolley wrote:
On Thu, 28 Feb 2002, Cliff Woolley wrote:
On Thu, 28 Feb 2002, Greg Stein wrote:
/* prepend ctx-ssi_tag_brigade onto bb */
APR_BRIGADE_CONCAT(ctx-ssi_tag_brigade, bb);
APR_BRIGADE_CONCAT(bb, ctx-ssi_tag_brigade);
That is *very* obtuse I can't imagine anybody figuring out
On 24 Feb 2002 [EMAIL PROTECTED] wrote:
+if (!APR_BRIGADE_EMPTY(ctx-ssi_tag_brigade)) {
+for (;;) {
+apr_bucket *e = APR_BRIGADE_LAST(ctx-ssi_tag_brigade);
+if (e == APR_BRIGADE_SENTINEL(ctx-ssi_tag_brigade)) {
+
Cliff Woolley wrote:
On 24 Feb 2002 [EMAIL PROTECTED] wrote:
+if (!APR_BRIGADE_EMPTY(ctx-ssi_tag_brigade)) {
+for (;;) {
+apr_bucket *e = APR_BRIGADE_LAST(ctx-ssi_tag_brigade);
+if (e ==
On 24 Feb 2002 [EMAIL PROTECTED] wrote:
HTTPD-test is failing.
but it was failing on 2.0.32 version of mod-include as well
Really?? What's the verbose output? It worked fine for me when I tested
2.0.32... I'll try it again with HEAD tomorrow.
--Cliff
Cliff Woolley wrote:
On 24 Feb 2002 [EMAIL PROTECTED] wrote:
HTTPD-test is failing.
but it was failing on 2.0.32 version of mod-include as well
Really?? What's the verbose output? It worked fine for me when I tested
2.0.32... I'll try it again with HEAD tomorrow.
--Cliff
I think I have it working now (with the mod_include
changes that I just committed). Mod_include test #31
in httpd-test is failing, but I think it's a config
problem.
We probably need some more test cases in httpd-test
to validate all the boundary conditions that can occur
in mod_include when
This patch is wrong. Only text/html output is valid for consideration.
Just because no handler has been associated to the handler doesn't mean
we should blindly accept the file. Contrawise, even another handler
(e.g. PHP) could be xbithacked using the new filtering features.
So perhaps this
[EMAIL PROTECTED] wrote:
-static int xbithack_handler(request_rec *r)
+static int include_fixup(request_rec *r)
{
#if defined(OS2) || defined(WIN32) || defined(NETWARE)
/* OS/2 dosen't currently support the xbithack. This is being worked on. */
@@ -3201,17 +3201,28 @@
wrowe 01/12/28 09:44:28
Modified:modules/filters mod_include.c
Log:
Improvements suggested by Brian Pane, first assure all OS's get to deal
with handler 'server-parsed', do the xbithack bit tests before testing
it's string values (protected against a null point).
If you really want to get anal:
if ((*tag == 'v' strcmp(tag, virtual) == 0)
|| ...
You can avoid a whole strcmp.
woo! (not)
Then again, you'd just be obfuscating the damned code for little overall
gain.
Cheers,
-g
On Fri, Dec 07, 2001 at 03:09:54AM -, [EMAIL PROTECTED] wrote:
On 1 Dec 2001 [EMAIL PROTECTED] wrote:
brianp 01/11/30 21:38:23
Modified:.CHANGES
modules/filters mod_include.c
Log:
Fix the handling of SSI directives in which the of the
terminating -- is the last byte in a file (previously,
the output of the
On Fri, Sep 07, 2001 at 06:39:17AM -0700, Ryan Bloom wrote:
On Thursday 06 September 2001 22:52, [EMAIL PROTECTED] wrote:
jerenkrantz01/09/06 22:52:29
Modified:modules/filters mod_include.c
Log:
Fix error in Netware-specific code.
(This really should be an APR
On 2 Sep 2001 [EMAIL PROTECTED] wrote:
jerenkrantz01/09/01 18:09:02
Modified:.CHANGES
modules/filters mod_include.c mod_include.h
Log:
Make mod_include check for BYTE_COUNT_THRESHOLD on a per-bucket basis
rather than on a per-character basis. A
Marc Slemko wrote:
On 22 Aug 2001 [EMAIL PROTECTED] wrote:
gregames01/08/22 16:12:24
Modified:modules/filters mod_include.c
Log:
get rid of nuisance log messages due to subrequests failing with EPIPE
Erm... forgive me if I haven't followed any discussion on this...
On Thu, 2001-08-30 at 18:12, Greg Ames wrote:
Marc Slemko wrote:
On 22 Aug 2001 [EMAIL PROTECTED] wrote:
gregames01/08/22 16:12:24
Modified:modules/filters mod_include.c
Log:
get rid of nuisance log messages due to subrequests failing with EPIPE
Erm...
Ian Holsman wrote:
On Thu, 2001-08-30 at 18:12, Greg Ames wrote:
Marc Slemko wrote:
On 22 Aug 2001 [EMAIL PROTECTED] wrote:
gregames01/08/22 16:12:24
Modified:modules/filters mod_include.c
Log:
get rid of nuisance log messages due to subrequests
On 25 Aug 2001 [EMAIL PROTECTED] wrote:
rbb 01/08/24 22:26:05
Modified:.CHANGES
modules/filters mod_include.c
Log:
Add the ability for mod_include to add the INCLUDES filter
if the file is configured for the server-parsed handler.
This makes
On 25 Aug 2001 [EMAIL PROTECTED] wrote:
rbb 01/08/24 22:26:05
Modified:.CHANGES
modules/filters mod_include.c
Log:
Add the ability for mod_include to add the INCLUDES filter
if the file is configured for the server-parsed handler.
This makes
On Friday 24 August 2001 22:41, Cliff Woolley wrote:
On 25 Aug 2001 [EMAIL PROTECTED] wrote:
rbb 01/08/24 22:26:05
Modified:.CHANGES
modules/filters mod_include.c
Log:
Add the ability for mod_include to add the INCLUDES filter
if the file
37 matches
Mail list logo
