Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On 8/2/22 3:19 PM, Yann Ylavic wrote: > On Tue, Aug 2, 2022 at 2:59 PM Ruediger Pluem wrote: >> >> On 8/2/22 2:31 PM, Yann Ylavic wrote: >>> On Mon, Aug 1, 2022 at 8:15 PM Ruediger Pluem wrote: On 8/1/22 5:05 PM, Ivan Zhakov wrote: > > My overall concern is that with the

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Tue, Aug 2, 2022 at 2:59 PM Ruediger Pluem wrote: > > On 8/2/22 2:31 PM, Yann Ylavic wrote: > > On Mon, Aug 1, 2022 at 8:15 PM Ruediger Pluem wrote: > >> > >> On 8/1/22 5:05 PM, Ivan Zhakov wrote: > >>> > >>> My overall concern is that with the current solution as of r1902858, > >>> there

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On 8/2/22 2:31 PM, Yann Ylavic wrote: > On Mon, Aug 1, 2022 at 8:15 PM Ruediger Pluem wrote: >> >> On 8/1/22 5:05 PM, Ivan Zhakov wrote: >>> >>> My overall concern is that with the current solution as of r1902858, there >>> are valid and >>> reasonable allocation patterns that will cause an

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Mon, Aug 1, 2022 at 8:15 PM Ruediger Pluem wrote: > > On 8/1/22 5:05 PM, Ivan Zhakov wrote: > > > > My overall concern is that with the current solution as of r1902858, there > > are valid and > > reasonable allocation patterns that will cause an unbounded memory usage. > > > > For example,

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On 8/1/22 5:05 PM, Ivan Zhakov wrote: > On 2022/07/29 06:19:03 Ruediger Pluem wrote: >> >> >> On 7/16/22 10:28 AM, Ivan Zhakov wrote: >>> On Wed, 13 Jul 2022 at 18:06, Yann Ylavic >> > wrote: >>> >>> On Wed, Jul 13, 2022 at 1:38 PM Ivan Zhakov >>

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On 2022/07/29 06:19:03 Ruediger Pluem wrote: > > > On 7/16/22 10:28 AM, Ivan Zhakov wrote: > > On Wed, 13 Jul 2022 at 18:06, Yann Ylavic > > wrote: > > > > On Wed, Jul 13, 2022 at 1:38 PM Ivan Zhakov > > wrote: > > > > > > On

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On 7/16/22 10:28 AM, Ivan Zhakov wrote: > On Wed, 13 Jul 2022 at 18:06, Yann Ylavic > wrote: > > On Wed, Jul 13, 2022 at 1:38 PM Ivan Zhakov > wrote: > > > > On Sun, 10 Jul 2022 at 19:52, Yann Ylavic

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Sat, Jul 16, 2022 at 10:29 AM Ivan Zhakov wrote: > > On Wed, 13 Jul 2022 at 18:06, Yann Ylavic wrote: >> >> The flexible way for pcre2 users (and httpd maintainers) would be to >> let them opt-out (at runtime) of stack allocation from pcre2_match(), >> which is the patch I proposed. >> > I

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Wed, 13 Jul 2022 at 18:06, Yann Ylavic wrote: > On Wed, Jul 13, 2022 at 1:38 PM Ivan Zhakov wrote: > > > > On Sun, 10 Jul 2022 at 19:52, Yann Ylavic wrote: > > > > > > Let me explain (maybe), I thought that PCRE2's match_data were not > > > only containing the captures vector but also all

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Wed, Jul 13, 2022 at 1:38 PM Ivan Zhakov wrote: > > On Sun, 10 Jul 2022 at 19:52, Yann Ylavic wrote: > > > > Let me explain (maybe), I thought that PCRE2's match_data were not > > only containing the captures vector but also all the frames needed for > > matching not-too-complex regexes (at

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Sun, 10 Jul 2022 at 19:52, Yann Ylavic wrote: > > On Fri, Jul 8, 2022 at 7:15 PM Ivan Zhakov wrote: > > > > On Fri, 8 Jul 2022 at 19:58, Yann Ylavic wrote: > > > > > > The main downside is: > > > > > > > +#ifndef AP_PCRE_STACKBUF_SIZE > > > > +#define AP_PCRE_STACKBUF_SIZE (256) > > > >

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Fri, Jul 8, 2022 at 7:15 PM Ivan Zhakov wrote: > > On Fri, 8 Jul 2022 at 19:58, Yann Ylavic wrote: > > > > The main downside is: > > > > > +#ifndef AP_PCRE_STACKBUF_SIZE > > > +#define AP_PCRE_STACKBUF_SIZE (256) > > > #endif > > [] > > > AP_DECLARE(int) ap_regexec(const ap_regex_t *preg,

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Fri, 8 Jul 2022 at 19:58, Yann Ylavic wrote: > > On Fri, Jul 8, 2022 at 5:07 PM wrote: > > > > Author: ivan > > Date: Fri Jul 8 15:07:00 2022 > > New Revision: 1902572 > > > > URL: http://svn.apache.org/viewvc?rev=1902572=rev > > Log: > > Rewrite ap_regexec() without a thread-local storage

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Fri, Jul 8, 2022 at 5:07 PM wrote: > > Author: ivan > Date: Fri Jul 8 15:07:00 2022 > New Revision: 1902572 > > URL: http://svn.apache.org/viewvc?rev=1902572=rev > Log: > Rewrite ap_regexec() without a thread-local storage context for allocations. > > Provide custom malloc() and free()