Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2002-09-07 Thread Ian Holsman
[EMAIL PROTECTED] wrote: jerenkrantz2002/09/05 00:31:14 Modified:.CHANGES modules/http mod_mime.c Log: Add ModMimeUsePathInfo directive. +int use_path_info;/* If set to 0, only use filename. + * If set to 1, append

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2002-09-05 Thread gregames
Ian Holsman wrote: [EMAIL PROTECTED] wrote: jerenkrantz2002/09/05 00:31:14 Modified:.CHANGES modules/http mod_mime.c Log: Add ModMimeUsePathInfo directive. +int use_path_info;/* If set to 0, only use filename. +

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2002-09-05 Thread Justin Erenkrantz
On Thu, Sep 05, 2002 at 06:43:52AM -0700, Ian Holsman wrote: -1 don't use magic numbers please use a #define Sorry, but the rest of the server uses this strategy for flags. Look specifically at IdentityCheck and ContentDigest. The problem is that the AP_INIT_FLAG and ap_set_flag_slot passes

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-03 Thread Greg Stein
I'm in complete agreement with Justin on this one. Add says add to me. And filters *are* additive. I wouldn't agree with Joshua's comments about tossing filter directives and rely on each module to provide their own (how would you order them?), but I think his meta-comment about this stuff is

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-02 Thread William A. Rowe, Jr.
AddOutputFilter GZ html (server-level) AddOutputFilter Includes html (directory-level) I think what you want is AddOutputFilter Includes html. SetOutputFilterByType gz text/* That syntax doesn't exist... yet :) Bill

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-02 Thread Justin Erenkrantz
On Sun, Sep 02, 2001 at 10:17:46PM -0500, William A. Rowe, Jr. wrote: Thank you, first off, for catching my foobar. But -1 on the solution. This is contrary to the syntax of AddSomething. AddSomething in mod_mime (and SetSomething in core) always _replaces_ the prior declaration!!! If I

Re: cvs commit: httpd-2.0/modules/http mod_mime.c

2001-09-02 Thread William A. Rowe, Jr.
From: Justin Erenkrantz [EMAIL PROTECTED] Sent: Sunday, September 02, 2001 10:40 PM On Sun, Sep 02, 2001 at 10:17:46PM -0500, William A. Rowe, Jr. wrote: Thank you, first off, for catching my foobar. But -1 on the solution. This is contrary to the syntax of AddSomething. AddSomething