[PATCH] Re: mod_cache recall_body

2005-08-18 Thread Brian Akins
Justin Erenkrantz wrote: I'd be fine with it matching store_body's prototype. (Which is what you have.) -- justin Here's a patch that does this. -- Brian Akins Lead Systems Engineer CNN Internet Technologies diff -ru httpd-trunk.orig/modules/cache/mod_cache.c httpd-trunk.new2/modules/

Re: mod_cache recall_body

2005-08-18 Thread Justin Erenkrantz
--On August 18, 2005 9:55:57 AM -0400 Brian Akins <[EMAIL PROTECTED]> wrote: Why do we pass request_rec to recall_headers, but not to recall_body. We also always pass r->pool. How horrible would it be if the prototype was changed to: apr_status_t (*recall_body) (cache_handle_t *h, request_rec

mod_cache recall_body

2005-08-18 Thread Brian Akins
Why do we pass request_rec to recall_headers, but not to recall_body. We also always pass r->pool. How horrible would it be if the prototype was changed to: apr_status_t (*recall_body) (cache_handle_t *h, request_rec *r,apr_bucket_brigade *bb); I wanted to get r in recall_body so mod_disk_c