mod_deflate and no-gzip

2004-08-18 Thread Brian Akins
Shouldn't we still set Vary: Accept-Encoding if no-gzip is set? Example, if I use SetEnvIf to disallow gzip for some browsers, shouldn't we still tell proxies to vary on Accept-Encoding? mod_deflate will send the Vary if the client does not have a proper Accept-Encoding header, but not if we

Re: mod_deflate and no-gzip

2004-08-18 Thread Nick Kew
On Wed, 18 Aug 2004, Brian Akins wrote: Shouldn't we still set Vary: Accept-Encoding if no-gzip is set? Hmmm, makes sense. +1 Should we be looking at a wholesale backport from 2.1-head? There are a number of minor bugfixes, as well as the inflate output filter. -- Nick Kew

Re: mod_deflate and no-gzip

2004-08-18 Thread Joshua Slive
On Wed, 18 Aug 2004, Brian Akins wrote: Shouldn't we still set Vary: Accept-Encoding if no-gzip is set? Example, if I use SetEnvIf to disallow gzip for some browsers, shouldn't we still tell proxies to vary on Accept-Encoding? mod_deflate will send the Vary if the client does not have a

Re: mod_deflate and no-gzip

2004-08-18 Thread Andr Malo
* Nick Kew [EMAIL PROTECTED] wrote: On Wed, 18 Aug 2004, Brian Akins wrote: Shouldn't we still set Vary: Accept-Encoding if no-gzip is set? Hmmm, makes sense. +1 Nope. mod_deflate doesn't know whether it depends on the request (more than the URL). Location /foo SetEnv no-gzip