Re: mod_filter and adding to the Vary header in 2.2.x

2011-06-04 Thread Stefan Fritsch
On Wednesday 01 June 2011, Nick Kew wrote: > Do you see FilterProtocol as worth building on? > > I've been looking on it as a legacy thing that should be deprecated > in favour of filters declaring themselves with > ap_register_output_filter_protocol . That's part of the > half-baked-ness I mentio

Re: mod_filter and adding to the Vary header in 2.2.x

2011-06-01 Thread Nick Kew
On 1 Jun 2011, at 21:04, Stefan Fritsch wrote: >> If you want to tackle it, it would be a Good Idea to think through >> how it interacts with a wide selection of real-life filters. It >> looks unduly complex to derive from FilterProvider rules + filter >> properties, so I wonder if the least-bad

Re: mod_filter and adding to the Vary header in 2.2.x

2011-06-01 Thread Stefan Fritsch
On Wednesday 01 June 2011, Nick Kew wrote: > On 31 May 2011, at 22:19, Stefan Fritsch wrote: > > But there isn't any code in mod_filter to add Vary headers. > > The protocol stuff in mod_filter is somewhat half-baked. > Basically, so long as filters can get configured without reference > to mod_fi

Re: mod_filter and adding to the Vary header in 2.2.x

2011-05-31 Thread Nick Kew
On 31 May 2011, at 22:19, Stefan Fritsch wrote: > But there isn't any code in mod_filter to add Vary headers. The protocol stuff in mod_filter is somewhat half-baked. Basically, so long as filters can get configured without reference to mod_filter, they need to deal with protocol concerns themse

Re: mod_filter and adding to the Vary header in 2.2.x

2011-05-31 Thread Stefan Fritsch
On Tue, 31 May 2011, Graham Leggett wrote: On 31 May 2011, at 2:19 PM, Stefan Fritsch wrote: if I use mod_filter to configure mod_deflate like this: BrowserMatch ^Mozilla/4 no-gzip BrowserMatch "\bMSIE [7-9]" !no-gzip Header append Vary User-Agent env=!dont-vary FilterDeclare compress-respons

Re: mod_filter and adding to the Vary header in 2.2.x

2011-05-31 Thread Graham Leggett
On 31 May 2011, at 2:19 PM, Stefan Fritsch wrote: if I use mod_filter to configure mod_deflate like this: BrowserMatch ^Mozilla/4 no-gzip BrowserMatch "\bMSIE [7-9]" !no-gzip Header append Vary User-Agent env=!dont-vary FilterDeclare compress-response FilterProvider compress-response DEFLATE Co

mod_filter and adding to the Vary header in 2.2.x

2011-05-31 Thread Stefan Fritsch
Hi, if I use mod_filter to configure mod_deflate like this: BrowserMatch ^Mozilla/4 no-gzip BrowserMatch "\bMSIE [7-9]" !no-gzip Header append Vary User-Agent env=!dont-vary FilterDeclare compress-response FilterProvider compress-response DEFLATE Content-Type $text/ FilterProvider compress-respon