Re: mod_proxy/mod_proxy_balancer bug

2009-04-23 Thread Jim Jagielski
On Apr 22, 2009, at 5:16 AM, jean-frederic clere wrote: Rainer Jung wrote: On 20.04.2009 15:57, Jim Jagielski wrote: On Apr 17, 2009, at 4:28 PM, Rainer Jung wrote: The same type of balancing decision algorithm was part of mod_jk between 1.2.7 and 1.2.15. I always had problems to

Re: mod_proxy/mod_proxy_balancer bug

2009-04-23 Thread Jim Jagielski
On Apr 23, 2009, at 8:45 AM, Jim Jagielski wrote: +1... Maybe I'll branch off a 2.2-proxy branch as a sandbox to play around in... Then we can front-port to trunk and use the sandbox as the backport source :) Just in case people didn't see it, I've created a branch from 2.2.x as a place

Re: mod_proxy/mod_proxy_balancer bug

2009-04-22 Thread jean-frederic clere
Rainer Jung wrote: On 20.04.2009 15:57, Jim Jagielski wrote: On Apr 17, 2009, at 4:28 PM, Rainer Jung wrote: The same type of balancing decision algorithm was part of mod_jk between 1.2.7 and 1.2.15. I always had problems to understand, how it exactly behaves in case some workers are out of

Re: mod_proxy/mod_proxy_balancer bug

2009-04-21 Thread Rainer Jung
On 20.04.2009 15:57, Jim Jagielski wrote: On Apr 17, 2009, at 4:28 PM, Rainer Jung wrote: The same type of balancing decision algorithm was part of mod_jk between 1.2.7 and 1.2.15. I always had problems to understand, how it exactly behaves in case some workers are out of order. The

Re: mod_proxy/mod_proxy_balancer bug

2009-04-20 Thread Jim Jagielski
On Apr 17, 2009, at 4:28 PM, Rainer Jung wrote: The same type of balancing decision algorithm was part of mod_jk between 1.2.7 and 1.2.15. I always had problems to understand, how it exactly behaves in case some workers are out of order. The algorithm is interesting, but I found it very

Re: mod_proxy/mod_proxy_balancer bug

2009-04-17 Thread Rainer Jung
On 14.04.2009 23:23, Jess Holle wrote: Jess Holle wrote: Similarly, when retrying workers in various routines in mod_proxy_balancer.c those worker's lbstatus is incremented. If the retry fails, however, the lbstatus is never reset. This issue also leads to an lbstatus that increases without

Re: mod_proxy/mod_proxy_balancer bug

2009-04-17 Thread Jess Holle
Rainer Jung wrote: The same type of balancing decision algorithm was part of mod_jk between 1.2.7 and 1.2.15. I always had problems to understand, how it exactly behaves in case some workers are out of order. The algorithm is interesting, but I found it very hard to model its mathematics into

mod_proxy/mod_proxy_balancer bug

2009-04-14 Thread Jess Holle
proxy_handler() calls ap_proxy_pre_request() inside a do loop over balanced workers. This in turn calls proxy_balancer_pre_request() which does (*worker)-s-busy++. Correspondingly proxy_balancer_post_request() does: if (worker worker-s-busy) worker-s-busy--;

Re: mod_proxy/mod_proxy_balancer bug

2009-04-14 Thread Jess Holle
Jess Holle wrote: proxy_handler() calls ap_proxy_pre_request() inside a do loop over balanced workers. This in turn calls proxy_balancer_pre_request() which does (*worker)-s-busy++. Correspondingly proxy_balancer_post_request() does: if (worker worker-s-busy)