Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Jim Jagielski
> On Dec 15, 2017, at 7:06 AM, Jim Jagielski wrote: > > >> On Dec 13, 2017, at 2:49 PM, Ruediger Pluem wrote: >> >> >> >> On 12/13/2017 04:27 PM, Steffen wrote: >>> I know, for example: >>> >>> util_expr_scan.c >> >> At least this one includes

Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Steffen
Also the .dsp did not work here (Gregg ?) It is building when I add one of the following two in mod_proxy_uwsgi.c: it builds with: #define uint8_t unsigned __int8 or it builds when: #include "stdint.h" Attached stdint.h Do not know how to test. On Wednesday 13/12/2017 at 20:49,

Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Steffen
It is building when I add one of the following two in mod_proxy_uwsgi.c: it builds with: #define uint8_t unsigned __int8 or it builds when: #include "stdint.h" stdint.h attached. Attached stdint.h Do not know how to test. On Wednesday 13/12/2017 at 20:49, Ruediger Pluem wrote: On

Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Jim Jagielski
> On Dec 13, 2017, at 2:49 PM, Ruediger Pluem wrote: > > > > On 12/13/2017 04:27 PM, Steffen wrote: >> I know, for example: >> >> util_expr_scan.c > > At least this one includes inttypes.h which seems according to the comments > is only available on C99. > Should we

Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Jim Jagielski
Who is using C99?? > On Dec 13, 2017, at 2:07 PM, William A Rowe Jr wrote: > > C99 is promiscuous. > > I thought we were holding to C89 on the 2.4 branch? > > On Dec 13, 2017 09:23, "Jim Jagielski" > wrote: > We use uint8_t

Re: mod_proxy_uwsgi build errors

2017-12-13 Thread Ruediger Pluem
On 12/13/2017 04:27 PM, Steffen wrote: > I know, for example: > > util_expr_scan.c At least this one includes inttypes.h which seems according to the comments is only available on C99. Should we create an apr_uint8_t in apr and / or simply use apr_uint16_t in the uint8_t cases? >

Re: mod_proxy_uwsgi build errors

2017-12-13 Thread William A Rowe Jr
C99 is promiscuous. I thought we were holding to C89 on the 2.4 branch? On Dec 13, 2017 09:23, "Jim Jagielski" wrote: > We use uint8_t numerous places elsewhere. > > > On Dec 13, 2017, at 9:44 AM, Steffen wrote: > > > > > > @jim > > > > You adjusted

Re: mod_proxy_uwsgi build errors

2017-12-13 Thread Steffen
I know, for example: util_expr_scan.c mod_brotli.c h2_filter.c h2_proxy_session.c h2_proxy_util.c h2_session.c h2_stream.c h2_stream.h h2_util.c h2_util.h But there no errors, they building fine. On Wednesday 13/12/2017 at 16:23, Jim Jagielski wrote: We use uint8_t numerous places

Re: mod_proxy_uwsgi build errors

2017-12-13 Thread Jim Jagielski
We use uint8_t numerous places elsewhere. > On Dec 13, 2017, at 9:44 AM, Steffen wrote: > > > @jim > > You adjusted uint16_t > > Still errors: > > > mod_proxy_uwsgi.c(186): warning C4267: '=': conversion from 'size_t' to > 'apr_uint16_t', possible loss of data >

Re: mod_proxy_uwsgi build errors

2017-12-13 Thread Steffen
@jim You adjusted uint16_t Still errors: mod_proxy_uwsgi.c(186): warning C4267: '=': conversion from 'size_t' to 'apr_uint16_t', possible loss of data mod_proxy_uwsgi.c(187): error C2065: 'uint8_t': undeclared identifier mod_proxy_uwsgi.c(187): error C2064: term does not evaluate to a

mod_proxy_uwsgi build errors

2017-12-13 Thread Steffen
Trying to build on Win mod_proxy_uwsgi from trunk. Get the follwoing: mod_proxy_uwsgi.c(139): error C2065: 'uint16_t': undeclared identifier mod_proxy_uwsgi.c(139): error C2146: syntax error: missing ';' before identifier 'pktsize' mod_proxy_uwsgi.c(139): error C2065: 'pktsize': undeclared