Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-25 Thread Jim Jagielski
On Nov 24, 2013, at 7:18 PM, Jeff Trawick traw...@gmail.com wrote: On Sat, Nov 23, 2013 at 5:39 PM, Yann Ylavic ylavic@gmail.com wrote: Couldn't ap_queue_info_try_get_idler() and the event_pre_config() check use : prev_idlers = apr_atomic_add32((apr_uint32_t *)(queue_info-idlers),

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-25 Thread Jeff Trawick
On Mon, Nov 25, 2013 at 1:27 PM, Jim Jagielski j...@jagunet.com wrote: On Nov 24, 2013, at 7:18 PM, Jeff Trawick traw...@gmail.com wrote: On Sat, Nov 23, 2013 at 5:39 PM, Yann Ylavic ylavic@gmail.com wrote: Couldn't ap_queue_info_try_get_idler() and the event_pre_config() check use :

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-24 Thread Rainer Jung
On 24.11.2013 01:03, Eric Covener wrote: I'm curious what other scenarios will fail though. I can try Sun Studio on Solaris 10 x86_64 (32-bit and 64-bit builds) soon. But Sun Studio on SPARC presumably uses different explicit code in APR and I don't have access to that. I will try to get

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-24 Thread Eric Covener
On Sun, Nov 24, 2013 at 5:24 AM, Rainer Jung rainer.j...@kippdata.de wrote: On 24.11.2013 01:03, Eric Covener wrote: I'm curious what other scenarios will fail though. I can try Sun Studio on Solaris 10 x86_64 (32-bit and 64-bit builds) soon. But Sun Studio on SPARC presumably uses different

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-24 Thread Jim Jagielski
On Nov 23, 2013, at 5:39 PM, Yann Ylavic ylavic@gmail.com wrote: Or maybe queue_info-idlers be declared uint32_t and negatives computed relative to 2^31 ? What I was thinking was simply doing an offset... There is no way we would ever use a full 32bits, signed or not, so making the

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-24 Thread Jeff Trawick
On Sun, Nov 24, 2013 at 7:33 AM, Eric Covener cove...@gmail.com wrote: On Sun, Nov 24, 2013 at 5:24 AM, Rainer Jung rainer.j...@kippdata.de wrote: On 24.11.2013 01:03, Eric Covener wrote: I'm curious what other scenarios will fail though. I can try Sun Studio on Solaris 10 x86_64

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-24 Thread Jeff Trawick
On Sat, Nov 23, 2013 at 5:39 PM, Yann Ylavic ylavic@gmail.com wrote: Couldn't ap_queue_info_try_get_idler() and the event_pre_config() check use : prev_idlers = apr_atomic_add32((apr_uint32_t *)(queue_info-idlers), -1); like ap_queue_info_wait_for_idler() does ? I think that's

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-23 Thread Rainer Jung
On 22.11.2013 23:03, Jim Jagielski wrote: Anyone ever try OpenPA? https://trac.mcs.anl.gov/projects/openpa/ It's under MIT, fwiw. Haven't tried it but the README http://git.mcs.anl.gov/radix/openpa.git/blob_plain/HEAD:/README indicates only platform support based on gcc plus

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-23 Thread Jeff Trawick
On Sat, Nov 23, 2013 at 8:04 AM, Rainer Jung rainer.j...@kippdata.dewrote: On 22.11.2013 23:03, Jim Jagielski wrote: Anyone ever try OpenPA? https://trac.mcs.anl.gov/projects/openpa/ It's under MIT, fwiw. Haven't tried it but the README

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-23 Thread Rainer Jung
On 23.11.2013 14:15, Jeff Trawick wrote: On Sat, Nov 23, 2013 at 8:04 AM, Rainer Jung rainer.j...@kippdata.de mailto:rainer.j...@kippdata.de wrote: On 22.11.2013 23:03, Jim Jagielski wrote: Anyone ever try OpenPA? https://trac.mcs.anl.gov/projects/openpa/

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-23 Thread Jim Jagielski
I'm just curious why people never saw this on trunk... That code path is almost exactly a year old. No one has hit this in 12 months?? On Nov 23, 2013, at 12:45 PM, Rainer Jung rainer.j...@kippdata.de wrote: On 23.11.2013 14:15, Jeff Trawick wrote: On Sat, Nov 23, 2013 at 8:04 AM, Rainer Jung

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-23 Thread Jeff Trawick
On Sat, Nov 23, 2013 at 3:45 PM, Jim Jagielski j...@jagunet.com wrote: I'm just curious why people never saw this on trunk... That code path is almost exactly a year old. No one has hit this in 12 months?? l rarely try trunk except on * Windows, which uses a system mechanism regardless of

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-23 Thread Yann Ylavic
Couldn't ap_queue_info_try_get_idler() and the event_pre_config() check use : prev_idlers = apr_atomic_add32((apr_uint32_t *)(queue_info-idlers), -1); like ap_queue_info_wait_for_idler() does ? Or maybe queue_info-idlers be declared uint32_t and negatives computed relative to 2^31 ?

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-23 Thread Eric Covener
On Sat, Nov 23, 2013 at 3:56 PM, Jeff Trawick traw...@gmail.com wrote: On Sat, Nov 23, 2013 at 3:45 PM, Jim Jagielski j...@jagunet.com wrote: I'm just curious why people never saw this on trunk... That code path is almost exactly a year old. No one has hit this in 12 months?? l rarely try

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-23 Thread Eric Covener
I'm curious what other scenarios will fail though. I can try Sun Studio on Solaris 10 x86_64 (32-bit and 64-bit builds) soon. But Sun Studio on SPARC presumably uses different explicit code in APR and I don't have access to that. I will try to get that one up and running on 2.4.7. No

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Sat, Nov 17, 2012 at 6:00 AM, Ruediger Pluem rpl...@apache.org wrote: j...@apache.org wrote: Author: jim Date: Fri Nov 16 16:49:31 2012 New Revision: 1410459 URL: http://svn.apache.org/viewvc?rev=1410459view=rev Log: fdq expects a certain behavior from atomics... ensure that

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
On Nov 22, 2013, at 2:22 PM, Jeff Trawick traw...@gmail.com wrote: On Sat, Nov 17, 2012 at 6:00 AM, Ruediger Pluem rpl...@apache.org wrote: j...@apache.org wrote: +i = apr_atomic_dec32(foo); +if (i = 0) { Why can we expect i 0? apr_atomic_dec32 returns 0 if the dec

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 2:39 PM, Jim Jagielski j...@jagunet.com wrote: On Nov 22, 2013, at 2:22 PM, Jeff Trawick traw...@gmail.com wrote: On Sat, Nov 17, 2012 at 6:00 AM, Ruediger Pluem rpl...@apache.org wrote: j...@apache.org wrote: +i = apr_atomic_dec32(foo); +

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
Note, the only think changed in event now (via https://svn.apache.org/viewvc?view=revisionrevision=1542560) is that event *checks* that atomics work as required for event... if the check fails, it means that event has been broken on that system, assuming it ever hit blocked idlers, for a *long*

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note, the only think changed in event now (via https://svn.apache.org/viewvc?view=revisionrevision=1542560) is that event *checks* that atomics work as required for event... if the check fails, it means that event has

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
On Nov 22, 2013, at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note, the only think changed in event now (via https://svn.apache.org/viewvc?view=revisionrevision=1542560) is that event *checks* that atomics work as

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note, the only think changed in event now (via https://svn.apache.org/viewvc?view=revisionrevision=1542560) is that event *checks* that atomics work

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 3:40 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note, the only think changed in event now (via

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 3:57 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:40 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note,

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
The thing is is not only do we worry about the return code but also that the values we dec32 and inc32 also behave as signed ints. Note below we worry also that queue_info-idlers itself is signed, and can be 0 : apr_status_t ap_queue_info_try_get_idler(fd_queue_info_t * queue_info) { int

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
Anyone ever try OpenPA? https://trac.mcs.anl.gov/projects/openpa/ It's under MIT, fwiw.

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 4:27 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:57 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:40 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 4:32 PM, Jim Jagielski j...@jagunet.com wrote: The thing is is not only do we worry about the return code but also that the values we dec32 and inc32 also behave as signed ints. Note below we worry also that queue_info-idlers itself is signed, and can be 0 : Okay

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2012-11-17 Thread Ruediger Pluem
j...@apache.org wrote: Author: jim Date: Fri Nov 16 16:49:31 2012 New Revision: 1410459 URL: http://svn.apache.org/viewvc?rev=1410459view=rev Log: fdq expects a certain behavior from atomics... ensure that the event mpms check this. Modified: