Re: svn commit: r1583175 - /httpd/httpd/trunk/modules/mappers/mod_alias.c

2014-05-05 Thread Eric Covener
I don't want to churn in SVN too much, does anyone have an issue with dropping the context info stuff for the regex case completely? On Mon, Mar 31, 2014 at 1:49 PM, Eric Covener cove...@gmail.com wrote: So you suggest to remove ap_set_context_info() from the AliasMatch handling? Yes, I just

Re: svn commit: r1583175 - /httpd/httpd/trunk/modules/mappers/mod_alias.c

2014-05-05 Thread Jim Jagielski
!me. On May 5, 2014, at 9:34 AM, Eric Covener cove...@gmail.com wrote: I don't want to churn in SVN too much, does anyone have an issue with dropping the context info stuff for the regex case completely? On Mon, Mar 31, 2014 at 1:49 PM, Eric Covener cove...@gmail.com wrote: So you suggest

Re: svn commit: r1583175 - /httpd/httpd/trunk/modules/mappers/mod_alias.c

2014-05-05 Thread Rainer Jung
On 05.05.2014 15:34, Eric Covener wrote: I don't want to churn in SVN too much, does anyone have an issue with dropping the context info stuff for the regex case completely? Thanks for asking again and agreed here. Regards, Rainer On Mon, Mar 31, 2014 at 1:49 PM, Eric Covener

Re: svn commit: r1583175 - /httpd/httpd/trunk/modules/mappers/mod_alias.c

2014-03-31 Thread Rainer Jung
On 30.03.2014 22:52, Eric Covener wrote: On Sun, Mar 30, 2014 at 4:13 PM, Rainer Jung rainer.j...@kippdata.de wrote: AFAICT { In as much that it was ever useful, this breaks people relying on the context info for aliasmatches structured the way this code was originally biased to expecting:

Re: svn commit: r1583175 - /httpd/httpd/trunk/modules/mappers/mod_alias.c

2014-03-31 Thread Eric Covener
So you suggest to remove ap_set_context_info() from the AliasMatch handling? Yes, I just don't think we can pick appropriate values safely.

Re: svn commit: r1583175 - /httpd/httpd/trunk/modules/mappers/mod_alias.c

2014-03-30 Thread Eric Covener
On Sun, Mar 30, 2014 at 2:20 PM, rj...@apache.org wrote: Author: rjung Date: Sun Mar 30 18:20:09 2014 New Revision: 1583175 URL: http://svn.apache.org/r1583175 Log: Fix segfault in mod_alias introduced in r1132494. AliasMatch does not append unmatched parts of the original URI to the

Re: svn commit: r1583175 - /httpd/httpd/trunk/modules/mappers/mod_alias.c

2014-03-30 Thread Rainer Jung
On 30.03.2014 20:29, Eric Covener wrote: On Sun, Mar 30, 2014 at 2:20 PM, rj...@apache.org wrote: Author: rjung Date: Sun Mar 30 18:20:09 2014 New Revision: 1583175 URL: http://svn.apache.org/r1583175 Log: Fix segfault in mod_alias introduced in r1132494. AliasMatch does not append

Re: svn commit: r1583175 - /httpd/httpd/trunk/modules/mappers/mod_alias.c

2014-03-30 Thread Eric Covener
On Sun, Mar 30, 2014 at 4:13 PM, Rainer Jung rainer.j...@kippdata.de wrote: What would have been the expected prefix value in this case? Sorry, got myself mixed up with regm[0], it's the entire match not a capture. Once you have a trailing wildcard like that, this code will think the entire