Re: svn commit: r1591012 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/aaa/mod_authnz_ldap.c

2023-11-18 Thread Graham Leggett via dev
On 18 Nov 2023, at 17:14, Yann Ylavic wrote: > Oh it seems that the callers want the "filtbuf" to be \0 terminated > (even in case of error), so this v2 probably.. Looking at this now. Seems to be some differences between trunk and v2.4, seeing how they can be aligned to make this easier.

Re: svn commit: r1591012 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/aaa/mod_authnz_ldap.c

2023-11-18 Thread Yann Ylavic
On Sat, Nov 18, 2023 at 5:59 PM Yann Ylavic wrote: > > All in all, I'd rewrite this function like in the attached patch (not > even compile tested, just to show what I'm talking about..). Oh it seems that the callers want the "filtbuf" to be \0 terminated (even in case of error), so this v2

Re: svn commit: r1591012 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/aaa/mod_authnz_ldap.c

2023-11-18 Thread Yann Ylavic
On Tue, Apr 29, 2014 at 6:06 PM wrote: > > Author: minfrin > Date: Tue Apr 29 16:05:56 2014 > New Revision: 1591012 > > URL: http://svn.apache.org/r1591012 > Log: > mod_authnz_ldap: Fail explicitly when the filter is too long. Remove > unnecessary apr_pstrdup() and strlen(). It seems that the