Re: svn commit: r1875947 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_core.c modules/http/http_request.c server/core.c server/core_filters.c server/request.c server/util_filter.c

A naming discussion! \o/ AP_BUCKET_IS_QUANTUM ~icing > Am 03.04.2020 um 21:27 schrieb Marion & Christophe JAILLET > : > > > Le 03/04/2020 à 20:41, Ruediger Pluem a écrit : >> I am undecided. I am not entirely convinced that it is a good name although >> all you said above is true, but on

Re: svn commit: r1875947 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_core.c modules/http/http_request.c server/core.c server/core_filters.c server/request.c server/util_filter.c

Le 03/04/2020 à 20:41, Ruediger Pluem a écrit : I am undecided. I am not entirely convinced that it is a good name although all you said above is true, but on the other hand it is not that bad that I see a need to spend a lot of further time on this name searching topic :-). So +0. What do

Re: svn commit: r1875947 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_core.c modules/http/http_request.c server/core.c server/core_filters.c server/request.c server/util_filter.c

On 4/3/20 6:39 PM, Yann Ylavic wrote: > On Thu, Apr 2, 2020 at 11:28 AM Ruediger Pluem wrote: >> >> So how about >> >> #define AP_BUCKET_HAS_UNKNOWN_LENGTH(e) ((e)->length == (apr_size_t)-1) > > Still quite mouthful.. > > What about? : > /** > * Determine if a bucket is opaque, i.e. of

Re: svn commit: r1875947 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_core.c modules/http/http_request.c server/core.c server/core_filters.c server/request.c server/util_filter.c

On Thu, Apr 2, 2020 at 11:28 AM Ruediger Pluem wrote: > > So how about > > #define AP_BUCKET_HAS_UNKNOWN_LENGTH(e) ((e)->length == (apr_size_t)-1) Still quite mouthful.. What about? : /** * Determine if a bucket is opaque, i.e. of unknown data length and type * @param e The bucket to inspect

Re: svn commit: r1875947 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_core.c modules/http/http_request.c server/core.c server/core_filters.c server/request.c server/util_filter.c

On 4/2/20 11:14 AM, Joe Orton wrote: > On Thu, Apr 02, 2020 at 10:58:21AM +0200, Yann Ylavic wrote: >> On Thu, Apr 2, 2020 at 6:39 AM Ruediger Pluem wrote: >>> +#define AP_BUCKET_IS_MORPHING(e)((e)->length == (apr_size_t)-1) >>> >>> Nitpick: After having a second thought on the whole

Re: svn commit: r1875947 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_core.c modules/http/http_request.c server/core.c server/core_filters.c server/request.c server/util_filter.c

On Thu, Apr 02, 2020 at 10:58:21AM +0200, Yann Ylavic wrote: > On Thu, Apr 2, 2020 at 6:39 AM Ruediger Pluem wrote: > > > > > +#define AP_BUCKET_IS_MORPHING(e)((e)->length == (apr_size_t)-1) > > > > Nitpick: After having a second thought on the whole thing, I think the > > above name is

Re: svn commit: r1875947 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_core.c modules/http/http_request.c server/core.c server/core_filters.c server/request.c server/util_filter.c

On Thu, Apr 2, 2020 at 6:39 AM Ruediger Pluem wrote: > > > +#define AP_BUCKET_IS_MORPHING(e)((e)->length == (apr_size_t)-1) > > Nitpick: After having a second thought on the whole thing, I think the above > name is misleading to some extend. If MMAP is enabled > a file bucket is also a

Re: svn commit: r1875947 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_core.c modules/http/http_request.c server/core.c server/core_filters.c server/request.c server/util_filter.c

On 3/31/20 6:22 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Mar 31 16:22:53 2020 > New Revision: 1875947 > > URL: http://svn.apache.org/viewvc?rev=1875947=rev > Log: > core: handle morphing buckets setaside/reinstate and kill request core filter. > > The purpose of