Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c

2006-07-20 Thread Joe Orton
On Thu, Jul 20, 2006 at 11:01:08AM -, [EMAIL PROTECTED] wrote: Author: rpluem Date: Thu Jul 20 04:01:07 2006 New Revision: 423886 URL: http://svn.apache.org/viewvc?rev=423886view=rev Log: * Check for symbolic links of the target file in the optimized case that we had already done

Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c

2006-07-20 Thread Ruediger Pluem
On 20.07.2006 14:04, Joe Orton wrote: I think it's a *very* bad idea to imply that SymLinksIfOwnerMatch is a security feature. If you did want to call this a security feature then you also need to fix the big fat race condition inbetween all those nice careful stat() calls and the

Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c

2006-07-20 Thread Justin Erenkrantz
On 7/20/06, Ruediger Pluem [EMAIL PROTECTED] wrote: I guess I can't change the log entry anymore. All I can do is adjust the CHANGES entry. Would that address your concerns? svn propchange --revprop -r423886 svn:log https://svn.apache.org/repos/asf/ HTH. -- justin

Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c

2006-07-20 Thread Garrett Rooney
On 7/20/06, Ruediger Pluem [EMAIL PROTECTED] wrote: I guess I can't change the log entry anymore. All I can do is adjust the CHANGES entry. Would that address your concerns? Actually you can change the log entry. Try 'svn pedit --revprop -r REVISION' -garrett

Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c

2006-07-20 Thread Ruediger Pluem
On 07/20/2006 06:11 PM, Garrett Rooney wrote: Actually you can change the log entry. Try 'svn pedit --revprop -r REVISION' -garrett Thanks for your help Garrett and Justin. I mixed both of your proposals and it worked just fine :-) Regards RĂ¼diger

Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c

2006-07-20 Thread Ruediger Pluem
On 07/20/2006 02:04 PM, Joe Orton wrote: I think it's a *very* bad idea to imply that SymLinksIfOwnerMatch is a security feature. If you did want to call this a security feature then you also need to fix the big fat race condition inbetween all those nice careful stat() calls and