subject:"svn commit\: r583466 \- in \/httpd\/httpd\/trunk\: include\/ap_mmn.h modules\/proxy\/mod_proxy.h modules\/proxy\/mod_proxy_http.c modules\/proxy\/proxy_util.c"

Re: svn commit: r583466 - in /httpd/httpd/trunk: include/ap_mmn.h modules/proxy/mod_proxy.h modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c

2007-10-10 Thread Roy T. Fielding

The whole idea behind this routine is just wrong. That set of characters is insufficient (RFC 3986) and, in any case, a proxy is not responsible for checking valid characters in a URI. Both the original and this new function should be deleted. Roy On Oct 10, 2007, at 6:16 AM, [EMAIL

Re: svn commit: r583466 - in /httpd/httpd/trunk: include/ap_mmn.h modules/proxy/mod_proxy.h modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c

2007-10-10 Thread Jim Jagielski

Good point... forward proxies should just pass through as is, good or bad. Will revert the patch and fix Nick's impl tomorrow when I get back in the office. On Wed, Oct 10, 2007 at 12:39:56PM -0700, Roy T. Fielding wrote: The whole idea behind this routine is just wrong. That set of characters