Re: mod_proxy: unwieldy unix socket implementation.

2014-03-19 Thread Jan Kaluža
On 03/19/2014 06:15 AM, Andreas B. wrote: Hello, I saw the new unix sockets for mod_proxy in 2.4.9 and I am wondering why there has to be a special url format. Wouldn't it be possible to supply the socket path as a proxy parameter? I have something like this in mind: Proxy

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-03-19 Thread Jan Kaluža
On 03/18/2014 02:46 PM, Yann Ylavic wrote: On Tue, Mar 18, 2014 at 2:38 PM, Yann Ylavic ylavic@gmail.com wrote: Wouldn't it be possible to define wildcard workers when the URL is known to be a regexp substitution? For these workers' URLs, the dollars (plus the following digit) could be

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-03-19 Thread Jan Kaluža
On 03/19/2014 09:59 AM, Jan Kaluža wrote: On 03/18/2014 02:46 PM, Yann Ylavic wrote: On Tue, Mar 18, 2014 at 2:38 PM, Yann Ylavic ylavic@gmail.com wrote: Wouldn't it be possible to define wildcard workers when the URL is known to be a regexp substitution? For these workers' URLs, the

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-03-19 Thread Jan Kaluža
On 03/19/2014 10:13 AM, Jan Kaluža wrote: On 03/19/2014 09:59 AM, Jan Kaluža wrote: On 03/18/2014 02:46 PM, Yann Ylavic wrote: On Tue, Mar 18, 2014 at 2:38 PM, Yann Ylavic ylavic@gmail.com wrote: Wouldn't it be possible to define wildcard workers when the URL is known to be a regexp

[PATCH RESEND 55178 0/2] mod_authn_ldap: SASL support

2014-03-19 Thread Lubomir Rintel
Hi, I've submitted a patch set [1] adding SASL support to mod_authn_ldap a while ago, but the ticket got no feedback. I'd be very thankful for a review and merge. [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=55178 Chained to this message are the patches. Thank you! Lubo

[PATCH RESEND 2/2] mod_authn_ldap: Allow specifying SASL interaction

2014-03-19 Thread Lubomir Rintel
From: Lubomir Rintel lubo.rin...@gooddata.com --- docs/manual/mod/mod_authnz_ldap.xml | 28 +++ docs/manual/style/scripts/prettify.js | 2 +- include/util_ldap.h | 4 ++- modules/aaa/mod_authnz_ldap.c | 16 +++-- modules/ldap/util_ldap.c

[PATCH RESEND 1/2] mod_authn_ldap: Allow authentication with SASL

2014-03-19 Thread Lubomir Rintel
From: Lubomir Rintel lubo.rin...@gooddata.com --- docs/manual/mod/mod_authnz_ldap.xml | 34 - docs/manual/style/scripts/prettify.js | 2 +- include/util_ldap.h | 5 +- modules/aaa/mod_authnz_ldap.c | 14 +- modules/ldap/util_ldap.c | 94

[PATCH RESEND 1/4] mod_proxy: Rename dirconn_entry to exclude_entry

2014-03-19 Thread Lubomir Rintel
From: Lubomir Rintel lubo.rin...@gooddata.com Currently they are used for NoProxy, but could be reusable to ProxyBlock. Rename them to something more generic. --- modules/proxy/mod_proxy.c | 8 modules/proxy/mod_proxy.h | 4 ++-- modules/proxy/proxy_util.c | 24

[PATCH RESEND 3/4] mod_proxy: Split the NoProxy parameter parsing away

2014-03-19 Thread Lubomir Rintel
From: Lubomir Rintel lubo.rin...@gooddata.com It is nice and could be reused by ProxyBlock. --- modules/proxy/mod_proxy.c | 98 +-- 1 file changed, 53 insertions(+), 45 deletions(-) diff --git a/modules/proxy/mod_proxy.c b/modules/proxy/mod_proxy.c

[PATCH RESEND 56152 0/4] mod_proxy: Add support for network addresses to NoProxy

2014-03-19 Thread Lubomir Rintel
Hi, I opened a ticket [1] with the patches (chained to this message), but got virtually no responsem, therefore I assume it might be a better idea to discuss them in a list. [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=56152 I'd very thankful for a review and evenutal merge. The

[PATCH RESEND 4/4] mod_proxy: Share NoProxy parameter parsing and evaluation with ProxyBlock

2014-03-19 Thread Lubomir Rintel
From: Lubomir Rintel lubo.rin...@gooddata.com They do the same task now, so we can remove some duplicate code. They do the same thing except that ProxyBlock does certain things better -- they support masked network addresses, thus we can now block subnets. --- docs/manual/mod/mod_proxy.xml | 14

[PATCH RESEND 2/4] mod_proxy: Match resolved addresses for NoProxy too

2014-03-19 Thread Lubomir Rintel
From: Lubomir Rintel lubo.rin...@gooddata.com We resolve the names using the configuration parsing, thus we already have the addresses. It could be redundant for NoProxy, but the same code could be used with ProxyBlock if it did this. --- modules/proxy/proxy_util.c | 8 1 file changed,

Re: mod_proxy: unwieldy unix socket implementation.

2014-03-19 Thread Jim Jagielski
On Mar 19, 2014, at 1:15 AM, Andreas B. regis...@progandy.de wrote: Hello, I saw the new unix sockets for mod_proxy in 2.4.9 and I am wondering why there has to be a special url format. Wouldn't it be possible to supply the socket path as a proxy parameter? It would be. We chose

Re: svn commit: r1554300 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/ap_regex.h include/http_core.h modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h server/core.c server/request.c ser

2014-03-19 Thread Jim Jagielski
As I understand it, we require PCRE_DUPNAMES functionality, right? So I think we need to check for it at configure/build time and bail if it isn't available. The configure part is done in http://svn.apache.org/r1579259

RE: svn commit: r1554300 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/ap_regex.h include/http_core.h modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h server/core.c server/request.c ser

2014-03-19 Thread Plüm , Rüdiger , Vodafone Group
-Original Message- From: Jim Jagielski Sent: Mittwoch, 19. März 2014 16:37 To: httpd Subject: Re: svn commit: r1554300 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/ap_regex.h include/http_core.h modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h server/core.c

Re: svn commit: r1554300 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/ap_regex.h include/http_core.h modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h server/core.c server/request.c ser

2014-03-19 Thread Jim Jagielski
As noted, from how I understand it, currently we allow it to build BUT the behavior is not as expected or designed, since the expected behavior *requires* PCRE_DUPNAMES. If we require PCRE_DUPNAMES then we require it, right? On Mar 19, 2014, at 12:26 PM, Plüm, Rüdiger, Vodafone Group

[PATCH] mod_proxy_html deletes wrong data from HTML when meta http-equiv tag specifies Content-Type behind other meta http-equiv tag

2014-03-19 Thread Micha Lenk
Hi Apache developers, over the time I've accumulated some patches for mod_proxy_html which I would like to get reviewed, and get applied in SVN (best both, trunk and then backported to 2.4). This is something that I feel to owe the Apache httpd community. So, lets first start with a bug

[PATCH] mod_proxy_html sometimes adds random characters to HTML pages smaller than 4 bytes

2014-03-19 Thread Micha Lenk
Hi Apache developers, next is a bug that causes mod_proxy_html to add some random characters (+html code) to HTML pages, if the document is smaller than 4 bytes. (Thomas, Ewald, this is issue #18378 in our Mantis). It looks like the output is from some kind of uninitialized memory. The added

Re: svn commit: r1554300 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/ap_regex.h include/http_core.h modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h server/core.c server/request.c ser

2014-03-19 Thread Jim Jagielski
Just looking for verification here ;) Thx! On Mar 19, 2014, at 12:46 PM, Jim Jagielski j...@jagunet.com wrote: As noted, from how I understand it, currently we allow it to build BUT the behavior is not as expected or designed, since the expected behavior *requires* PCRE_DUPNAMES. If we

[PATCH] mod_proxy_html removes the !doctype tag and breaks XHTML documents

2014-03-19 Thread Micha Lenk
Hi Apache developers, the next patch fixes the behavior of mod_proxy_html to remove any !doctype tags from the beginning of HTML and XHTML documents. (Thomas, Ewald, this is issue #19803 in our Mantis). This !doctype tag is needed by some browsers to correctly render XHTML documents.

Re: [PATCH] mod_proxy_html sometimes adds random characters to HTML pages smaller than 4 bytes

2014-03-19 Thread Jim Jagielski
It's always best, imo, to follow-up with a bugzilla entry with description and patch. Thx!! On Mar 19, 2014, at 3:58 PM, Micha Lenk mi...@lenk.info wrote: Hi Apache developers, next is a bug that causes mod_proxy_html to add some random characters (+html code) to HTML pages, if the

[PATCH ASF bugzilla #56284] Extend mod_proxy_html to rewrite URLs in CSS documents too

2014-03-19 Thread Micha Lenk
Hi Apache developers, next is a feature that extends mod_proxy_html to rewrite URLs in CSS documents too. This is done by applying the configured regex and string replacements for the content of HTML tags also on whole CSS documents, i.e. documents with Content-Type: text/css. The attached

Re: [PATCH] mod_proxy_html removes the !doctype tag and breaks XHTML documents

2014-03-19 Thread Micha Lenk
Hi all, just for the records: I've just filed this in the ASF bugzilla as issue #56285. Regards, Micha

Re: [PATCH] mod_proxy_html deletes wrong data from HTML when meta http-equiv tag specifies Content-Type behind other meta http-equiv tag

2014-03-19 Thread Micha Lenk
Hi, Just for the records, I've just filed this issue in ASF bugzilla as issue #56286. Regards, Micha On 19.03.2014 20:40, Micha Lenk wrote: Hi Apache developers, over the time I've accumulated some patches for mod_proxy_html which I would like to get reviewed, and get applied in SVN (best

Re: [PATCH] mod_proxy_html deletes wrong data from HTML when meta http-equiv tag specifies Content-Type behind other meta http-equiv tag

2014-03-19 Thread Micha Lenk
Hi again, Err, #56287 that is. Regards, Micha On 19.03.2014 22:05, Micha Lenk wrote: Just for the records, I've just filed this issue in ASF bugzilla as issue #56286.

Re: [PATCH] mod_proxy_html sometimes adds random characters to HTML pages smaller than 4 bytes

2014-03-19 Thread Micha Lenk
Hi, On 19.03.2014 21:19, Jim Jagielski wrote: It's always best, imo, to follow-up with a bugzilla entry with description and patch. Ok, this issue is now filed in ASF bugzilla as #56286. Regards, Micha

[PATCH ASF bugzilla #56288] mod_proxy_html could rewrite URLs in HTML style attributes too

2014-03-19 Thread Micha Lenk
Hi Apache developers, In HTML you can have div tags that have a background image by providing a style attribute. E.g. this can be done by something fancy like this: div style=background:url(http://www.example.com/fancy-background.png) right 0px no-repeat; height:325px; Currently

[PATCH ASF bugzilla #56289] Buffer overflow in mod_proxy_html's string replacement can cause a segfault

2014-03-19 Thread Micha Lenk
Hi developers, The attached patch fixes a buffer overflow in at least one of the six string replacement implementations in mod_proxy_html. Unfortunately I don't remember anymore how to reproduce the issue properly, but I know that some long time ago I fixed a segfault with this patch. The