Re: svn commit: r1774010 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/ext_filter.t

2016-12-15 Thread William A Rowe Jr
On Wed, Dec 14, 2016 at 11:30 PM, William A Rowe Jr wrote: > On Wed, Dec 14, 2016 at 2:51 AM, Joe Orton wrote: > >> >> I adjusted the test case to cope with a sed which adds a trailing >> newline now, does that pass with OS X sed? I'm yet to work out why the >> test cases passes in trunk and fa

Re: svn commit: r1774010 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/ext_filter.t

2016-12-15 Thread William A Rowe Jr
On Wed, Dec 14, 2016 at 11:30 PM, William A Rowe Jr wrote: > On Wed, Dec 14, 2016 at 2:51 AM, Joe Orton wrote: > >> >> I adjusted the test case to cope with a sed which adds a trailing >> newline now, does that pass with OS X sed? I'm yet to work out why the >> test cases passes in trunk and fa

Re: Making test framework and trunk approachable (was: PCRE 10 and puzzling edge cases)

2016-12-15 Thread Petr Pisar
On Mon, Dec 12, 2016 at 01:03:23PM -0600, William A Rowe Jr wrote: > System APR does require the -devel package. That RHEL package aught to > install the .m4 logic required by httpd, but it is on us to find that in a > conventional place. > I think this should be handled in the buildconf script. T

AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-15 Thread Plüm , Rüdiger , Vodafone Group
> -Ursprüngliche Nachricht- > Von: Yann Ylavic [mailto:ylavic@gmail.com] > Gesendet: Mittwoch, 14. Dezember 2016 19:58 > An: httpd-dev > Betreff: Re: svn commit: r1773865 - > /httpd/httpd/trunk/modules/http/http_filters.c > > On Wed, Dec 14, 2016 at 9:45 AM, Plüm, Rüdiger, Vodafone

Re: svn commit: r1774010 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/ext_filter.t

2016-12-15 Thread Joe Orton
On Thu, Dec 15, 2016 at 02:05:32AM -0600, William A Rowe Jr wrote: > Joe, did you forget an svn add? I see no ext_filter/ subdirectory on trunk; > > https://svn.apache.org/repos/asf/httpd/test/framework/trunk/t/htdocs/modules/filter/ Oops :( Added now, sorry guys.

Re: AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-15 Thread Luca Toscano
2016-12-14 18:53 GMT+01:00 Jacob Champion : > On 12/14/2016 09:33 AM, Jacob Champion wrote: > >> The current public filter documentation at [1] (which is old, but still >> the only overall documentation I'm aware of) says >> > > Forgot the link, sorry. > > [1] https://httpd.apache.org/docs/trunk/d

Re: T&R of 2.4.24

2016-12-15 Thread Jim Jagielski
From what I can see, there are no show-stoppers and all my tests show no regressions... Let's shoot for a T&R this (east coast) evening... how does that sound? > On Dec 14, 2016, at 7:56 AM, Jim Jagielski wrote: > > Looking at a T&R of 2.4.24 either the 15th or 16th...

Re: T&R of 2.4.24

2016-12-15 Thread Eric Covener
On Thu, Dec 15, 2016 at 10:13 AM, Jim Jagielski wrote: > From what I can see, there are no show-stoppers and > all my tests show no regressions... > > Let's shoot for a T&R this (east coast) evening... how does > that sound? +1 & thanks -- Eric Covener cove...@gmail.com

Re: T&R of 2.4.24

2016-12-15 Thread Stefan Eissing
+1 and *many* thanks! > Am 15.12.2016 um 16:13 schrieb Jim Jagielski : > > From what I can see, there are no show-stoppers and > all my tests show no regressions... > > Let's shoot for a T&R this (east coast) evening... how does > that sound? > >> On Dec 14, 2016, at 7:56 AM, Jim Jagielski wro

Re: svn commit: r1774010 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/ext_filter.t

2016-12-15 Thread William A Rowe Jr
On Thu, Dec 15, 2016 at 5:21 AM, Joe Orton wrote: > On Thu, Dec 15, 2016 at 02:05:32AM -0600, William A Rowe Jr wrote: > > Joe, did you forget an svn add? I see no ext_filter/ subdirectory on > trunk; > > > > https://svn.apache.org/repos/asf/httpd/test/framework/ > trunk/t/htdocs/modules/filter/

Re: svn commit: r1738464 - /httpd/httpd/trunk/server/mpm/event/event.c

2016-12-15 Thread Eric Covener
I have been looking at this area a little bit from the perspective of killing the keepalive conns as early as possible during graceful process exit. This might have had a bad interaction with the event wakeup patch here. Now we can sit in poll() for significant time after graceful shutdown is sig

Re: T&R of 2.4.24

2016-12-15 Thread Eric Covener
On Thu, Dec 15, 2016 at 10:16 AM, Eric Covener wrote: > On Thu, Dec 15, 2016 at 10:13 AM, Jim Jagielski wrote: >> From what I can see, there are no show-stoppers and >> all my tests show no regressions... >> >> Let's shoot for a T&R this (east coast) evening... how does >> that sound? > > > +1 &

Re: T&R of 2.4.24

2016-12-15 Thread Ruediger Pluem
On 12/15/2016 08:09 PM, Eric Covener wrote: > On Thu, Dec 15, 2016 at 10:16 AM, Eric Covener wrote: >> On Thu, Dec 15, 2016 at 10:13 AM, Jim Jagielski wrote: >>> From what I can see, there are no show-stoppers and >>> all my tests show no regressions... >>> >>> Let's shoot for a T&R this (east

Re: svn commit: r1738464 - /httpd/httpd/trunk/server/mpm/event/event.c

2016-12-15 Thread Yann Ylavic
On Thu, Dec 15, 2016 at 8:06 PM, Eric Covener wrote: > I have been looking at this area a little bit from the perspective of > killing the keepalive conns as early as possible during graceful > process exit. > > This might have had a bad interaction with the event wakeup patch > here. Hmm, the wa

Re: svn commit: r1738464 - /httpd/httpd/trunk/server/mpm/event/event.c

2016-12-15 Thread Eric Covener
On Thu, Dec 15, 2016 at 2:47 PM, Yann Ylavic wrote: > Hmm, the wakeup patch isn't in 2.4.24/x already no? (not proposed, by > me at least, too much changes in events already...). You're right, my bad. I will followup in the release thread that it's a red herring. -- Eric Covener cove...@gmail

Re: T&R of 2.4.24

2016-12-15 Thread Eric Covener
On Thu, Dec 15, 2016 at 2:09 PM, Eric Covener wrote: > On Thu, Dec 15, 2016 at 10:16 AM, Eric Covener wrote: >> On Thu, Dec 15, 2016 at 10:13 AM, Jim Jagielski wrote: >>> From what I can see, there are no show-stoppers and >>> all my tests show no regressions... >>> >>> Let's shoot for a T&R thi

Re: svn commit: r1738464 - /httpd/httpd/trunk/server/mpm/event/event.c

2016-12-15 Thread Eric Covener
On Thu, Dec 15, 2016 at 2:47 PM, Yann Ylavic wrote: > If we want to kill keepalive connections early on restart/shutdown I'd rather > : > > Index: server/mpm/event/event.c > === > --- server/mpm/event/event.c(revision 1774260) >

Re: svn commit: r1738464 - /httpd/httpd/trunk/server/mpm/event/event.c

2016-12-15 Thread Eric Covener
On Thu, Dec 15, 2016 at 3:07 PM, Eric Covener wrote: > On Thu, Dec 15, 2016 at 2:47 PM, Yann Ylavic wrote: >> If we want to kill keepalive connections early on restart/shutdown I'd >> rather : >> >> Index: server/mpm/event/event.c >> ==

Re: svn commit: r1738464 - /httpd/httpd/trunk/server/mpm/event/event.c

2016-12-15 Thread Yann Ylavic
On Thu, Dec 15, 2016 at 8:54 PM, Eric Covener wrote: > On Thu, Dec 15, 2016 at 2:47 PM, Yann Ylavic wrote: >> Hmm, the wakeup patch isn't in 2.4.24/x already no? (not proposed, by >> me at least, too much changes in events already...). > > > You're right, my bad. I will followup in the release t

Re: svn commit: r1738464 - /httpd/httpd/trunk/server/mpm/event/event.c

2016-12-15 Thread Eric Covener
On Thu, Dec 15, 2016 at 3:15 PM, Yann Ylavic wrote: > Ah ok, so you did not reproduced this with vanilla 2.4.x, right? Right, I was on trunk and had just assumed this was backported (I knew the sf stuff was). > > BTW, I had issues while testing both sf's changes (now in 2.4.x), the > wakeup ones

Re: svn commit: r1738464 - /httpd/httpd/trunk/server/mpm/event/event.c

2016-12-15 Thread Jim Jagielski
Actually, it is. https://svn.apache.org/viewvc?view=revision&revision=1772334 > On Dec 15, 2016, at 2:47 PM, Yann Ylavic wrote: > > On Thu, Dec 15, 2016 at 8:06 PM, Eric Covener wrote: >> I have been looking at this area a little bit from the perspective of >> killing the keepalive conns a

Re: T&R of 2.4.24

2016-12-15 Thread Jim Jagielski
Actually, it is: https://svn.apache.org/viewvc?view=revision&revision=1772334 So I would like to see the enhancement in: https://lists.apache.org/thread.html/03a360e5214052b38752d10a75f864e59d518cd6ac8ddbbcefe91c18@%3Cdev.httpd.apache.org%3E applied to trunk and then proposed for backp

Re: T&R of 2.4.24

2016-12-15 Thread Jim Jagielski
Done and done. > On Dec 15, 2016, at 4:30 PM, Jim Jagielski wrote: > > Actually, it is: > >https://svn.apache.org/viewvc?view=revision&revision=1772334 > > So I would like to see the enhancement in: > > > https://lists.apache.org/thread.html/03a360e5214052b38752d10a75f864e59d518cd6ac8

Re: T&R of 2.4.24

2016-12-15 Thread Jim Jagielski
I'll give it until tomorrow AM... If we have the 3, it'll be folded in. If not, I'm not going to delay. > On Dec 15, 2016, at 4:34 PM, Jim Jagielski wrote: > > Done and done. > >> On Dec 15, 2016, at 4:30 PM, Jim Jagielski wrote: >> >> Actually, it is: >> >> https://svn.apache.org/viewvc?v

Re: T&R of 2.4.24

2016-12-15 Thread Yann Ylavic
On Thu, Dec 15, 2016 at 10:34 PM, Jim Jagielski wrote: > Done and done. Will voted it, but I don't think it's necessary for 2.4.24 (not harmful though, possibly useless). > >> On Dec 15, 2016, at 4:30 PM, Jim Jagielski wrote: >> >> Actually, it is: >> >>https://svn.apache.org/viewvc?view=re

Re: T&R of 2.4.24

2016-12-15 Thread Yann Ylavic
On Thu, Dec 15, 2016 at 10:52 PM, Yann Ylavic wrote: > On Thu, Dec 15, 2016 at 10:34 PM, Jim Jagielski wrote: >> Done and done. > > Will voted it I meant "will vote" in this typo, not veto ;) Maybe Eric with an easy reproducer could confirm, but unless poll() consistently return EINTR I don't s

Re: svn commit: r1774525 - /httpd/httpd/trunk/server/mpm/event/event.c

2016-12-15 Thread Yann Ylavic
On Thu, Dec 15, 2016 at 10:32 PM, wrote: > Author: jim > Date: Thu Dec 15 21:32:50 2016 > New Revision: 1774525 > > URL: http://svn.apache.org/viewvc?rev=1774525&view=rev > Log: > kill the keepalive conns as early as possible during graceful > process exit. > > Modified: > httpd/httpd/trunk/s

Re: svn commit: r1774544 - /httpd/httpd/branches/2.4.x/STATUS

2016-12-15 Thread Yann Ylavic
On Fri, Dec 16, 2016 at 1:10 AM, wrote: > Author: ylavic > Date: Fri Dec 16 00:10:40 2016 > New Revision: 1774544 > > URL: http://svn.apache.org/viewvc?rev=1774544&view=rev > Log: > Propose. > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified: httpd/httpd/branches/2.4.x/STATUS > UR