Re: The drive for 2.4.26

[Rainer Jung]

Am 28.05.2017 um 16:16 schrieb Rainer Jung:

Am 28.05.2017 um 13:13 schrieb Jan Ehrhardt:

Rainer Jung in gmane.comp.apache.devel (Fri, 21 Apr 2017 00:29:38
+0200):

...

In addition I noticed the following glitch:

...

The "-m" option is independent of SSL use and should be handled outside
of "#ifdef USE_SSL".


This patch is not submitted. Any idea why? After all, the help text of
'ab' mentions ' -m method  Method name', but for instance '-m HEAD' has
no effect al all with 'ab', only with 'abs'.


Thanks for the reminder. Fixed in r1796493 for trunk and 2.4.x backport
proposal added.


Due to quick votes from the team this has now been committed in r1796539 
for 2.4.26.


Regards,

Rainer

Re: The drive for 2.4.26

[Yann Ylavic]

Hi,

On Sun, May 28, 2017 at 8:38 PM, Stefan Priebe - Profihost AG
 wrote:
> Hi Luca,
>
> Am 27.05.2017 um 09:10 schrieb Luca Toscano:
>> Hi Jim,
>>
>> 2017-05-25 14:23 GMT+02:00 Jim Jagielski > >:
>>
>> Until a proposal in in STATUS (and apologies if it is), its
>> suitability for 2.4.x is a big unknown.
>>
>>
>> you are completely right, afaik the last patch tested by Stefan Priebe
>> was https://bz.apache.org/bugzilla/attachment.cgi?id=34641=diff
>> (Stefan correct me if I am wrong).
>
> Yes that's right. Yann told something about a V8 coming soon but that's
> weeks ago. V7 seems to run fine. Currently running on nearly 2000 vms.

V7 proposed for backport to 2.4.x.

I called it v7.1 because of the following added hunk.
This removed code was 2.4 specific (not in trunk) and already handled
above (before the poll), so I don't see why we'd lock
g_timer_skiplist_mtx one more time here instead of waiting for the
next loop (and accurate timeout now thanks to wakeup).

@@ -1632,21 +1765,6 @@ static void * APR_THREAD_FUNC listener_thread(apr_
 break;
 }

-now = apr_time_now();
-apr_thread_mutex_lock(g_timer_skiplist_mtx);
-ep = apr_skiplist_peek(timer_skiplist);
-while (ep) {
-if (ep->when < now + EVENT_FUDGE_FACTOR) {
-apr_skiplist_pop(timer_skiplist, NULL);
-push_timer2worker(ep);
-}
-else {
-break;
-}
-ep = apr_skiplist_peek(timer_skiplist);
-}
-apr_thread_mutex_unlock(g_timer_skiplist_mtx);
-
 while (num) {
 pt = (listener_poll_type *) out_pfd->client_data;
 if (pt->type == PT_CSD) {

>
>> If I remember correctly it might be possible that some commits were not
>> necessary since they were made as a test to remove segfaults that we
>> discovered due to other things. I'll wait Yann's feedback but if anybody
>> wants to check the patch it would be really great.

V7 is all we need for now, the other changes relative to ptrans
allocator should be (and are now) addressed in mod_http2 (not really
needed for HTTP/1 handling).

Regarding v8, this is possibly an optimization to avoid external
locking when adding or removing events from the pollset, but it
introduces some race conditions which should be addressed before I
propose something.


Regards,
Yann.

Re: The drive for 2.4.26

[Stefan Priebe - Profihost AG]

Hi Luca,

Am 27.05.2017 um 09:10 schrieb Luca Toscano:
> Hi Jim,
> 
> 2017-05-25 14:23 GMT+02:00 Jim Jagielski  >:
> 
> Until a proposal in in STATUS (and apologies if it is), its
> suitability for 2.4.x is a big unknown.
> 
> 
> you are completely right, afaik the last patch tested by Stefan Priebe
> was https://bz.apache.org/bugzilla/attachment.cgi?id=34641=diff
> (Stefan correct me if I am wrong).

Yes that's right. Yann told something about a V8 coming soon but that's
weeks ago. V7 seems to run fine. Currently running on nearly 2000 vms.

> If I remember correctly it might be possible that some commits were not
> necessary since they were made as a test to remove segfaults that we
> discovered due to other things. I'll wait Yann's feedback but if anybody
> wants to check the patch it would be really great.
> 
> Thanks!
> 
> Luca 

Re: The drive for 2.4.26

[Rainer Jung]

Am 28.05.2017 um 13:13 schrieb Jan Ehrhardt:

Rainer Jung in gmane.comp.apache.devel (Fri, 21 Apr 2017 00:29:38
+0200):

Thanks for the analysis. So the following patch on trunk works for me
when using OpenSSL 1.0.1e (on Solaris 10):

Index: support/ab.c
===
--- support/ab.c(revision 1792155)
+++ support/ab.c(working copy)
@@ -2576,8 +2576,6 @@
 #else
 #if OPENSSL_VERSION_NUMBER < 0x1010L
 CRYPTO_malloc_init();
-#else
-OPENSSL_malloc_init();
 #endif
 #endif
 SSL_load_error_strings();


The same fix should apply for 2.4.x.


@Jacob Champion: thanks for submitting this patch and backporting it to
the 2.4.x branch.


In addition I noticed the following glitch:

Index: support/ab.c
===
--- support/ab.c(revision 1792155)
+++ support/ab.c(working copy)
@@ -2465,14 +2465,14 @@
 case 'B':
 myhost = apr_pstrdup(cntxt, opt_arg);
 break;
+case 'm':
+method = CUSTOM_METHOD;
+method_str[CUSTOM_METHOD] = strdup(opt_arg);
+break;
 #ifdef USE_SSL
 case 'Z':
 ssl_cipher = strdup(opt_arg);
 break;
-case 'm':
-method = CUSTOM_METHOD;
-method_str[CUSTOM_METHOD] = strdup(opt_arg);
-break;
 case 'f':
 #if OPENSSL_VERSION_NUMBER < 0x1010L
 if (strncasecmp(opt_arg, "ALL", 3) == 0) {


The "-m" option is independent of SSL use and should be handled outside
of "#ifdef USE_SSL".


This patch is not submitted. Any idea why? After all, the help text of
'ab' mentions ' -m method  Method name', but for instance '-m HEAD' has
no effect al all with 'ab', only with 'abs'.


Thanks for the reminder. Fixed in r1796493 for trunk and 2.4.x backport 
proposal added.


Regards,

Rainer

Re: The drive for 2.4.26

[Jan Ehrhardt]

Rainer Jung in gmane.comp.apache.devel (Fri, 21 Apr 2017 00:29:38
+0200):
>Thanks for the analysis. So the following patch on trunk works for me 
>when using OpenSSL 1.0.1e (on Solaris 10):
>
>Index: support/ab.c
>===
>--- support/ab.c(revision 1792155)
>+++ support/ab.c(working copy)
>@@ -2576,8 +2576,6 @@
>  #else
>  #if OPENSSL_VERSION_NUMBER < 0x1010L
>  CRYPTO_malloc_init();
>-#else
>-OPENSSL_malloc_init();
>  #endif
>  #endif
>  SSL_load_error_strings();
>
>
>The same fix should apply for 2.4.x.

@Jacob Champion: thanks for submitting this patch and backporting it to
the 2.4.x branch.

>In addition I noticed the following glitch:
>
>Index: support/ab.c
>===
>--- support/ab.c(revision 1792155)
>+++ support/ab.c(working copy)
>@@ -2465,14 +2465,14 @@
>  case 'B':
>  myhost = apr_pstrdup(cntxt, opt_arg);
>  break;
>+case 'm':
>+method = CUSTOM_METHOD;
>+method_str[CUSTOM_METHOD] = strdup(opt_arg);
>+break;
>  #ifdef USE_SSL
>  case 'Z':
>  ssl_cipher = strdup(opt_arg);
>  break;
>-case 'm':
>-method = CUSTOM_METHOD;
>-method_str[CUSTOM_METHOD] = strdup(opt_arg);
>-break;
>  case 'f':
>  #if OPENSSL_VERSION_NUMBER < 0x1010L
>  if (strncasecmp(opt_arg, "ALL", 3) == 0) {
>
>
>The "-m" option is independent of SSL use and should be handled outside 
>of "#ifdef USE_SSL".

This patch is not submitted. Any idea why? After all, the help text of
'ab' mentions ' -m method  Method name', but for instance '-m HEAD' has
no effect al all with 'ab', only with 'abs'.
-- 
Jan

Bug report for Apache httpd-2 [2017/05/28]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 8713|Inf|Min|2002-05-01|No Errorlog on PROPFIND/Depth:Infinity|
| 8867|Opn|Cri|2002-05-07|exports.c generation fails when using a symlink to|
|10747|New|Maj|2002-07-12|ftp SIZE command and 'smart' ftp servers results i|
|11294|New|Enh|2002-07-30|desired vhost_alias option|
|11580|Opn|Enh|2002-08-09|generate Content-Location headers |
|12033|Opn|Nor|2002-08-26|Graceful restart immediately result in [warn] long|
|13599|Inf|Nor|2002-10-14|autoindex formating broken for multibyte sequences|
|13661|Ass|Enh|2002-10-15|Apache cannot not handle dynamic IP reallocation  |
|14104|Opn|Enh|2002-10-30|not documented: must restart server to load new CR|
|14496|New|Enh|2002-11-13|Cannot upgrade any version on Windows. Must uninst|
|14922|Inf|Enh|2002-11-28| is currently hardcoded to 'apache2'  |
|15719|Inf|Nor|2002-12-30|WebDAV MOVE to destination URI which is content-ne|
|16761|Inf|Nor|2003-02-04|CustomLog with pipe spawns process during config  |
|16811|Ass|Maj|2003-02-05|mod_autoindex always return webpages in UTF-8.|
|17107|New|Min|2003-02-16|Windows should not install printenv   |
|17114|New|Enh|2003-02-17|Please add strip and install-strip targets to Make|
|17244|Ass|Nor|2003-02-20|./configure --help gives false information regardi|
|17497|Opn|Nor|2003-02-27|mod_mime_magic generates incorrect response header|
|18325|New|Enh|2003-03-25|PAM support for suEXEC|
|18334|Inf|Cri|2003-03-25|Server crashes when authenticating users against L|
|19670|New|Enh|2003-05-05|content type header supplied upon PUT is thrown aw|
|20036|Ass|Nor|2003-05-19|Trailing Dots stripped from PATH_INFO environment |
|21260|New|Nor|2003-07-02|CacheMaxExpire directive not enforced !   |
|21533|Ass|Cri|2003-07-11|Multiple levels of htacces files can cause mod_aut|
|22484|Opn|Maj|2003-08-16|semaphore problem takes httpd down|
|22686|Opn|Nor|2003-08-25|ab: apr_poll: The timeout specified has expired (7|
|22898|Opn|Nor|2003-09-02|nph scripts with two HTTP header  |
|23167|Inf|Cri|2003-09-14|--enable-layout never goes to apr apr-util|
|23181|New|Nor|2003-09-15|Status 304 (Not modified) and chunking leads to an|
|23238|New|Cri|2003-09-18|non-async-signal-safe operations from signal handl|
|23330|New|Enh|2003-09-22|Enhance ApacheMonitor to view and control Tomcat s|
|23911|Opn|Cri|2003-10-18|CGI processes left defunct/zombie under 2.0.54|
|24031|New|Enh|2003-10-23|Passphrase protected private key in SSLProxyMachin|
|24095|Opn|Cri|2003-10-24|ERROR "Parent: child process exited with status 32|
|24437|Opn|Nor|2003-11-05|mod_auth_ldap doubly-escapes backslash (\) charact|
|24890|Opn|Nor|2003-11-21|Apache config parser should not be local aware ( g|
|25014|New|Enh|2003-11-26|A flexible interface for mod_log_config   |
|25201|New|Enh|2003-12-04|Provide Cache Purge operation |
|25240|Inf|Enh|2003-12-05|SSL Library Error: 336105671 logged as information|
|25435|New|Enh|2003-12-11|sethandler and directoryindex not playing nice|
|25469|Opn|Enh|2003-12-12|create AuthRoot for defining paths to auth files  |
|25484|Ass|Nor|2003-12-12|Non-service Apache cannot be stopped in WinXP |
|25543|Inf|Nor|2003-12-15|mod_proxy_ajp overwrites existing response headers|
|25667|New|Nor|2003-12-19|Memory leak in function ssl_scache_dbm_retrieve().|
|25863|New|Enh|2004-01-02|new per-host initialization hooks |
|26005|New|Nor|2004-01-08|SERVER_NAME incorrect when using IPv6 address in U|
|26142|New|Maj|2004-01-14|EnableSendFile Off for Windows XP Home|
|26153|Opn|Cri|2004-01-15|Apache cygwin directory traversal vulnerability   |
|26368|New|Min|2004-01-23|File extensions in AddDescription treated as part |
|26446|New|Nor|2004-01-26|flush buckets followed by eos bucket emit multiple|
|26478|New|Enh|2004-01-28|mod_dav does not expose a method for setting the D|