Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT

2018-12-16 Thread Yann Ylavic
On Sun, Dec 16, 2018 at 2:14 PM Stefan Sperling wrote: > > The file /usr/include/zlib.h I have on OpenBSD -current has this: > > typedef struct z_stream_s { > [...] > z_off_t total_in; /* total nb of input bytes read so far */ > [...] > z_off_t total_out; /* total nb of bytes

Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT

2018-12-16 Thread Yann Ylavic
On Sun, Dec 16, 2018 at 2:21 PM Yann Ylavic wrote: > > On Sun, Dec 16, 2018 at 2:14 PM Stefan Sperling wrote: > > > > The file /usr/include/zlib.h I have on OpenBSD -current has this: > > > > typedef struct z_stream_s { > > [...] > > z_off_t total_in; /* total nb of input bytes read so

Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT

2018-12-16 Thread Yann Ylavic
On Sun, Dec 16, 2018 at 1:28 PM Stefan Sperling wrote: > > mod_deflates hard-codes some off_t format directives to "%ld". > It seems to me this code should use the macro provided by APR instead. > > Looking for another pair of eyes. Does this patch look good to commit? It seems that zlib defines

[PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT

2018-12-16 Thread Stefan Sperling
mod_deflates hard-codes some off_t format directives to "%ld". It seems to me this code should use the macro provided by APR instead. Looking for another pair of eyes. Does this patch look good to commit? Index: modules/filters/mod_deflate.c

Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT

2018-12-16 Thread Stefan Sperling
On Sun, Dec 16, 2018 at 02:03:45PM +0100, Yann Ylavic wrote: > On Sun, Dec 16, 2018 at 1:28 PM Stefan Sperling wrote: > > > > mod_deflates hard-codes some off_t format directives to "%ld". > > It seems to me this code should use the macro provided by APR instead. > > > > Looking for another pair