Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Stefan Eissing
> Am 02.07.2019 um 14:00 schrieb Eric Covener : > > On Tue, Jul 2, 2019 at 7:38 AM Stefan Eissing > wrote: >> >> >> >>> Am 02.07.2019 um 13:35 schrieb Eric Covener : >>> >>> On Tue, Jul 2, 2019 at 4:51 AM Stefan Eissing >>> wrote: People with in insight into your connection

[RELEASE CANDIDATE] Apache-Test-1.41 RC1

2019-07-03 Thread Steve Hay
Please download, test, and report back on this Apache-Test 1.41 release candidate. https://dist.apache.org/repos/dist/dev/perl/Apache-Test-1.41-rc1.tar.gz MD5 = 7933d3a6a762f087bf7883a1ac2086eb SHA1 = 17aa9a8669023aa2f485aa83f8f389969b8e5f0c Major changes in this release are as follows: Set

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Yann Ylavic
On Wed, Jul 3, 2019 at 1:50 PM Stefan Eissing wrote: > > HE IS ALIVE! \o/ Yes :)) still a bit overwhelmed at day $job though :/

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Yann Ylavic
On Wed, Jul 3, 2019 at 9:23 AM Stefan Eissing wrote: > > > Am 02.07.2019 um 14:00 schrieb Eric Covener : > > > > I think a successful exit of CONN_STATE_WRITE_COMPLETION would > > conceptually lead to keepalive state so that would be plausible. And > > a failed one would go into lingering close.

Re: [RELEASE CANDIDATE] Apache-Test-1.41 RC1

2019-07-03 Thread Philippe Chiasson
Fantastic! Thanks Steve! Will be giving this a spin today Sent from the depths of my mind on an iPhone > On Jul 3, 2019, at 03:45, Steve Hay wrote: > > Please download, test, and report back on this Apache-Test 1.41 > release candidate. > >

Re: [RELEASE CANDIDATE] Apache-Test-1.41 RC1

2019-07-03 Thread Steve Hay
On Wed, 3 Jul 2019 at 08:45, Steve Hay wrote: > > Please download, test, and report back on this Apache-Test 1.41 > release candidate. > > https://dist.apache.org/repos/dist/dev/perl/Apache-Test-1.41-rc1.tar.gz > +1 from me using the following setups: VC++ 2013 32-bit, Perl 5.30.0, Apache

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Yann Ylavic
On Wed, Jul 3, 2019 at 2:03 PM Stefan Eissing wrote: > > > Am 03.07.2019 um 13:57 schrieb Yann Ylavic : > > > > On Wed, Jul 3, 2019 at 1:50 PM Stefan Eissing > > wrote: > >> > >> HE IS ALIVE! \o/ > > > > Yes :)) still a bit overwhelmed at day $job though :/ > > It's a shabby world where open

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Stefan Eissing
The change works nicely in my tests. I have some where I trigger timeout and keepalive and I see the effect. For 2.4.x I test as well and need a slight adjustment to event.c. Could you look if that ok? Then I would propose that for backport. Cheers, Stefan h2-keepalive-yann-v2.patch

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Stefan Eissing
HE IS ALIVE! \o/ Great! I will try this in trunk later today. That there are two "queues", one with Timeout and one with KeepAliveTimeout, fixed for all connections, was my read, but I am not that deep into mpm_event. Thanks for confirming and the patch. Will report back. Cheers, Stefan >

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Stefan Eissing
> Am 03.07.2019 um 13:57 schrieb Yann Ylavic : > > On Wed, Jul 3, 2019 at 1:50 PM Stefan Eissing > wrote: >> >> HE IS ALIVE! \o/ > > Yes :)) still a bit overwhelmed at day $job though :/ It's a shabby world where open source devs need to pay rent and food+drinks in restaurants...

Re: svn commit: r1862475 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_conn.c modules/http2/h2_version.h server/mpm/event/event.c

2019-07-03 Thread Ruediger Pluem
On 07/03/2019 03:46 PM, ic...@apache.org wrote: > Author: icing > Date: Wed Jul 3 13:46:31 2019 > New Revision: 1862475 > > URL: http://svn.apache.org/viewvc?rev=1862475=rev > Log: > *) mod_http2/mpm_event: Fixes the behaviour when a HTTP/2 connection has > nothing > more to write

Re: configure --enable-maintainer-mode gives errors on fedora 30

2019-07-03 Thread jean-frederic clere
On 01/07/2019 17:59, Joe Orton wrote: > On Tue, Jun 18, 2019 at 07:29:51PM +0200, Christophe JAILLET wrote: >> Hi, >> >> Just for the records, this is apparently already pat of r1809037 on trunk. > > Stefan are you planning to merge the changes here to 2.4.x any time > soon? If not can I get a

Re: svn commit: r1862475 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_conn.c modules/http2/h2_version.h server/mpm/event/event.c

2019-07-03 Thread Yann Ylavic
On Wed, Jul 3, 2019 at 6:38 PM Ruediger Pluem wrote: > > On 07/03/2019 03:46 PM, ic...@apache.org wrote: > > > > -if (pending == OK) { > > +if (pending == OK || (pending == DECLINED && > > + cs->pub.sense == CONN_SENSE_WANT_READ)) { > > Sorry for being