[PATCH] looking for zlib headers in all the wrong places

2001-12-08 Thread Jeff Trawick
I was trying to use --with-z=/path but without this patch the check for the library didn't add -I/path and so didn't compile. Even with this patch, the check for zutil.h. Clearly (from config.log) my path is not being searched. Perhaps there is a better change that makes both tests work?

Re: Magic in request.c

2001-12-08 Thread Brian Pane
Ben Laurie wrote: This patch removes some magic in request.c. I wrote it coz 2.0.28 didn't actually work at all for me, coz the magic failed. +1; this patch is a lot less cryptic than the current logic Somehow the magic was OK again in the snapshot I tried, but I consider it a bad thing that

Re: Magic in request.c

2001-12-08 Thread Bill Stoddard
(btw, the whole directory walk I find completely unreadable, I ought to do something about it). +1, readability is a good thing. Bill

Magic in request.c

2001-12-08 Thread Ben Laurie
This patch removes some magic in request.c. I wrote it coz 2.0.28 didn't actually work at all for me, coz the magic failed. Somehow the magic was OK again in the snapshot I tried, but I consider it a bad thing that it exists at all (btw, the whole directory walk I find completely unreadable, I

Re: [PATCH] looking for zlib headers in all the wrong places

2001-12-08 Thread Jeff Trawick
Justin Erenkrantz [EMAIL PROTECTED] writes: On Sat, Dec 08, 2001 at 08:31:18AM -0500, Jeff Trawick wrote: I was trying to use --with-z=/path but without this patch the check for the library didn't add -I/path and so didn't compile. snip, snip @@ -53,7 +53,7 @@

Re: Magic in request.c

2001-12-08 Thread William A. Rowe, Jr.
This patch removes some magic in request.c. I wrote it coz 2.0.28 didn't actually work at all for me, coz the magic failed. ++1. Clarity doesn't have to be inconsistent with optimization. In my defense, what existing before was even less legible - I sincerely tryed to improve it before the