Re: APACHE_TEST_LIVE_DEV

2003-12-22 Thread Stas Bekman
William McKee wrote: Hi again, More problems with configuring my Apache::Test setup. I have successfully added the Apache::Test framework into a current project. As I'm adding new tests, I need to update the code in my modules. To this end, I followed the advice in the docs to set

Re: why open_logs/post_config hooks are run only for the main server?

2003-12-22 Thread Geoffrey Young
William A. Rowe, Jr. wrote: It is almost worth a totally different hook entry point (before post_config) such as vhost_init which *would* be called per-vhost (starting from the main server config and working through the list.) I have several modules with the for (s=_server; s; s = s-next)

Re: why open_logs/post_config hooks are run only for the main server?

2003-12-22 Thread William A. Rowe, Jr.
Only question below is should this hook always run before or after the post config hook? My gut says after post config. At 11:19 AM 12/22/2003, Geoff wrote: I had some spare time and thought I could help with the grunt work - my try at a patch attached. +for (s = server_conf; s; s =

Re: why open_logs/post_config hooks are run only for the main server?

2003-12-22 Thread Geoffrey Young
William A. Rowe, Jr. wrote: Only question below is should this hook always run before or after the post config hook? My gut says after post config. just going from what you had said earlier: It is almost worth a totally different hook entry point (before post_config) such as vhost_init

Re: why open_logs/post_config hooks are run only for the main server?

2003-12-22 Thread Stas Bekman
Geoffrey Young wrote: William A. Rowe, Jr. wrote: Only question below is should this hook always run before or after the post config hook? My gut says after post config. just going from what you had said earlier: It is almost worth a totally different hook entry point (before post_config)

Re: log_error_core escaping change broke things

2003-12-22 Thread Stas Bekman
Andre Malo wrote: * Stas Bekman [EMAIL PROTECTED] wrote: André Malo wrote: * Stas Bekman [EMAIL PROTECTED] wrote: Yes, but we use it to log error messages which aren't under our control. e.g. from user's programs, like cgi scripts. what are we supposed to do? parse and split a multiline

Re: why open_logs/post_config hooks are run only for the main server?

2003-12-22 Thread William A. Rowe, Jr.
At 04:47 PM 12/22/2003, Stas Bekman wrote: I'm not sure this is a good idea to run it on the main host. If it was we could just as well run post_config for each vhost as well. No, you missed my earlier point. post_config is a run-once. host_init is the run-each you requested. The problem is