[jira] Resolved: (MODPYTHON-104) Allow Python code callouts with mod_include (SSI).

2006-10-27 Thread Graham Dumpleton (JIRA)
[ http://issues.apache.org/jira/browse/MODPYTHON-104?page=all ] Graham Dumpleton resolved MODPYTHON-104. Resolution: Fixed New chapter added in documentation, so all done. Allow Python code callouts with mod_include (SSI).

[jira] Commented: (MODPYTHON-93) Improve util.FieldStorage efficiency

2006-10-27 Thread Graham Dumpleton (JIRA)
[ http://issues.apache.org/jira/browse/MODPYTHON-93?page=comments#action_12445123 ] Graham Dumpleton commented on MODPYTHON-93: --- I have committed some changes into repository now which fixes the issue with add_field() but also does

[jira] Resolved: (MODPYTHON-127) Use namespace for mod_python PythonOption settings.

2006-10-27 Thread Graham Dumpleton (JIRA)
[ http://issues.apache.org/jira/browse/MODPYTHON-127?page=all ] Graham Dumpleton resolved MODPYTHON-127. Resolution: Fixed For now I have just made the tests use the new option names. There is obviously a risk that I stuffed up the backward

Re: Python 2.5 nested auth functions in publisher.

2006-10-27 Thread Dan Eloff
On 10/27/06, Graham Dumpleton [EMAIL PROTECTED] wrote: Jim sent this to me when the python-dev list was down for maintenance. Can anyone with Python 2.5 who knows something about function internals enlighten us about what may have changed here. Previously the names of nested functions appeared

Re: [jira] Resolved: (MODPYTHON-127) Use namespace for mod_python PythonOption settings.

2006-10-27 Thread Jim Gallacher
Graham Dumpleton (JIRA) wrote: [ http://issues.apache.org/jira/browse/MODPYTHON-127?page=all ] Graham Dumpleton resolved MODPYTHON-127. Resolution: Fixed For now I have just made the tests use the new option names. There is obviously a risk

Re: Python 2.5 nested auth functions in publisher.

2006-10-27 Thread Graham Dumpleton
On 27/10/2006, at 9:31 PM, Dan Eloff wrote: On 10/27/06, Graham Dumpleton [EMAIL PROTECTED] wrote: Jim sent this to me when the python-dev list was down for maintenance. Can anyone with Python 2.5 who knows something about function internals enlighten us about what may have changed here.

Re: Python 2.5 nested auth functions in publisher.

2006-10-27 Thread Dan Eloff
On 10/27/06, Graham Dumpleton [EMAIL PROTECTED] wrote: Unless they have really screwed things around, co_varnames is specifically for function argument names and is unlikely to contained nested constant names. If it did, then I would expect a lot of the publisher code to break in other ways as

Re: Changes to what is displayed when handler exception occurs.

2006-10-27 Thread Dan Eloff
I know we have talked a bit before about providing a means of allowing people to return custom error pages and I haven't forgotten that. The cleanup of the code and working out what the report error function should take in the way of arguments is a first step to seeing how the ability to override

Re: Changes to what is displayed when handler exception occurs.

2006-10-27 Thread Graham Dumpleton
Have a play with code in subversion now. I have checked in some code which dumps out information about the per request modules cache when a 500 error is occurring and details being returned to the browser. This has been useful as it has helped me to work out a way of duplicating a problem I

$reg-param, $req-body - is there a way to set form data?

2006-10-27 Thread Patrick Galbraith
Hi all, I have in my code what used to work on 1.0. I have this variable, $form, which is a reference for $req-param. I had cases in the code where something is submitted in a form that is incorrect, and I want to change the op of the form by setting $form-{op} (the code has a hash reference

Re: $reg-param, $req-body - is there a way to set form data?

2006-10-27 Thread Jonathan Vanasco
On Oct 27, 2006, at 8:25 PM, Philip M. Gollucci wrote: You can not, they are readonly versions of APR::Table (apr_table_t) You could always copy the structure to a hash somewhere. Also, check the archvies of this list, I know someone (probably joes) posted an answer to this question

Re: mod_disk_cache summarization

2006-10-27 Thread Graham Leggett
On Mon, October 23, 2006 10:50 pm, Davi Arnaut wrote: AFAIK all major platforms provide one, even win32. I even made a incomplete APR abstraction for file notification: http://haxent.com/~davi/apr/notify Is it possible to add doxygen comments on the apr_notify.h file, so as to confirm

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/mod_mem_cache.c

2006-10-27 Thread Davi Arnaut
[EMAIL PROTECTED] wrote: Author: minfrin Date: Fri Oct 27 06:28:56 2006 New Revision: 468373 URL: http://svn.apache.org/viewvc?view=revrev=468373 Log: mod_cache: Pass the output filter stack through the store_body() hook, giving each cache backend the ability to make a better decision as

Re: mod_disk_cache summarization

2006-10-27 Thread Davi Arnaut
Graham Leggett wrote: On Mon, October 23, 2006 10:50 pm, Davi Arnaut wrote: AFAIK all major platforms provide one, even win32. I even made a incomplete APR abstraction for file notification: http://haxent.com/~davi/apr/notify Is it possible to add doxygen comments on the apr_notify.h

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/

2006-10-27 Thread Graham Leggett
On Fri, October 27, 2006 4:38 pm, Davi Arnaut wrote: Where is pdconf ? Check out all those APR_HAS_SENDFILE. Aaargh... will fix. Those if( and if ( are going on my nerves! :) Damn, missed some. Swapping the metadata check would make the code much more readable: if (is_metadata)

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/mod_mem_cache.c

2006-10-27 Thread Joe Orton
On Fri, Oct 27, 2006 at 11:38:02AM -0300, Davi Arnaut wrote: +/* Is our network connection still alive? + * If not, we must continue caching the file, so keep looping. + * We will return the error at the end when caching is done. +

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/

2006-10-27 Thread Niklas Edmundsson
On Fri, 27 Oct 2006, Graham Leggett wrote: On Fri, October 27, 2006 4:38 pm, Davi Arnaut wrote: Where is pdconf ? Check out all those APR_HAS_SENDFILE. Aaargh... will fix. The purpose of that code was originally to make EnableSendfile Off in the config file work. APR_HAS_SENDFILE only

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h

2006-10-27 Thread Graham Leggett
On Fri, October 27, 2006 6:05 pm, Niklas Edmundsson wrote: The purpose of that code was originally to make EnableSendfile Off in the config file work. APR_HAS_SENDFILE only tells you that APR has sendfile. It still does that as far as I can see: #if APR_HAS_SENDFILE core_dir_config

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h

2006-10-27 Thread Paul Querna
Graham Leggett wrote: On Fri, October 27, 2006 6:05 pm, Niklas Edmundsson wrote: The purpose of that code was originally to make EnableSendfile Off in the config file work. APR_HAS_SENDFILE only tells you that APR has sendfile. It still does that as far as I can see: #if APR_HAS_SENDFILE

Apache 2.2.3 mod_proxy issue

2006-10-27 Thread Jess Holle
When I use: RewriteCond %{REQUEST_URI} /jsp-examples/(.*).jsp(.*) RewriteRule ^/(.*) ajp://localhost:8010/$1 [P] and pound on Tomcat 5.5.20's /jsp-examples/jsp2/el/basic-arithmetic.jsp through Apache (with only a single thread doing the pounding), I start to get 503's after a while. The

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/

2006-10-27 Thread Graham Leggett
On Fri, October 27, 2006 6:00 pm, Joe Orton wrote: Err. We had the data in memory, we are going to read it back from disk again just in order to not block ? That's nonsense. Agreed. Please explain. This is a disk cache. Why would you write expensive bucket data to cache, and then expensive

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h

2006-10-27 Thread Graham Leggett
On Fri, October 27, 2006 6:14 pm, Paul Querna wrote: Honestly, I am -1 on any module needing knowledge of the core module setting. We should be making the abstraction better, not pulling things from the core config. This is true, but right now we don't have this level of abstraction, and I'm

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-27 Thread Niklas Edmundsson
On Wed, 25 Oct 2006, Graham Leggett wrote: I managed to solve this problem last night. snip This is what this code needed: Someone with a clue on the apache internals so stuff can be solved properly. I have said it before and say it again: I'm not that guy, but I know what functionality is

ROADMAP for mod_cache

2006-10-27 Thread Paul Querna
I think we have had enough -1s passed over the last couple days related to mod_cache, that it indicates there is not a consensus on what should be done, nor on how it should be done. I think we need to stop committing code for a couple days, and try to make a rudimentary plan for the intended

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/

2006-10-27 Thread Niklas Edmundsson
On Fri, 27 Oct 2006, Graham Leggett wrote: Err. We had the data in memory, we are going to read it back from disk again just in order to not block ? That's nonsense. Agreed. Please explain. This is a disk cache. Why would you write expensive bucket data to cache, and then expensive bucket

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-27 Thread Graham Leggett
On Fri, October 27, 2006 6:25 pm, Niklas Edmundsson wrote: I would have been most happy if this had been fixed ages ago so I hadn't been forced to spend lots and lots of hours kludging stuff togehter. At least, my kludges seem to have sparked some development in this area, so they have served

Re: ROADMAP for mod_cache

2006-10-27 Thread Graham Leggett
On Fri, October 27, 2006 6:36 pm, Paul Querna wrote: I think we have had enough -1s passed over the last couple days related to mod_cache, that it indicates there is not a consensus on what should be done, nor on how it should be done. I think we need to stop committing code for a couple

Re: mod_disk_cache summarization

2006-10-27 Thread Niklas Edmundsson
On Tue, 24 Oct 2006, Graham Leggett wrote: On Tue, October 24, 2006 2:48 pm, Niklas Edmundsson wrote: Perhaps this could be as simple as using ServerName and ServerAlias (unless the name of the site is part of the URL, which will happen in the forward proxy case) to reduce the cached URL to a

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/

2006-10-27 Thread Davi Arnaut
Niklas Edmundsson wrote: On Fri, 27 Oct 2006, Graham Leggett wrote: Err. We had the data in memory, we are going to read it back from disk again just in order to not block ? That's nonsense. Agreed. Please explain. This is a disk cache. Why would you write expensive bucket data to cache,

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-27 Thread Davi Arnaut
Graham Leggett wrote: On Fri, October 27, 2006 6:25 pm, Niklas Edmundsson wrote: I would have been most happy if this had been fixed ages ago so I hadn't been forced to spend lots and lots of hours kludging stuff togehter. At least, my kludges seem to have sparked some development in this

Re: ROADMAP for mod_cache

2006-10-27 Thread Davi Arnaut
Paul Querna wrote: I think we have had enough -1s passed over the last couple days related to mod_cache, that it indicates there is not a consensus on what should be done, nor on how it should be done. I think we need to stop committing code for a couple days, and try to make a

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/mo

2006-10-27 Thread Greg Marr
At 01:41 PM 10/27/2006, Davi Arnaut wrote: Niklas Edmundsson wrote: And when you have a file backend, you want to hit your disk cache and not the backend when delivering data to a client. People might think that this doesn't matter, but for large files, especially larger than RAM in your

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/mo

2006-10-27 Thread Davi Arnaut
Greg Marr wrote: At 01:41 PM 10/27/2006, Davi Arnaut wrote: Niklas Edmundsson wrote: And when you have a file backend, you want to hit your disk cache and not the backend when delivering data to a client. People might think that this doesn't matter, but for large files, especially larger

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/mo

2006-10-27 Thread Davi Arnaut
Davi Arnaut wrote: Greg Marr wrote: At 01:41 PM 10/27/2006, Davi Arnaut wrote: Niklas Edmundsson wrote: And when you have a file backend, you want to hit your disk cache and not the backend when delivering data to a client. People might think that this doesn't matter, but for large

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-27 Thread William A. Rowe, Jr.
Graham Leggett wrote: I see lots of comments on the code, but the comments are summarised as the cache is fine as it is. It isn't. If it was fine, key users of network caching wouldn't be standing up saying they're using something else. I concur, but the history becomes a nightmare. Let's

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/

2006-10-27 Thread Graham Leggett
Davi Arnaut wrote: But that's a corner case. There is no reason in doing this for small files (common case). For example, in a enterprise grade server memory is cheap and permanent storage is slow and expensive. If permanent storage is slow and expensive, what on earth is the admin doing

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/mo

2006-10-27 Thread Graham Leggett
Davi Arnaut wrote: Because the data is already in memory. Why should I write something to disk, erase it from memory, and read it again shortly ? Why should I take care of something that is the job of the OS ? Why should I trash the VM constantly ? Because reading slowly from a cache disk is

Re: mod_disk_cache summarization

2006-10-27 Thread Graham Leggett
Niklas Edmundsson wrote: Different VHosts meaning different URLs/directories, pointing to the same files... Hmm... Two thoughts come into my head over this one. One way to approach this is to treat this as a general problem of how do we stop people who download the same file from multiple

Re: mod_disk_cache summarization

2006-10-27 Thread Guy Hulbert
On Fri, 2006-27-10 at 23:33 +0200, Graham Leggett wrote: Different VHosts meaning different URLs/directories, pointing to the same files... Hmm... Two thoughts come into my head over this one. One way to approach this is to treat this as a general problem of how do we stop people

Re: Python 2.5 nested auth functions in publisher.

2006-10-27 Thread Graham Dumpleton
Thanks, confirms my thinking when I was trying to sleep. That is, that the only way they could do it if using co_varnames was to rely on co_argcount to denote which are the function arguments and which aren't. Strange, wander why they made this change? Anyway, will log a JIRA issue and see

Re: Changes to what is displayed when handler exception occurs.

2006-10-27 Thread Graham Dumpleton
On 27/10/2006, at 11:08 PM, Dan Eloff wrote: I know we have talked a bit before about providing a means of allowing people to return custom error pages and I haven't forgotten that. The cleanup of the code and working out what the report error function should take in the way of arguments

Re: mod_disk_cache summarization

2006-10-27 Thread Henrik Nordstrom
fre 2006-10-27 klockan 23:33 +0200 skrev Graham Leggett: A second approach could involve the use of the Etags associated with file responses, which in the case of files served off disk (as I understand it) are generated based on inode number and various other uniquely file specific

Re: mod_disk_cache summarization

2006-10-27 Thread Henrik Nordstrom
lör 2006-10-28 klockan 00:21 +0200 skrev Henrik Nordstrom: fre 2006-10-27 klockan 23:33 +0200 skrev Graham Leggett: A second approach could involve the use of the Etags associated with file responses, which in the case of files served off disk (as I understand it) are generated based on