Re: svn commit: r797603 - /httpd/mod_fcgid/trunk/mod_fcgid/mod_fcgid.c

2009-07-29 Thread William A. Rowe, Jr.
William A. Rowe, Jr. wrote: > wr...@apache.org wrote: >> Author: wrowe >> Date: Fri Jul 24 18:54:39 2009 >> New Revision: 797603 >> >> URL: http://svn.apache.org/viewvc?rev=797603&view=rev >> Log: >> Remove hop by hop headers and set Connection: close to convince >> all fastcgi consumers that they

Re: svn commit: r798359 - in /httpd/httpd/branches/2.2.x: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c

2009-07-29 Thread Peter Sylvester
Dr Stephen Henson wrote: Peter Sylvester wrote: There is some non-portable code round there that accesses extensions in a most convoluted fashion for some unknown reason. the stuff in ..vars.c ssl_ext_list? Well that too but was mainly thinking of the extension handling

Re: svn commit: r798359 - in /httpd/httpd/branches/2.2.x: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c

2009-07-29 Thread Guenter Knauf
Bill, William A. Rowe, Jr. schrieb: > For trunk, it should be committed. Casts are generally signs of a dumb > compiler or poor coding design and must be avoided. done: http://svn.apache.org/viewvc?view=rev&revision=798989 > I'm generally -1 for stylistic cleanup backports. Although it might bri

Re: svn commit: r798359 - in /httpd/httpd/branches/2.2.x: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c

2009-07-29 Thread William A. Rowe, Jr.
Dr Stephen Henson wrote: > William A. Rowe, Jr. wrote: >> Pity that ml.exe support was stripped (ms\do_masm), it would be a shame >> for most VC users to drop asm optimizations. > > This was mainly due to problems in using some of the more advanced features > needed by the latest optimisations in

Re: svn commit: r798359 - in /httpd/httpd/branches/2.2.x: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c

2009-07-29 Thread Dr Stephen Henson
Peter Sylvester wrote: > > >> There is some non-portable code round there that accesses extensions >> in a most >> convoluted fashion for some unknown reason. >> > the stuff in ..vars.c ssl_ext_list? Well that too but was mainly thinking of the extension handling code in ssl_util_ssl.c the lo

Re: svn commit: r798359 - in /httpd/httpd/branches/2.2.x: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c

2009-07-29 Thread Dr Stephen Henson
William A. Rowe, Jr. wrote: > > Pity that ml.exe support was stripped (ms\do_masm), it would be a shame > for most VC users to drop asm optimizations. > > This was mainly due to problems in using some of the more advanced features needed by the latest optimisations in all versions of MASM. Diff

Re: svn commit: r798359 - in /httpd/httpd/branches/2.2.x: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c

2009-07-29 Thread William A. Rowe, Jr.
Guenter Knauf wrote: > Hi Peter, > Peter Sylvester schrieb: >> A little nit in ssl_engine_init.c: >> instead of >> >> -SSL_CTX_set_client_CA_list(ctx, (STACK *)ca_list); >> +SSL_CTX_set_client_CA_list(ctx, (STACK_OF(X509_NAME) *)ca_list); >> >> I think I'd prefer >> +SSL_CTX

Re: Segfault with fix for CVE-2009-1891

2009-07-29 Thread Ruediger Pluem
On 07/29/2009 01:52 PM, Stefan Fritsch wrote: > > A backtrace is available in the bug report, but it does not reveal much: > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537665#30 Right, it is not really helpful, but as you seem to be able to reproduce the issue can you please create a bac

Re: Segfault with fix for CVE-2009-1891

2009-07-29 Thread Stefan Fritsch
William A. Rowe, Jr. wrote: > One helpful detail, Stefan, would be if this is worker-specific or can > be reproduced with prefork. That helps narrow down the number of places > to consider your question. This happened with prefork, Debian supports mod_php only with prefork. > As I recall, we ha

Re: Segfault with fix for CVE-2009-1891

2009-07-29 Thread Stefan Fritsch
Ruediger Pluem wrote: >> far as I understand it, the reason is that mod_php uses ap_rwrite >> which creates transient buckets. When the connection is closed by the >> client, these buckets sometimes stay in the bucket brigade when >> ap_pass_brigade returns an error for the compressed data of an >>

Re: is it possible to push a patch for Bug 29744 against trunk ?

2009-07-29 Thread Guenter Knauf
Hi Lionel, since no other replied to your post I try to answer your questions ... Lionel VICTOR (free) schrieb: > I'm trying to bring some attention on Bug 29744. its always helpful if you post a link to the bug like this: https://issues.apache.org/bugzilla/show_bug.cgi?id=29744 > This bug is rel

Re: Segfault with fix for CVE-2009-1891

2009-07-29 Thread Jeff Trawick
On Tue, Jul 28, 2009 at 6:24 PM, Akins, Brian wrote: > On 7/28/09 1:35 PM, "Stefan Fritsch" wrote: > > > I have backported r791454 to 2.2.3 in Debian 4.0 and have received a > > report [1] about segfaults with mod_deflate and mod_php (5.2.0). > > Isn't php only officially supported via fastcgi?

Re: svn commit: r798359 - in /httpd/httpd/branches/2.2.x: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c

2009-07-29 Thread Peter Sylvester
Instead it is another cleanup which should go the usual way = apply in HEAD, propose for backport. Please lets separate these things - the bigger we make the one 2.2.x backport patch the lesser the other developers are in the mood to review it. I agree.

Re: svn commit: r798359 - in /httpd/httpd/branches/2.2.x: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c

2009-07-29 Thread Guenter Knauf
Hi Peter, Peter Sylvester schrieb: > A little nit in ssl_engine_init.c: > instead of > > -SSL_CTX_set_client_CA_list(ctx, (STACK *)ca_list); > +SSL_CTX_set_client_CA_list(ctx, (STACK_OF(X509_NAME) *)ca_list); > > I think I'd prefer > +SSL_CTX_set_client_CA_list(ctx, ca_lis