Mutex protection of output bucket brigade

2013-06-12 Thread Alex Bligh
I think I've finally figured out what's going wrong in my module but am unsure what to do about it. The module runs on apache 2.2.22 with mpm prefork. Occasionally I am seeing corruption of the output bucket brigade, primarily the ring pointers (link-next and link-prev) ending up with strange

Re: Mutex protection of output bucket brigade

2013-06-12 Thread Alex Bligh
On 12 Jun 2013, at 10:20, Sorin Manolache wrote: If I understand correctly, the main thread belongs to your module, i.e. it is not a concise pseudo-code of the request processing in apache's code. The main thread is the (presumably single) thread of the prefork mpm process, created (I

Re: Mutex protection of output bucket brigade

2013-06-12 Thread Sorin Manolache
On 2013-06-12 11:48, Alex Bligh wrote: On 12 Jun 2013, at 10:20, Sorin Manolache wrote: If I understand correctly, the main thread belongs to your module, i.e. it is not a concise pseudo-code of the request processing in apache's code. The main thread is the (presumably single) thread of

Re: Mutex protection of output bucket brigade

2013-06-12 Thread Alex Bligh
Sorin, Normally the output brigade is only written during the ap_rprintf/ap_fwrite and the like. OK, so in my case, I run with an SSL filter and the request timeout stuff which also operates as a filter (let's ignore the latter for simplicity) I think what you are saying is: 1. that the

Re: Mutex protection of output bucket brigade

2013-06-12 Thread Sorin Manolache
On 2013-06-12 14:16, Alex Bligh wrote: But that aside, is it safe to call apwrite() from one thread whilst there's a read in the other? I do not know for sure, but I suppose it is not safe if both the read and the write operate on the same brigade. I'm not calling ap_pass_brigade (at

Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread Petr Sumbera
Hi guys, shouldn't Apache 2.2 contain the same change which went for 2.4? http://svn.apache.org/viewvc?view=revisionrevision=1400962 Thanks, Petr

looking for luv

2013-06-12 Thread Jim Jagielski
2 backport proposals looking 4 3vote-luv * mod_proxy_wstunnel: Backport (copy) websocket tunnel proxy submodule * skiplist: Add skiplist functionality

Re: asynch websockets tunnel

2013-06-12 Thread Jim Jagielski
I'm a big +1 on Eric folding this into trunk!

Re: asynch websockets tunnel

2013-06-12 Thread Jim Jagielski
re-looking at this, it would be nice if we could abstract out the callback itself as simply some event, where the callback and the baton itself is self-contained enuff to define what the event is... eg register_anevent_callback :)

Re: looking for luv

2013-06-12 Thread Stefan Fritsch
On Wednesday 12 June 2013, Jim Jagielski wrote: 2 backport proposals looking 4 3vote-luv * skiplist: Add skiplist functionality There doesn't seem to be any user of the skiplist than register_timed_callback, and there doesn't seem to be any user of register_timed_callback besides

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread William A. Rowe Jr.
On Wed, 12 Jun 2013 05:41:35 -0700 (PDT) Petr Sumbera petr.sumb...@oracle.com wrote: Hi guys, shouldn't Apache 2.2 contain the same change which went for 2.4? http://svn.apache.org/viewvc?view=revisionrevision=1400962 In principal, we do not change defaults in a released branch. This was

Re: svn commit: r1491612 - /httpd/httpd/branches/2.4.x/STATUS

2013-06-12 Thread Stefan Fritsch
On Tuesday 11 June 2013, André Malo wrote: trunk patch: http://svn.apache.org/r1491155 2.4.x patch: trunk patch works nd: why would you do that in a stable branch? + sf: Because it is only annoying and serves no purpose anymore. If you + want, we can

Re: svn commit: r1491700 - /httpd/httpd/trunk/modules/metadata/mod_mime_magic.c

2013-06-12 Thread Christophe JAILLET
Le 11/06/2013 09:41, jaillet...@apache.org a écrit : Author: jailletc36 Date: Tue Jun 11 07:41:40 2013 New Revision: 1491700 URL:http://svn.apache.org/r1491700 Log: According to comment in 'magic_rsl_add' and to the way 'magic_rsl_printf' manages its buffer, I think that this memory should be

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread Reindl Harald
Am 12.06.2013 21:15, schrieb William A. Rowe Jr.: I believe the change is outside of the scope which server authors should entertain, and it is up to the user agent authors to make an intelligent choice knowing the risks and lack of risks in their agent implementation yes and no in fact if

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread Stefan Fritsch
On Wednesday 12 June 2013, William A. Rowe Jr. wrote: On Wed, 12 Jun 2013 05:41:35 -0700 (PDT) Petr Sumbera petr.sumb...@oracle.com wrote: Hi guys, shouldn't Apache 2.2 contain the same change which went for 2.4? http://svn.apache.org/viewvc?view=revisionrevision=1400962 In

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread Eric Covener
Perhaps this time, we entertain a proper vote rather than a pair of devs electing to change defaults on a whim. Stable branches are RTC for a reason. Huh? We had three devs voting for the backport. What more do you want? FWIW I noticed in archive that sf was left off in the commit message

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread William A. Rowe Jr.
On Wed, 12 Jun 2013 21:24:31 +0200 Reindl Harald h.rei...@thelounge.net wrote: well, on Redhat systems in /etc/sysconfig/httpd put the line OPENSSL_NO_DEFAULT_ZLIB=1 did disable it before httpd offered a option, but IHMO any server software should come with as much as secure defaults if they

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread William A. Rowe Jr.
On Wed, 12 Jun 2013 21:27:18 +0200 Stefan Fritsch s...@sfritsch.de wrote: On Wednesday 12 June 2013, William A. Rowe Jr. wrote: On Wed, 12 Jun 2013 05:41:35 -0700 (PDT) In principal, we do not change defaults in a released branch. That's not true. It doesn't happen very often but it

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread Reindl Harald
Am 12.06.2013 21:49, schrieb William A. Rowe Jr.: On Wed, 12 Jun 2013 21:24:31 +0200 Reindl Harald h.rei...@thelounge.net wrote: well, on Redhat systems in /etc/sysconfig/httpd put the line OPENSSL_NO_DEFAULT_ZLIB=1 did disable it before httpd offered a option, but IHMO any server software

Re: looking for luv

2013-06-12 Thread Jim Jagielski
On Wed, Jun 12, 2013 at 09:08:00PM +0200, Stefan Fritsch wrote: On Wednesday 12 June 2013, Jim Jagielski wrote: 2 backport proposals looking 4 3vote-luv * skiplist: Add skiplist functionality There doesn't seem to be any user of the skiplist than register_timed_callback, and there

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread Reindl Harald
Am 12.06.2013 21:52, schrieb William A. Rowe Jr.: On Wed, 12 Jun 2013 21:27:18 +0200 Stefan Fritsch s...@sfritsch.de wrote: All web *browsers* that support compression are affected. Only non- browser clients are not affected. Calling that far from all stretches things a bit. You would

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread Eric Covener
On Wed, Jun 12, 2013 at 3:49 PM, William A. Rowe Jr. wr...@rowe-clan.net wrote: On Wed, 12 Jun 2013 21:24:31 +0200 Reindl Harald h.rei...@thelounge.net wrote: well, on Redhat systems in /etc/sysconfig/httpd put the line OPENSSL_NO_DEFAULT_ZLIB=1 did disable it before httpd offered a option,

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread Ben Laurie
On 12 June 2013 20:49, William A. Rowe Jr. wr...@rowe-clan.net wrote: On Wed, 12 Jun 2013 21:24:31 +0200 Reindl Harald h.rei...@thelounge.net wrote: well, on Redhat systems in /etc/sysconfig/httpd put the line OPENSSL_NO_DEFAULT_ZLIB=1 did disable it before httpd offered a option, but IHMO

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread William A. Rowe Jr.
On Wed, 12 Jun 2013 15:57:22 -0400 Eric Covener cove...@gmail.com wrote: On Wed, Jun 12, 2013 at 3:49 PM, William A. Rowe Jr. wr...@rowe-clan.net wrote: On Wed, 12 Jun 2013 21:24:31 +0200 Reindl Harald h.rei...@thelounge.net wrote: well, on Redhat systems in /etc/sysconfig/httpd put the

Re: looking for luv

2013-06-12 Thread William A. Rowe Jr.
On Wed, 12 Jun 2013 15:55:15 -0400 Jim Jagielski j...@jagunet.com wrote: On Wed, Jun 12, 2013 at 09:08:00PM +0200, Stefan Fritsch wrote: On Wednesday 12 June 2013, Jim Jagielski wrote: 2 backport proposals looking 4 3vote-luv * skiplist: Add skiplist functionality There doesn't

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread Stefan Fritsch
On Wednesday 12 June 2013, William A. Rowe Jr. wrote: In fact, the patch's docs text is wrong on the face of it; Enabling compression causes security issues in most setups (the so called +CRIME attack) This is true of specific setups where the user agent simultaneously shares a

Re: looking for luv

2013-06-12 Thread Jim Jagielski
On Jun 12, 2013, at 4:24 PM, William A. Rowe Jr. wr...@rowe-clan.net wrote: My question is not whether that feature is useful, rather whether this belongs in httpd, or is a better candidate for apr? Either is fine, I guess. However, my plan is that the eventopt stuff will eventually get

Re: Apache 2.2 - Change default for SSLCompression to off

2013-06-12 Thread William A. Rowe Jr.
On Wed, 12 Jun 2013 21:05:05 +0100 Ben Laurie b...@links.org wrote: On 12 June 2013 20:49, William A. Rowe Jr. wr...@rowe-clan.net wrote: On Wed, 12 Jun 2013 21:24:31 +0200 Reindl Harald h.rei...@thelounge.net wrote: well, on Redhat systems in /etc/sysconfig/httpd put the line