Fwd: nonportable-atomics configure.in setting

2013-12-04 Thread Yann Ylavic
Sorry, I had no intention to send this offlist. -- Forwarded message -- From: Yann Ylavic ylavic@gmail.com Date: Wed, Dec 4, 2013 at 10:37 AM Subject: Re: nonportable-atomics configure.in setting To: Daniel Lescohier daniel.lescoh...@cbsi.com On Wed, Dec 4, 2013 at 1:22 AM,

Re: unsetting encrypted cookies when encryption key changes

2013-12-04 Thread Thomas Eckert
1 user tries to browse protected resource 2 user is redirected to form 3 user fills in and submits form 4 user is redirected to AuthFormLoginSuccessLocation and receives encrypted session cookie (encrypted with key A) 5 encryption key changes from key A to key B 6 user tries to browse

Re: nonportable-atomics configure.in setting

2013-12-04 Thread Yann Ylavic
On Wed, Dec 4, 2013 at 10:40 AM, Yann Ylavic ylavic@gmail.com wrote: On Wed, Dec 4, 2013 at 1:22 AM, Daniel Lescohier daniel.lescoh...@cbsi.com wrote: I see this in configure.in: AC_ARG_ENABLE(nonportable-atomics, [ --enable-nonportable-atomics Use optimized atomic code which may

Re: nonportable-atomics configure.in setting

2013-12-04 Thread Yann Ylavic
On Wed, Dec 4, 2013 at 11:02 AM, Yann Ylavic ylavic@gmail.com wrote: After r64861: native atomics are disabled (forcibly) on those CPUs, whatever --enable-nonportable-atomics is. Sorry, --enable-nonportable-atomics is still honored, I misread the code.

Re: nonportable-atomics configure.in setting

2013-12-04 Thread Yann Ylavic
On Wed, Dec 4, 2013 at 11:11 AM, Yann Ylavic ylavic@gmail.com wrote: On Wed, Dec 4, 2013 at 11:02 AM, Yann Ylavic ylavic@gmail.com wrote: After r64861: native atomics are disabled (forcibly) on those CPUs, whatever --enable-nonportable-atomics is. Sorry,

Re: adding hook into mod_auth_form

2013-12-04 Thread Thomas Eckert
I saw those but figured since I was not using any AUTH_DECLARE I would be fine. I'm now using diff --git a/include/mod_auth.h b/include/mod_auth.h index 9b9561e..8807a5c 100644 --- a/include/mod_auth.h +++ b/include/mod_auth.h @@ -134,6 +134,30 @@ APR_DECLARE_OPTIONAL_FN(void,

Re: nonportable-atomics configure.in setting

2013-12-04 Thread Yann Ylavic
On Wed, Dec 4, 2013 at 10:40 AM, Yann Ylavic ylavic@gmail.com wrote: Sorry, I had no intention to send this offlist. Well, I really strayed here, I just realize now this is the wrong list. Sorry again Daniel and httpd folks, I'll now restate all that to the apr list :)

Re: time caching in util_time.c and mod_log_config.c

2013-12-04 Thread Jim Jagielski
Adding APR dev list: IMO, httpd should expect APR to do the right thing. If APR isn't doing that, then it's an APR bug and needs to be fixed/ addressed within APR. All this implies that the atomics code in APR needs a serious review and update. We should also look into leveraging what we can

Re: time caching in util_time.c and mod_log_config.c

2013-12-04 Thread Daniel Lescohier
On Wed, Dec 4, 2013 at 7:47 AM, Jim Jagielski j...@jagunet.com wrote: Also, IMO, the default should be non-portable atomics. Yes: that is the purpose of APR: having a portable API on top of non-portable implementations for each platform.

Re: time caching in util_time.c and mod_log_config.c

2013-12-04 Thread Daniel Lescohier
So it sounds like I should go ahead and work on an implementation of the time caching using apr_atomic_cas32 and apr_atomic_dec32. This won't be an issue for RHEL/CentOS/etc., because they're using old versions of httpd. We can put something in the release notes saying that for 32-bit i486, i586,

Re: time caching in util_time.c and mod_log_config.c

2013-12-04 Thread Jim Jagielski
+1 On Dec 4, 2013, at 11:19 AM, Daniel Lescohier daniel.lescoh...@cbsi.com wrote: So it sounds like I should go ahead and work on an implementation of the time caching using apr_atomic_cas32 and apr_atomic_dec32. This won't be an issue for RHEL/CentOS/etc., because they're using old

Some redundant code and comment typos in mod_remoteip

2013-12-04 Thread Mike Rumph
While researching mod_remoteip to work on httpd bugs 55635 and 55637, I noticed a few unrelated blemishes in mod_remoteip.c. These include some redundant code and comment typos. The attached patch against httpd trunk should address these. Thanks, Mike Rumph Index: