On Fri, Jun 13, 2014 at 1:20 AM, Yann Ylavic wrote:
> On Fri, Jun 13, 2014 at 1:09 AM, Yann Ylavic wrote:
>> On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic wrote:
>>> The most important imho is to not truncate the length at sizeof(struct
>>> sockaddr_un) when the real sun_path is beyond sizeof(su
On Fri, Jun 13, 2014 at 1:09 AM, Yann Ylavic wrote:
> On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic wrote:
>> The most important imho is to not truncate the length at sizeof(struct
>> sockaddr_un) when the real sun_path is beyond sizeof(sun_path).
>> The libc calls are probably bullet proof regar
On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic wrote:
> The most important imho is to not truncate the length at sizeof(struct
> sockaddr_un) when the real sun_path is beyond sizeof(sun_path).
> The libc calls are probably bullet proof regarding NUL termination
> (eg. force ((char*)sun)[addrlen] =
On Thu, Jun 12, 2014 at 10:30 PM, Christophe JAILLET
wrote:
> Le 10/06/2014 18:19, Yann Ylavic a écrit :
>
>> On Sun, Jun 1, 2014 at 8:54 AM, wrote:
>>> /* TODO: In APR 2.x: Extend apr_sockaddr_t to possibly be a path !!! */
>>> +/* XXX: The same function exists in proxy_util.c */
>>
>> Shouldn
Le 10/06/2014 18:19, Yann Ylavic a écrit :
On Sun, Jun 1, 2014 at 8:54 AM, wrote:
Author: jailletc36
Date: Sun Jun 1 06:54:15 2014
New Revision: 1598946
URL: http://svn.apache.org/r1598946
Log:
Fix computation of the size of 'struct sockaddr_un' when passed to 'connec()'.
s/connec()/connect
> -Ursprüngliche Nachricht-
> Von: Yann Ylavic
> Gesendet: Donnerstag, 12. Juni 2014 13:10
> An: httpd
> Betreff: Re: svn commit: r1601877 -
> /httpd/httpd/trunk/modules/filters/mod_sed.c
>
> Thanks for the review.
>
> On Thu, Jun 12, 2014 at 9:13 AM, Ruediger Pluem
> wrote:
> >
> >
>
Thanks for the review.
On Thu, Jun 12, 2014 at 9:13 AM, Ruediger Pluem wrote:
>
>
> yla...@apache.org wrote:
>> Author: ylavic
>> Date: Wed Jun 11 12:50:29 2014
>> New Revision: 1601877
>>
>> URL: http://svn.apache.org/r1601877
>> Log:
>> mod_sed: Reuse ctx->bb in sed_response_filter() and be saf
yla...@apache.org wrote:
> Author: ylavic
> Date: Wed Jun 11 12:50:29 2014
> New Revision: 1601877
>
> URL: http://svn.apache.org/r1601877
> Log:
> mod_sed: Reuse ctx->bb in sed_response_filter() and be safe with its
> reentrance. The single return point helps to not duplicate cleanup code.
>
>
