Re: Unhappy interactions between AIX, apxs, instdso.sh, apr/build-1/libtool and php

2014-06-21 Thread Victor J. Orlikowski
On Jun 20, 2014, at 12:34 PM, Michael Felt  wrote:
> Here is the patch - as text, and a file (not sure what normal is, but since 
> it is small doing both).


So - I looked at what you did here, and then compared it both against what’s in 
httpd-2.4.x and httpd-trunk.

What happens when you use the instdso.sh from httpd-trunk, rather than what you 
have in your patch?
You can get it from here: 
https://svn.apache.org/repos/asf/httpd/httpd/trunk/build/instdso.sh

Looks to me that the instdso.sh from trunk performs the same function, except 
for multiple DSO names, and has some accomodations for AIX.

If that works - it makes sense to me to pull the instdso.sh from trunk back to 
2.4.x and 2.2.x.

Best,
Victor
--
Victor J. Orlikowski <> victor.j.orlikow...@alumni.duke.edu



Re: svn commit: r1604373 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS support/ab.c

2014-06-21 Thread Yann Ylavic
On Sat, Jun 21, 2014 at 11:24 PM, Jeff Trawick  wrote:
> On Sat, Jun 21, 2014 at 4:49 PM, Marion & Christophe JAILLET
>  wrote:
>>
>> Hi,
>>
>> doc should also be updated accordingly + compatibility note should be
>> added to state in which version this -m option has been added.
>
>
> Thanks for noting this.  We shouldn't have voted to include it in the 2.4.x
> branch without documentation.
>
> r1604461 and r1604463.

Thanks for the work Jeff, I should have done it.


Re: svn commit: r1604373 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS support/ab.c

2014-06-21 Thread Jeff Trawick
On Sat, Jun 21, 2014 at 4:49 PM, Marion & Christophe JAILLET <
christophe.jail...@wanadoo.fr> wrote:

> Hi,
>
> doc should also be updated accordingly + compatibility note should be
> added to state in which version this -m option has been added.
>

Thanks for noting this.  We shouldn't have voted to include it in the 2.4.x
branch without documentation.

r1604461 and r1604463.


>
>
> For your information,, I have a pending patch on my computer for missing
> compatibility notes in "support" applications updated in previous releases.
> Will be applied shortly.
>
> CJ
>
> Le 21/06/2014 15:41, traw...@apache.org a écrit :
>
>  Author: trawick
>> Date: Sat Jun 21 13:41:28 2014
>> New Revision: 1604373
>>
>> URL:http://svn.apache.org/r1604373
>> Log:
>> Merge r1601076 from trunk:
>>
>> ab: support custom HTTP method with -m argument.
>>
>> PR: 56604
>> Submitted by: Roman Jurkov 
>> Reviewed by: ylavic, trawick, covener
>>
>> (r1601680 and r1601700 not reflected in mergeinfo due to
>> a collision with an unrelated trunk change)
>>
>> Modified:
>>  httpd/httpd/branches/2.4.x/   (props changed)
>>  httpd/httpd/branches/2.4.x/CHANGES
>>  httpd/httpd/branches/2.4.x/STATUS
>>  httpd/httpd/branches/2.4.x/support/ab.c
>>
>
>


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/
http://edjective.org/


Re: svn commit: r1604373 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS support/ab.c

2014-06-21 Thread Marion & Christophe JAILLET

Hi,

doc should also be updated accordingly + compatibility note should be 
added to state in which version this -m option has been added.



For your information,, I have a pending patch on my computer for missing 
compatibility notes in "support" applications updated in previous releases.

Will be applied shortly.

CJ

Le 21/06/2014 15:41, traw...@apache.org a écrit :

Author: trawick
Date: Sat Jun 21 13:41:28 2014
New Revision: 1604373

URL:http://svn.apache.org/r1604373
Log:
Merge r1601076 from trunk:

ab: support custom HTTP method with -m argument.

PR: 56604
Submitted by: Roman Jurkov 
Reviewed by: ylavic, trawick, covener

(r1601680 and r1601700 not reflected in mergeinfo due to
a collision with an unrelated trunk change)

Modified:
 httpd/httpd/branches/2.4.x/   (props changed)
 httpd/httpd/branches/2.4.x/CHANGES
 httpd/httpd/branches/2.4.x/STATUS
 httpd/httpd/branches/2.4.x/support/ab.c




Re: svn commit: r1572561 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_http.c proxy_util.c

2014-06-21 Thread Yann Ylavic
On Sat, Jun 21, 2014 at 3:18 PM, Eric Covener  wrote:
> was the proxy_util.c change intended?

Yes, this is to avoid another (useless) socket_cleanup() + close = 0 below.


Re: svn commit: r1572561 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_http.c proxy_util.c

2014-06-21 Thread Eric Covener
was the proxy_util.c change intended?


On Thu, Feb 27, 2014 at 8:39 AM,   wrote:
> Author: ylavic
> Date: Thu Feb 27 13:39:25 2014
> New Revision: 1572561
>
> URL: http://svn.apache.org/r1572561
> Log:
> Avoid seless functions calls.
>
> Modified:
> httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
> httpd/httpd/trunk/modules/proxy/proxy_util.c
>
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_http.c?rev=1572561&r1=1572560&r2=1572561&view=diff
> ==
> --- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Thu Feb 27 13:39:25 2014
> @@ -1744,7 +1744,6 @@ int ap_proxy_http_process_response(apr_p
>  #endif
>  /* sanity check */
>  if (APR_BRIGADE_EMPTY(bb)) {
> -apr_brigade_cleanup(bb);
>  break;
>  }
>
>
> Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=1572561&r1=1572560&r2=1572561&view=diff
> ==
> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
> +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Thu Feb 27 13:39:25 2014
> @@ -2284,6 +2284,7 @@ ap_proxy_determine_connection(apr_pool_t
>  conn->pool);
>  }
>  socket_cleanup(conn);
> +conn->close = 0;
>  }
>  if (will_reuse) {
>  /*
>
>



-- 
Eric Covener
cove...@gmail.com


Re: yet another mod_ssl temp DH handling tweak

2014-06-21 Thread Kaspar Brand
On 19.06.2014 23:17, Joe Orton wrote:
> I was reminded that there was a request to use the larger key sizes as 
> well.

Using ephemeral DH keys with sizes > 4096 bits in TLS seems way overkill
for the next decade or so (3072 bits are already considered to have a
128-bit symmetric-key strength), but if it makes people happy to use
unreasonably large keys, then so be it... the docs for
SSLCertificateFile should also be updated in this case.

> +/* Storage and initialization for DH parameters. */
> +static struct dhparam {
> +BIGNUM *(*const prime)(BIGNUM *); /* function to generate... */
> +DH *dh;   /* ...this, used for keys */
> +const unsigned int min;   /* ...of length >= this. */
> +} dhparams[] = {
> +{ get_rfc3526_prime_8192, NULL, 6145 },
> +{ get_rfc3526_prime_6144, NULL, 4097 },
> +{ get_rfc3526_prime_4096, NULL, 3073 },
> +{ get_rfc3526_prime_3072, NULL, 2049 },
> +{ get_rfc3526_prime_2048, NULL, 1025 },
> +{ get_rfc2409_prime_1024, NULL, 0 }
> +};

Perhaps the "min" values could increased somewhat -
7168/5120/3584/2560/1536 (i.e. "half way" between two steps)?

Kaspar