[PATCH 57300] mod_session save optimization

2015-08-20 Thread Paul Spangler
Hello, The bug report contains a more detailed explanation of the patch, but there are some points I thought might lead to some discussion. First a quick summary of the issue: mod_session writes out the session every request even if there aren't any changes to the data. This makes some sense

Re: httpd-trunk\modules\http2\h2_session.c Mystery

2015-08-20 Thread NormW
On 20/08/2015 8:39 PM, Yann Ylavic wrote: Hi, On Thu, Aug 20, 2015 at 11:56 AM, NormW wrote: #File: h2_session.c # - # 512:nghttp2_session_callbacks_set_on_invalid_frame_recv_callback(*pcb, on_invalid_frame_recv_cb) # Error: ^ # illegal implicit conversion #

Re: httpd-trunk\modules\http2\h2_session.c Mystery

2015-08-20 Thread Stefan Eissing
Ah, yes. I think that once changed in an older nghttp2 release and went unnoticed. Thanks for the fix! > Am 20.08.2015 um 12:39 schrieb Yann Ylavic : > > Hi, > > On Thu, Aug 20, 2015 at 11:56 AM, NormW wrote: >>> >>> #File: h2_session.c >>> # - >>> # >>> 512:nghttp2_se

Re: httpd-trunk\modules\http2\h2_session.c Mystery

2015-08-20 Thread Yann Ylavic
Hi, On Thu, Aug 20, 2015 at 11:56 AM, NormW wrote: >> >> #File: h2_session.c >> # - >> # >> 512:nghttp2_session_callbacks_set_on_invalid_frame_recv_callback(*pcb, > > on_invalid_frame_recv_cb) >> >> # Error: >> ^ >> # illegal implicit conversion >> # from 'int(st

httpd-trunk\modules\http2\h2_session.c Mystery

2015-08-20 Thread NormW
Hi, My compiler (no names) is vastly smarter than I at understanding C, but I can't tell if the following 'error' is drivel or just over my head; #File: h2_session.c # - # 512:nghttp2_session_callbacks_set_on_invalid_frame_recv_callback(*pcb, on_invalid_frame_recv_c