2.4.17-protocols-http2 :: Restarting

Running live now for almost two days, see https://www.apachelounge.com/viewtopic.php?p=31674 Was running fine, expect the log is filled with mod_h2 warnings (see below) Suddenly after a few hours, it was starting all over and over, 105 times. And running fine for a few hours without restarting.

Re: graceful child process exit

On 2015-09-21 00:45, Massimo Manghi wrote: Hi, I'm working on an issue with mod_rivet, a content generator module that embeds in Apache the interpreter of the Tcl scripting language. I won't bother you with the details of the problem (but if anyone is interested I'm ready to answer any

Re: 2.4.17-protocols-http2 :: Restarting

I did a little bit more on the session close/abort handling. Checked into the 2.4.17-xxx branch. //Stefan > Am 21.09.2015 um 12:29 schrieb Steffen : > > Applied h2_conn_io.c Revision 1704241 (removed wrong error supression in h2 > connection writes) > >

Re: 2.4.17-protocols-http2 :: Restarting

Running now with it. See in loglevel notice not the warnings anymore. Thanks, Steffen On Monday 21/09/2015 at 13:14, Stefan Eissing wrote: I did a little bit more on the session close/abort handling. Checked into the 2.4.17-xxx branch. //Stefan Am 21.09.2015 um 12:29 schrieb Steffen

Re: Thoughts on the new Protocols architecture

Jacob, thanks a lot for reviewing/implementing it. Having another module use it helps seeing the current weaknesses. Detailed comments inline: > Am 21.09.2015 um 06:22 schrieb Jacob Champion : > > == Immediate Concerns == > > 1) WebSocket requires a handshake to be made

Re: 2.4.17-protocols-http2 :: Restarting

Set it to loglevel info. All looks fine, same as former with a lot of ssl warnings ; [ssl:info] [pid 8324:tid 3868] (70014)End of file found: [client 157.55.39.98:12963] AH01991: SSL input filter read failed Noticed that it looks like double logging, mod_ssl and mod_h2: [Mon Sep 21

Re: Thoughts on the new Protocols architecture

Stefan, On 09/21/2015 05:00 AM, Stefan Eissing wrote: I think a "protocol_ugprade" hook would work better. That way, a module like yours can replace the core upgrade handling itself, send your own 101 response and call ap_switch_protocol() yourself. Would that work for you? Yes, a separate

Re: 2.4.17-protocols-http2 :: Restarting

Applied h2_conn_io.c Revision 1704241 (removed wrong error supression in h2 connection writes) https://www.apachelounge.com/ running now with it. Steffen -Original Message- From: Stefan Eissing Sent: Monday, September 21, 2015 11:11 AM To: dev@httpd.apache.org Subject: Re:

Re: svn commit: r1688474 [4/21] - in /httpd/httpd/trunk/modules/http2: ./ m4/ mod-h2.xcodeproj/ mod-h2.xcodeproj/project.xcworkspace/ mod-h2.xcodeproj/project.xcworkspace/xcshareddata/ mod-h2.xcodepro

Hi Stefan, > > Added: httpd/httpd/trunk/modules/http2/mod_h2/h2_conn_io.c > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/mod_h2/h2_conn_io.c?rev=1688474=auto > == > ---

Re: 2.4.17-protocols-http2 :: Restarting

About the huge number of warnings [h2:warn] [pid 2036:tid 4008] (OS 10060)A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. : [client 84.105.35.206:58278]

Re: 2.4.17-protocols-http2 :: Restarting

Yeah, I think when I initially wrote this code, I wanted to err on the side of catching my mistakes. Time to level down the common conditions that happen, e.g. when client just disconnect. > Am 21.09.2015 um 11:05 schrieb Steffen : > > About the huge number of warnings >

Re: svn commit: r1688474 [4/21] - in /httpd/httpd/trunk/modules/http2: ./ m4/ mod-h2.xcodeproj/ mod-h2.xcodeproj/project.xcworkspace/ mod-h2.xcodeproj/project.xcworkspace/xcshareddata/ mod-h2.xcodepro

Admittedly, my memory is hazy. I cannot really rationalize its existence. This looks wrong now. I will throw it out. > Am 21.09.2015 um 10:53 schrieb Yann Ylavic : > > Hi Stefan, > >> >> Added: httpd/httpd/trunk/modules/http2/mod_h2/h2_conn_io.c >> URL: >>

Re: 2.4.17-protocols-http2 :: Forcing termination of child process

Thanks for the heads up. The shutdown behaviour is most likely influenced by how many connections are open at that time and http2 connection are kept open longer by clients. Probably we can improve the observed behaviour. There has not been much focus on that part of the protocol handling...