Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jacob Champion]

On Fri, Dec 16, 2016 at 10:29 AM, Jim Jagielski  wrote:
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
>
> [x] +1: Good to go

Ubuntu 16.04 x64, both the httpd (minus ext_filter) and mod_websocket
test suites.
Windows 7 x64, mod_websocket test suite (still can't, for the life of
me, get the httpd test suite running correctly on Windows...).

--Jacob

Alias within Location: loss of PATH_INFO

[Blaise]

(NB: Below is a synthetic test; in real world, this breaks hgweb, for example; 
also, for script handlers, meddling with AcceptPathInfo is not needed.)

Consider the following sample configuration:
--8<--
Alias /test "${site}/test/test.ssi.txt"

AcceptPathInfo on
Options +Includes
AddOutputFilter includes .ssi
Require all granted

--8<--
The said test file (which is a plain text file containing only ""), when invoked as http://example.com/test/path , has the following correct 
environment:
--8<-- PART A -- same in this case and in the case below
DOCUMENT_ROOT=/var/www/common/empty
REQUEST_URI=/test/path
QUERY_STRING=
DOCUMENT_URI=/test/path
DOCUMENT_NAME=test.ssi.txt
DOCUMENT_ARGS=
SCRIPT_FILENAME=/var/www/test/test.ssi.txt
--8<-- PART B -- going to change in the case below
SCRIPT_NAME=/test
CONTEXT_PREFIX=/test
CONTEXT_DOCUMENT_ROOT=/var/www/test/test.ssi.txt
PATH_INFO=/path
PATH_TRANSLATED=/var/www/common/empty/path
DOCUMENT_PATH_INFO=/path
--8<--
However, if the Alias directive is moved into Location:
--8<--

AcceptPathInfo on
Alias "${site}/test/test.ssi.txt"
Options +Includes
AddOutputFilter includes .ssi
Require all granted

--8<--
then the B part of the environment changes to:
--8<-- new PART B -- changed
SCRIPT_NAME=/test/path
CONTEXT_PREFIX=
CONTEXT_DOCUMENT_ROOT=/var/www/common/empty
--8<--
Id est, the context "/test" is lost, and the attribution of "/path" is changed 
from PATH_INFO to SCRIPT_NAME.
Am I correct to understand that this is an implementation bug; or at very least 
a documentation bug? (since I cannot find anything related under 
https://httpd.apache.org/docs/trunk/mod/mod_alias.html#alias )

(I tested this with httpd.x86_64 version 2.4.23-5.fc25 on Fedora Server, and I 
browsed through the bug tracker to check if this was reported/fixed recently.)

--
βþ

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Yann Ylavic]

On Fri, Dec 16, 2016 at 7:29 PM, Jim Jagielski  wrote:
>
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.

[X] +1: Good to go

Tested on Debian stretch/sid, jessie, wheezy (amd64).

enable-mods-shared=reallyall
All tests passed (but mod_session's TODOs and known ext_filter case).
PGP/SHA1/MD5 match.

Thanks for RMing Jim!

PS: somehow mod_session_cookie is loaded (uncommented) by default in
httpd.conf, but not its dependency mod_session (which makes the tests
suite fail by default..).

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

It isn't based on the modules/*.so contents, but based on the draft
conf/httpd.conf indicated by apxs.

I had the converse problem, with --enable-modules-all I accidentally loaded
both cgi and cgid.

On Dec 18, 2016 02:43, "Nick Kew"  wrote:

On Sat, 2016-12-17 at 20:32 -0500, Eric Covener wrote:
> I think your t/conf/extra.conf is out of date and has the +ExecCGI
> masked out by . So you are getting the perl script
> instead of its output setting nasty headers.

[pre-breakfast post: not yet at the desktop where I ran the tests]

For what it's worth, this was a pristine trunk repo of the test suite
as of date about 12 hours ago.  As ever, built/run in a directory
newly created by lndir so as never to pollute the repo.

However, there's a message earlier in the tests: CGI tests skipped
because neither mod_cgi nor mod_cgid were found (nonsense: mod_cgid.so
is in its expected place in /modules/ ).  Looks like some gremlin
in the test suite, plus running those tests when CGI tests had been
skipped.

--
Nick Kew

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Nick Kew]

On Sat, 2016-12-17 at 20:32 -0500, Eric Covener wrote:
> I think your t/conf/extra.conf is out of date and has the +ExecCGI
> masked out by . So you are getting the perl script
> instead of its output setting nasty headers.

[pre-breakfast post: not yet at the desktop where I ran the tests]

For what it's worth, this was a pristine trunk repo of the test suite
as of date about 12 hours ago.  As ever, built/run in a directory
newly created by lndir so as never to pollute the repo.

However, there's a message earlier in the tests: CGI tests skipped
because neither mod_cgi nor mod_cgid were found (nonsense: mod_cgid.so
is in its expected place in /modules/ ).  Looks like some gremlin
in the test suite, plus running those tests when CGI tests had been
skipped.

-- 
Nick Kew